• Ng Zhi An's avatar
    [ia32] Fix partial regression in Cvtsi2ss/Cvtsi2sd · 5f622d21
    Ng Zhi An authored
    In https://crrev.com/c/3131374 we switched some instructions to use
    macro-assembler functions which can handle AVX and SSE. However for
    Cvtsi2ss and Cvtsi2sd, the behavior subtly changed. The old behavior
    directly called cvtsi2ss/cvtsi2sd in the code-generator. The new
    behavior used the macro-assembler functions, which xor the dst operand.
    This led to more instructions and larger code size in some benchmarks.
    The xor is supposed to help reduce dependence chain length (see comments
    on Cvtsi2ss), but doesn't seem to have helped in this benchmark.
    
    So, partially revert the changes, and rename all affected IA32 opcodes
    back to SSE.
    
    Bug: chromium:1248509
    Change-Id: Ie700e2980fe9ed083c1160bda3a28f64e1e43041
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3154349
    Commit-Queue: Zhi An Ng <zhin@chromium.org>
    Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#76775}
    5f622d21
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...