• Michael Lippautz's avatar
    heap: ArrayBufferSweeper refactoring · 210987a5
    Michael Lippautz authored
    The refactoring is triggered by https://crrev.com/c/3121905 where we
    noticed that a bunch of tricky counter paths could be simplified,
    making reasoning about corectness easier.
    
    In this CL:
    1. Use uniqe_ptr instead of Optional to allow moving SweepingJob away
       from the header file.
    2. sweeping_in_progress_ is replaced with simply checking for a job.
    3. freed_bytes_ are moved to the job and the dependency is reversed,
       avoiding the inside-out (Job->Sweeper) dependency completely.
    4. Merge() and counter updates are merged into a Finalize() method.
    5. FinishIfDone() allows for conditional finization.
    6. young_bytes_ and old_bytes_ are removed as they were always updated
       when the corresponding bytes in the ArrayBufferList was updated.
    
    Change-Id: I56e5b04087166ce03d3a9195ac48359122a84c73
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3124776Reviewed-by: 's avatarDominik Inführ <dinfuehr@chromium.org>
    Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#76795}
    210987a5
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...