- 25 Oct, 2021 18 commits
-
-
Vasili Skurydzin authored
Bug: v8:12297 Change-Id: Ifbf6ac61e6b61e419b361d1fc14009d6d745193c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3231484Reviewed-by:
Milad Fa <mfarazma@redhat.com> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Vasili Skurydzin <vasili.skurydzin@ibm.com> Cr-Commit-Position: refs/heads/main@{#77528}
-
Omer Katz authored
ObjectSizeTrait::GetSize is used by Trace methods in Blink and may be called while concurrent marking is active. The current version is non-atmoic and therefore can race with marking on other threads. Bug: chromium:1261860 Change-Id: Ia0b41ec496ac64ae3dd5a040b25f6972b21561c5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3240832Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77527}
-
Milad Fa authored
variable 'pushed_stack_space' set but not used. Change-Id: I427f76448b9933f9c8f1169709e28eef4512241f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3241543Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#77526}
-
Thibaud Michaud authored
R=ahaas@chromium.org Change-Id: I860cd7aebdf46f323c7f6ad0cd563246a061c4d1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3226338 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#77525}
-
Camillo Bruni authored
For the upcoming host_defined_options fixes we will have to explicitly pass the host-defined options to Invoke so we will be able to install it in the script context in the future. Bug: chromium:1244145 Change-Id: I690cc774d6a17278db4381aba8c3408e979606c1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3222765 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#77524}
-
Michael Lippautz authored
Persistent node slots are dynamically allocated and their allocation may fail. Delegate to the proper OOM handler in this case. Bug: chromium:1243257 Change-Id: I985f5b0c940f7ac4996f3f3243123a07119005b9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3240786Reviewed-by:
-
v8-ci-autoroll-builder authored
R=clemensb@chromium.org Change-Id: Ia804d29a61e9d716b5ee5acebce7cb9c273697d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3241363 Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#77522}
-
Maya Lekova authored
This CL fixes an issue in EffectControlLinearizer, where the primitive type of the argument of a fast C call was used to compute its MachineType even when the argument was actually a TypedArray, which should always be treated as a Tagged type. This resulted in Float32/64 typed arrays being passed in FP registers, leading to a crash in the register allocator. Drive-by fix: Fixed output from --trace-turbo-alloc so that all of its sub-parts are printed with PrintF, avoiding interleaved log lines. Bug: chromium:1260954 Change-Id: I249c8629daae3af437fb52f53f45211f3a214222 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3231341Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#77521}
-
Victor Gomes authored
Drive-by: Use only LocalIsolate in AllocateConcurrentSP Bug: v8:12054 Change-Id: Ibdd8b562548f249fc2be4dca723ce4fedc7c09ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3240783 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#77520}
-
Igor Sheludko authored
Bug: v8:11880 Change-Id: I9a936c293e261142111e235c041e3526680d9629 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3240828Reviewed-by:
-
Michael Lippautz authored
Marking verification should only process young generation objects when verifying the marking state of a young generation garbage collection. Bug: v8:12324 Change-Id: I01db261437ec5c42ddb6c79c44e31b5fe0e536d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3231343Reviewed-by:
-
Jakob Gruber authored
No-Try: true Bug: chromium:1262423 Change-Id: I9d56e347d046944f01e33aa6fb8752c889e2d38d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3240784 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Nico Hartmann authored
Bug: chromium:1254189 Change-Id: I77854c767cf5c5748999fdd40a4a42e25dff3f79 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3236989Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#77516}
-
Manos Koukoutos authored
We introduce simple escape analysis for wasm-gc objects, where struct allocations that are only assigned to are eliminated. Handling phi uses of allocated objects is left for future work. Bug: v8:11510 Change-Id: Ibd0b220466546e150b26b02890572a5174c6872d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3229744Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#77515}
-
Jakob Gruber authored
Character class handling in the irregexp pipeline is quite complex; codepoints outside the BMP (basic multilingual plane) are only translated into surrogate pairs when needed, e.g. when the subject string is two-byte. If not needed, the codepoints simply stay part of the list of CharacterRanges. In EmitCharClass, we determine the valid subset of ranges through ranges_length; until this CL, we forgot to pass that information on to MakeRangeArray. Do that now by truncating the list of CharacterRanges. Fixed: chromium:1262423 Change-Id: I5bb5b839e9935890ca2d10908ad66d72c3217178 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3240782 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/ad1e3fb..acad0f2 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I9a41a3b68d828e01cfe2d8e9e06b26974965ad55 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3239926Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#77513}
-
Liu Yu authored
Port commit 1cd7a582 Change-Id: Iec6b60caeb55fd240407acc99872ebf0558654bf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3239087Reviewed-by:
Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Auto-Submit: Liu yu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/main@{#77512}
-
Lu Yahan authored
Change-Id: Id6d8f1224cb59fb55decbd6fef1c8e674ea6de63 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3237328Reviewed-by:
ji qiu <qiuji@iscas.ac.cn> Commit-Queue: ji qiu <qiuji@iscas.ac.cn> Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#77511}
-
- 24 Oct, 2021 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/263ec78..ad1e3fb Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/fa8d4c8..21acd3f Rolling v8/third_party/aemu-linux-x64: KDNRxWTmjlQIxZYPFEwIygxfih4aexkTD2JwU6hED-8C..8buMrGFlldiiEGiS-u8rclQGhORwxrcN14vZGo5U8sgC TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I0a097f57932644ddde82209d64ecb5c1dd92f415 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3239523Reviewed-by:
-
- 23 Oct, 2021 2 commits
-
-
Liviu Rau authored
Narrow down the list of owners to choose from in the gcmole auto-update CLs. Bug: v8:11169 Change-Id: I9f553124c43dc9fc094a8f4a6e2bcc832fe27636 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3236993 Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/4d4596d..263ec78 Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/be63497..9b8228b Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/6f77fbf..fa8d4c8 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I01ebcedc4000923f7e433e0a8dc87d1f042f6f08 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3237759Reviewed-by:
-
- 22 Oct, 2021 2 commits
-
-
Zhao Jiazhong authored
Some variables are only used in DCHECKs, which leading to the `unused-but-set-variable` check fail in release mode. So we need to explicitly mark them as used. Change-Id: I18dc8ec97ea5fbbaa081a52629b9572b863d901e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3237558Reviewed-by:
Liu yu <liuyu@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/main@{#77507}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/ee9068d..4d4596d Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/4c834ab..be63497 Rolling v8/third_party/aemu-linux-x64: CtkoubyWN1QNNB68v2CsV0fsa-ikErKqmbujQdM_iGMC..KDNRxWTmjlQIxZYPFEwIygxfih4aexkTD2JwU6hED-8C Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/2d03634..e9a87dc Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/ed33756..7a6ff98 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/2b09788..e193c0a TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I913db72cd3a1b0b7351a95d33829f85bb643268e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3237409Reviewed-by:
-
- 21 Oct, 2021 17 commits
-
-
Frank Tang authored
Bug: v8:12301 Change-Id: Ia87943478c1b67c077a18785668c485c404cd5dd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3235814Reviewed-by:
-
Ng Zhi An authored
Extract instructions, and pextrq. Bug: v8:12207 Change-Id: I919ce53a6bb1357cb70d78b3c7f12fc3d2128deb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3223969 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/main@{#77504}
-
Frank Tang authored
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/8d420cef4..1ad9bb7626a Bug: v8:7834 Change-Id: Icc082f9834aabd39f0d21f85d6ff9ed8ad1d0137 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3235813Reviewed-by:
-
Michael Lippautz authored
https://github.com/google/benchmark/pull/1256 has been upstreamed. Manually roll forward and immediately remove the build-time work around. Change-Id: I567dc0bdfda128656c874b6555dc6a89eeaa8100 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3236991 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77502}
-
Michael Lippautz authored
Bug: chromium:1260621 Change-Id: Iddfd5ee70ce9479209ff81f41197805e738298e0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3236990Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77501}
-
Clemens Backes authored
This flag will force the usage of the mid-tier register allocator, which is otherwise only used for huge functions, hence does not get much fuzzer coverage. R=machenbach@chromium.org Bug: v8:12330 Change-Id: I30b602b54adf858a2a3aaf73d8828875c1f6df7a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3234492Reviewed-by:
-
Milad Fa authored
Change-Id: Ia4151fe23a8217f3f62d895fb74f96f934ab9618 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3236766Reviewed-by:
-
Joyee Cheung authored
To get more details about the failure when it flakes. Bug: v8:12332 Change-Id: I1bf5188efe13a75e34dd9832e6275fd985ee8dbd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3233974 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by:
-
JianxiaoLuIntel authored
Bug: v8:12333 Change-Id: Ic29a9d67b586629148075dccbcebcf6f49398fb8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3235684 Auto-Submit: Jianxiao Lu <jianxiao.lu@intel.com> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#77497}
-
Camillo Bruni authored
Drive-by-fix: format file Change-Id: I4915ef1e917a22a8be464f75c136b4c97e045379 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3234493Reviewed-by:
-
Clemens Backes authored
If an output operand has "same as input" policy, we cannot assume that it's input 0. Instead we should look at the {input_index}. The bug manifests on Wasm select instructions, where the input index is actually 2 and not 0. In order to test this better, we introduce the a new --turbo-force-mid-tier-regalloc flag, which always uses the mid-tier register allocator. Otherwise the bug would only manifest on huge functions. R=mslekova@chromium.org CC=thibaudm@chromium.org Bug: v8:12330 Change-Id: I6a005a48bbd2aba354dc99fed587bffce24c8839 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3234722Reviewed-by: -
Patrick Thier authored
Comments in interface-descriptors stated that the argument count is without the receiver, which is no longer true (see [1]). [1] https://crrev.com/c/3140608 Bug: v8:11112 Change-Id: I75277bd4044a49a5a668f602501ad229bc44720b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3234491 Commit-Queue: Patrick Thier <pthier@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Auto-Submit: Patrick Thier <pthier@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#77494}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/110f470..ee9068d Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/9eb0245..4c834ab Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/557b51a..6f77fbf Rolling v8/third_party/aemu-linux-x64: oT0j0p3wnLGyIs4qDcea3sRhW4YKoAhTY2LDWkJ4T4QC..CtkoubyWN1QNNB68v2CsV0fsa-ikErKqmbujQdM_iGMC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/876bab7..2d03634 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/756e98f..ed33756 Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/075810f..16f637f Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/c00aa10..2b09788 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I779a9da6804d29e4f7a05d646d1f8a6cbff3de8f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3233925Reviewed-by:
-
Patrick Thier authored
Calling class constructors without new is a spec violation and should raise an exception. In [1] calling class constructors with spread (without new) was handled by reducing the node to a call to runtime to raise the exception. However, arguments of the call have to be evaluated first ([2]). This CL changes the reduction of JSCallWithSpread/JSCallWithArrayLike to a no-op in JSCallReducer if the target is a class constructor, delaying raising of the exception to the call builtin. [1] https://crrev.com/c/3229369 [2] https://tc39.es/ecma262/#sec-evaluatecall Bug: chromium:1262007 Change-Id: I2ef504d4ce6e51d582b5951beb6debb983cefba6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3236348 Commit-Queue: Patrick Thier <pthier@chromium.org> Reviewed-by:
-
Victor Porof authored
This CL exposes the async stack traces instrumentation on the console object, behind a --experimental-async-stack-tagging-api flag. It serves as a prototype that aims to validate whether the debugging experience can be improved for userland code that uses custom schedulers. The tests are implemented as Blink web tests in the following CL: https://chromium-review.googlesource.com/c/chromium/src/+/3226418 Bug: chromium:332624 Change-Id: Ib1ee71de68f7bb9aff5b944812ce681d8711d217 Signed-off-by:
Victor Porof <victorporof@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3212506Reviewed-by:
Simon Zünd <szuend@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/main@{#77491}
-
Victor Gomes authored
We use a mutex to avoid data race when reading/writing to the code object registry. Functions called only by the sweeper happens during safepoints and do not need to be protected by the mutex. Bug: v8:12054 Change-Id: Ie85bf0422622eee7f2836ecae132397a6aa4ed59 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3234721 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Rolling this manually because we have to update paths in sync with instrumented_libraries due to https://crrev.com/c/3224627. Rolling v8/third_party/instrumented_libraries: https://chromium.googlesource.com/chromium/src/third_party/instrumented_libraries/+log/6527a4e..3c149f5 Bug: chromium:1261909 Change-Id: Ibcb6ebefa287e0125e0cb75be8dc51dea392a502 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3233138 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
