- 12 Mar, 2019 14 commits
-
-
Georg Neis authored
This function is not used (anymore) but needs to be defined, so put an UNREACHBLE inside. Bug: v8:7790 Change-Id: I5a8df2cbc236f60ee95ccc9d91c288d8d9c19060 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1515792Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#60188}
-
Jakob Gruber authored
... similar to how we do this in native irregexp code, i.e. handle interrupts on each backtrack. Unhandlified references into the code ByteArray and the subject String object are updated after a potential GC. Since interrupts may change the subject string's representation, the interpreter is now called in a loop to handle retries. Bug: v8:8724 Change-Id: Ic34de8d69ccc56d4656b8ed080c2c168c212ebfc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1511477 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#60187}
-
Clemens Hammacher authored
Extensions are now always passed via unique_ptr and are owned by V8. This CL removes the deprecated API where the embedder would own the Extension, but has no mechanism for deleting it. R=ulan@chromium.org Bug: v8:8725 Change-Id: Icb83660fad9d04c66f8db2265091ebabcbb197c4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1514493Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60186}
-
Clemens Hammacher authored
The counter is dead since August 2017 (https://crrev.com/c/633703). The corresponding chromium histogram is removed in https://crrev.com/c/1514812. R=titzer@chromium.org Bug: v8:8975 Change-Id: I6fa457018deb25cfd36d7de660fcfe996902c811 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1514737Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60185}
-
Clemens Hammacher authored
Embedders should use WasmModuleObject instead. R=adamk@chromium.org Change-Id: Ibe5e4b160bb917bcd9f895be1b954acc40a045d8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1513616Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60184}
-
Frederik Gossen authored
Added a new compilation unit for Wasm interpreter in order to make it a first-class tier in the future. Adapted Wasm interpreter usage to work with the new interface. The new compilation unit is currently not used. Change-Id: Ib9e1d0dc6ca1b03467cc43059f03ce153bb96400 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1514734 Commit-Queue: Frederik Gossen <frgossen@google.com> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#60183}
-
Maciej Goszczycki authored
Seal read-only space before startup deserialization. This is necessary for fully isolating read-only space creation. Strings within read-only space are now eagerly rehashed. Bug: v8:7464 Change-Id: I8b91a6f6b31e03e69d80109b1ca30c675a495c36 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1511485Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Maciej Goszczycki <goszczycki@google.com> Cr-Commit-Position: refs/heads/master@{#60182}
-
Andreas Haas authored
According to the wasm js-spec, the table index can be uint32. The implementation in our implementation expected an int though. We did not check for the int overflow. I replaced the throwing of the exception in WasmTableObject::Get to use the ErrorThrower instead of throwing the exception with Isolate::Throw directly. The reason is that I see with other CL's that I have to throw several errors, and I don't want to introduce a new message and MessageId for every error. Moreover, the ErrorThrower is a standard way in wasm to throw errors. It feels right to throw the error the same way here. R=mstarzinger@chromium.org Bug: chromium:940296 Change-Id: Idb77c813506fe66a3192b66fe0e8e807b80580ab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1514496 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/61c98e6..8dcfd3a Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/a9db5de..794f2d1 Rolling v8/buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/chromium/llvm-project/libcxx/+log/9ae8fb4..a50f503 Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/299e687..a60f152 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/b88eedc..eb73833 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/3485a26..77e5d48 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/60462ac..ff65c25 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ibf5a9282ae13c16fb49a3fb085e007c08cf53137 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1517364Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#60180}
-
Simon Zünd authored
Type declaration may contain a parent type in an "extends" clause. This CL changes the token type of the name after such a clause from std::string to Identifier*. The resulting SourcePosition is then used to implement the "goto-definition" link from that name to the definition of the parent type. R=mvstanton@chromium.org Bug: v8:8880 Change-Id: I9ea6cd83e4d6ef535906e36626f64d458c7d0270 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1511481Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#60179}
-
Tamer Tas authored
This is a reland of beaca8cf Original change's description: > [presubmit] use the correct path for third party libraries > > This CL ensures that presubmit script checks Torque files in third_party > dependencies. > > R=szuend@chromium.org > TBR=machenbach@chromium.org,sergiyb@chromium.org > CC=yangguo@chromium.org > > No-Try: true > Change-Id: I9e2b193defbebe7ae85cfc5d14ce50c2ac367e9b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1513674 > Reviewed-by: Tamer Tas <tmrts@chromium.org> > Reviewed-by: Simon Zünd <szuend@chromium.org> > Commit-Queue: Tamer Tas <tmrts@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60152} R=szuend@chromium.org TBR=machenbach@chromium.org,sergiyb@chromium.org CC=yangguo@chromium.org No-Try: true Change-Id: Id74408fbc69cd45bd48ec06c2e4da556d384d99c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1515753 Commit-Queue: Tamer Tas <tmrts@chromium.org> Reviewed-by:
Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#60178}
-
Hannes Payer authored
Bug: v8:8945 Change-Id: I14ca4b29f1b12ff95e718d431f65d88ab1238c53 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1511478Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#60177}
-
Simon Zünd authored
This CL adds two sets of benchmarks. The first measures the effort needed to walk the stack and create the data structure stored in Error.stack, while the second measures the serialization of that Error.stack data structure into a string. R=petermarshall@chromium.org, yangguo@chromium.org Bug: v8:8742 Change-Id: Ie7b86da5621cb186a036a3ec99692ec4d2048fba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505614 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
-
Irina Yatsenko authored
See: https://docs.microsoft.com/en-us/windows-hardware/drivers/debugger/windbg-scripting-preview The script can be loaded into WinDbg with: .scriptload full_path\windbg.js Help: !help Currently provided functionality: !jlh("local_handle_var_name") prints object held by the handle, e.g. !jlh("key") or !jlh("this->receiver_") !job(address_or_taggedint) prints object at the address, e.g. !job(0x235cb869f9) !jobs(start_address, count) prints 'count' objects from a continuous range of Object pointers, e.g. !jobs(0x5f7270, 42) !jst() or !jst prints javascript stack (output goes into the console) !jsbp() or !jsbp sets bp in v8::internal::Execution::Call (begin user's script) To run any function from this script (live or postmortem): dx @$scriptContents.function_name(args) e.g. dx @$scriptContents.pointer_size() or e.g. dx @$scriptContents.module_name('chrome_child') Change-Id: I958ff0544582c1ea0b12fd3349d460d28ac7ed56 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1506450 Commit-Queue: Irina Yatsenko <irinayat@microsoft.com> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#60175}
-
- 11 Mar, 2019 26 commits
-
-
Frank Tang authored
Bug: v8:7684 Change-Id: Id27d6c9d011c6093b89c11edca71fbc6e5d9a0fb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1514192 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Matt Gardner authored
Bug: chromium:937618 Change-Id: I360013d1e99e7e54f4bb942b1f8f4918f81d525d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1510333 Commit-Queue: Matt Gardner <magardn@microsoft.com> Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
Since kTaggedSize got shrinked and we are actually compressing the pointers (as oppposed to zeroing their upper bits), we need to update the arm64 codebase to accommodate this change. Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:7703 Change-Id: I890f3ab8c046f47232e80f85830f9ae8f4dbced4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1499498 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60172}
-
Michael Starzinger authored
R=mslekova@chromium.org BUG=v8:8813 Change-Id: I4d35fdff0f398c4eac3a97932a5e6ce43a49d9c8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1514683 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Maya Lekova authored
R=machenbach@chromium.org Bug: v8:8577 Change-Id: Ib8cda5d1a9826bf50ed84cb3521aa6fbcddde6fe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1394543Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#60170}
-
Jakob Gruber authored
When given a sticky regexp s.t. lastIndex > subject.length, the following should happen: 1. exec returns null (= no match) 2. lastIndex is reset to 0. This is usually done by the RegExp.p.exec builtin; but in some cases we take different paths and try to re-implement the parts of exec that we need. One of these cases was in %StringReplaceNonGlobalRegExpWithFunction. Here, we set lastIndex to 0 but then incorrectly called into RegExpImpl::Exec. REI::Exec started matching with lastIndex == 0, which is just plain wrong. With this CL we now correctly omit the REI::Exec call and return null. Bug: chromium:937681, v8:5361 Change-Id: I6bb1114a6b92ed3c6e63ec7f6ec2df4b95a19b4c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1514679Reviewed-by:
-
Clemens Hammacher authored
This removes three unneeded includes from wasm-code-manager.h, and adds four that were missing. R=ahaas@chromium.org Bug: v8:7490, v8:8834 Change-Id: I0f0f367c0ff748cc1561689b7e2badf3a7a01ca5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1513717Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60168}
-
Clemens Hammacher authored
In order to get a more complete picture about the code sizes of compiled wasm modules, sample the code size of each module after top-tier compilation finished. This happens via the {WasmEngine} because that's where we know which isolates use a given {NativeModule} and can schedule foreground tasks to sample the code size. R=mstarzinger@chromium.org Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel Bug: v8:8217 Change-Id: Id585db8a9ab8f3aa1060b08411afaa31c5414f87 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1508404 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Clemens Hammacher authored
The counter is dead since January 2018 (https://crrev.com/c/860011). This CL reenables it. R=titzer@chromium.org Bug: v8:8975 Change-Id: I0245edd40bb972a89e223685f56ab02fbdf68aa0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1514677Reviewed-by:
-
Clemens Hammacher authored
We currently see >20% of modules overflow on this counter, i.e. having more than 100k functions. Thus increase the histogram size to 1M, which is the maximum number of functions supported in v8. R=titzer@chromium.org Bug: v8:8975 Change-Id: Ie709ec37cdea90b78637da63b48aea0f4775cee5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1514736Reviewed-by:
-
Clemens Hammacher authored
Currently the total allocated address space is collected twice per Wasm memory: Once on allocation, once on release. Recording it once provides the same data. R=titzer@chromium.org Bug: v8:8975 Change-Id: I99719ecb44b14ce5da1be4a74291377f91f4038a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1514738Reviewed-by:
-
Clemens Hammacher authored
The WasmCompileLazy runtime function used to return the start of the instructions of the newly compiled function. With garbage collection of wasm code, it would be tricky to keep this wasm code object alive until it is being called. Thus make the runtime function not return anything, and call via the jump table instead. The jump table was patched as part of lazy compilation to point to the compiled code. Drive-by: Merge {LazyCompileFunction} into single caller {CompileLazy}. R=mstarzinger@chromium.org Bug: v8:8217 Change-Id: Id3c02f4dfe2c536e335af2e7e1b9700203d48675 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1509472 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Simon Zünd authored
This CL changes the FieldAccessExpression to include a SourcePosition for the field, allowing a jump from such an access to the definition of a field inside a class or struct. Drive-by: Change the source position of a field from the position of its type to the position of its name. This will coincidentally improve the accuracy of error messages. R=danno@chromium.org Bug: v8:8880 Change-Id: I7996e8a57a2ff90e8bdca6f40c1b298d48071e23 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1512573Reviewed-by:
Daniel Clifford <danno@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#60162}
-
Jakob Gruber authored
It will soon be possible to throw arbitrary exceptions from within interpreter execution (namely, in interrupts). We can thus no longer assume that an EXCEPTION return code means we need to throw a stack overflow exception. Bug: v8:8724 Change-Id: I10e24aba4305dc7b39248ced9a52735c59ab662c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1511474 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Georg Neis authored
R=jarin@chromium.org Bug: chromium:940423 Change-Id: I9e357d8fe424b291bc25a1d389696df88deda6a3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1514735Reviewed-by:
-
Milad Farazmand authored
Fixing ThreadId according to the following changes: 656254b1 Change-Id: I1e1943ac7e3ed03799c213e566816bfe5c21967d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1512718Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#60159}
-
Clemens Hammacher authored
Our UMA data shows a lot of small modules, and I have the suspicion we are loosing some numbers about the bigger ones. Thus sample the module code size after baseline compilation finished. At that point the majority of the code was generated. Sampling after top-tier finished is not that easy since we do not spawn a foreground task at that point. R=mstarzinger@chromium.org Bug: v8:8217 Change-Id: Icaa4a2efb201d24cbc8d2e1b8da516ae26574f01 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1508675 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Maya Lekova authored
Bug: v8:7790 R=neis@chromium.org Change-Id: I10085cff40e14ea63074e29649af55fa2c0ea462 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1514494 Commit-Queue: Maya Lekova <mslekova@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Georg Neis authored
It wasn't always guaranteed that they were serialized before taking the dependency. Bug: chromium:940361 Change-Id: Id5e5e14532809e7496546c2011176e33848506ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1514495Reviewed-by:
-
Simon Zünd authored
R=tmrts@chromium.org Change-Id: I652a142c815c7268700de3b743f09495748ec399 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1514634Reviewed-by:
-
Jakob Gruber authored
Similar to NativeRegExpMacroAssembler::Result, the regexp interpreter will need a RETRY return code in case the subject string representation changes during an interrupt. This CL adds a new IrregexpInterpreter::Result type to decouple from RegExpImpl::Result. Bug: v8:8724 Change-Id: I946fc0cbc4d7d8631312b72f13a45abeb9986905 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1511472Reviewed-by:
-
Maya Lekova authored
This reverts commit beaca8cf. Reason for revert: Broke presubmit bot - https://ci.chromium.org/p/v8/builders/ci/V8%20Presubmit/2938 Note that the problem is not with this CL itself, but it uncovers some presubmit issue in Torque code. Until the latter is fixed, I'm reverting to unblock the tree. Original change's description: > [presubmit] use the correct path for third party libraries > > This CL ensures that presubmit script checks Torque files in third_party > dependencies. > > R=szuend@chromium.org > TBR=machenbach@chromium.org,sergiyb@chromium.org > CC=yangguo@chromium.org > > No-Try: true > Change-Id: I9e2b193defbebe7ae85cfc5d14ce50c2ac367e9b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1513674 > Reviewed-by: Tamer Tas <tmrts@chromium.org> > Reviewed-by: Simon Zünd <szuend@chromium.org> > Commit-Queue: Tamer Tas <tmrts@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60152} TBR=tmrts@chromium.org,szuend@chromium.org Change-Id: If8e2db0801f51ef737243ccfcc909d05fb42e3e6 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1514633Reviewed-by:
-
Tamer Tas authored
This CL ensures that presubmit script checks Torque files in third_party dependencies. R=szuend@chromium.org TBR=machenbach@chromium.org,sergiyb@chromium.org CC=yangguo@chromium.org No-Try: true Change-Id: I9e2b193defbebe7ae85cfc5d14ce50c2ac367e9b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1513674Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#60152}
-
Simon Zünd authored
With the recent changes to Array#sort, the main algorithm does not need to bail out anymore. Only the initial copying into the workarray, as well as the final copying back into the original backing store might cause a switch from fast-path to the slow-path. This CL changes the slow-path so sorting itself is not restarted and the slow-path will continue copying where the fast-path left off. R=jgruber@chromium.org Bug: v8:7382 Change-Id: I4ab61daa62bb816f4f6e16e60bde1f948ad1e7db Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1507717 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
-
Simon Zünd authored
With the recent changes to Array#sort, some bailout labels and accessor checks became superfluous. This CL removes them along with some other minor cleanup work. R=jgruber@chromium.org Bug: v8:8834 Change-Id: I7429482ceaccbe743e2b8190d83bfa2c34875b11 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1507678Reviewed-by:
-
Andreas Haas authored
The table_object instance field is not needed anymore because its purpose is fulfilled now by the tables field I introduced to support multiple tables. In addition I removed {table_instances_} from the {InstanceBuilder}. This field existed because tables could exist without a WasmTableObject. With recent changes, WasmTableObjects always exist. R=mstarzinger@chromium.org Bug: v8:7581 Change-Id: I5e8e3d2910f7ed7ae74d61eff660f9451b3493ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1466641 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
