• Andreas Haas's avatar
    [wasm] Fix insufficient bounds check in WebAssembly.get · e162eb44
    Andreas Haas authored
    According to the wasm js-spec, the table index can be uint32. The
    implementation in our implementation expected an int though. We did not
    check for the int overflow.
    
    I replaced the throwing of the exception in WasmTableObject::Get to use
    the ErrorThrower instead of throwing the exception with Isolate::Throw
    directly. The reason is that I see with other CL's that I have to throw
    several errors, and I don't want to introduce a new message and
    MessageId for every error. Moreover, the ErrorThrower is a standard way
    in wasm to throw errors. It feels right to throw the error the same way
    here.
    
    R=mstarzinger@chromium.org
    
    Bug: chromium:940296
    Change-Id: Idb77c813506fe66a3192b66fe0e8e807b80580ab
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1514496
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#60181}
    e162eb44
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...