- 20 Apr, 2022 1 commit
-
-
Camillo Bruni authored
- Use explicit options when running gmcole.py from run-gcmole.py - Use gcmole.py-relative paths to find the default V8 root dir for maximum convenience when running locally Change-Id: Iba0da90b99b0321129f1c4099f437c76dabb1186 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3582386Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Auto-Submit: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#80058}
-
- 04 Apr, 2022 1 commit
-
-
Alexander Schulze authored
Bug: v8:12581 Change-Id: I6c665161a3f376321feb773d809c5453ef1d46f9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3568445Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Alexander Schulze <alexschulze@chromium.org> Cr-Commit-Position: refs/heads/main@{#79735}
-
- 21 Mar, 2022 1 commit
-
-
Camillo Bruni authored
Bug: v8:10009 Change-Id: I1f71b2783cd07331a65f46c316e87a46396e7eda Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3516153Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#79541}
-
- 09 Mar, 2022 1 commit
-
-
v8-ci-autoroll-builder authored
R=clemensb@chromium.org Change-Id: I1d3513a75c32a505cb5cdb1a123f2d586f55ee02 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3513416Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#79430}
-
- 04 Mar, 2022 1 commit
-
-
Camillo Bruni authored
Prepare gcmole.cc for the next update: - Print possible GC locations when discovering stale/dead variables - Make error messages less confusing for the modern V8 engineer - Prepare gcmole to read suspects.allowlist instead of .whitelist - Use more readable variable names - Only log non-found types with --verbose - Change the currently unusued gccauses format in gcmole.py and support loading it back in gcmole.cc - Implemented first basic gc call-chain printing (disabled by default) GCmole packaging: - Add debug mode to bootstrap.sh build script - Update gcmole.py run instructions in bootstrap.sh and package.sh Bug: v8:10009 Change-Id: I369d48baa2980455d2e8f57e7a803d0384fe83f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3480095Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#79357}
-
- 03 Mar, 2022 1 commit
-
-
Camillo Bruni authored
- Convert gcmole to python3-ish code - use local Path implementation for future full migration - Use optparse and explicit arguments for gcmole - Add explicit directories flags - Use backwards compatible env vars as fallbacks - Add gn target v8_gcmole_files to avoid issues with missing or incompatible generated files Drive-by-fixes for running gcmole without ignored files: - Disable gcmole in Isolate::UnwindAndFindHandle - Partially disable gcmole in V8HeapExplorer::AddEntry Bug: v8:10009 Change-Id: I5b4d1c6554db300190226361b6c518419109ff3d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497320Reviewed-by: Liviu Rau <liviurau@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#79348}
-
- 24 Feb, 2022 1 commit
-
-
v8-ci-autoroll-builder authored
R=machenbach@chromium.org Change-Id: I9866742528d47210d39fcdeda522dcf29bdba38e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3486679Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#79249}
-
- 16 Feb, 2022 1 commit
-
-
Camillo Bruni authored
Don't print command line invocations by default. Change-Id: Ie67c883c92557a645fc8a681722f49a2c7c4bd17 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468901Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#79130}
-
- 28 Oct, 2021 1 commit
-
-
v8-ci-autoroll-builder authored
R=leszeks@chromium.org Change-Id: Iffe5593f3e6e5766f057ad872d16758527b252a8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3248211 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#77586}
-
- 26 Oct, 2021 2 commits
-
-
v8-ci-autoroll-builder authored
R=mslekova@chromium.org Change-Id: I47b9a286cc0f1b9dd64bf564423b4fb4af4a19ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3244954 Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#77545}
-
Leszek Swirski authored
Tar and Gzip would include timestamps for files in the gcmole package, which meant that they weren't deterministic across multiple builds. Now we strip out the timestamps (as well as owner/group information) to make the packaging more deterministic. Change-Id: Iec3195ede4150c1603927fec748455329a8da677 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3245112Reviewed-by: Liviu Rau <liviurau@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#77539}
-
- 25 Oct, 2021 1 commit
-
-
v8-ci-autoroll-builder authored
R=clemensb@chromium.org Change-Id: Ia804d29a61e9d716b5ee5acebce7cb9c273697d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3241363 Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#77522}
-
- 23 Oct, 2021 1 commit
-
-
Liviu Rau authored
Narrow down the list of owners to choose from in the gcmole auto-update CLs. Bug: v8:11169 Change-Id: I9f553124c43dc9fc094a8f4a6e2bcc832fe27636 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3236993 Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#77509}
-
- 21 Sep, 2021 1 commit
-
-
Michael Lippautz authored
This reverts commit f2e25f8a. Reason for revert: Breaks GCC 8.4.0 compilation, see bug. Original change's description: > [base] Replace base::Optional with Abseil > > Change base::Optional to an alias of absl::optional. Eventually we > should remove it entirely. > > Bug: v8:11006 > Change-Id: I687d44cc7e7cd0a49a84bcc207231eb6808eef2d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2476318 > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/main@{#76913} Bug: v8:11006, v8:12252 Change-Id: I8048dee676a36551d15f25a31d1e171dae00d975 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3173672 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#76976}
-
- 17 Sep, 2021 1 commit
-
-
Leszek Swirski authored
Change base::Optional to an alias of absl::optional. Eventually we should remove it entirely. Bug: v8:11006 Change-Id: I687d44cc7e7cd0a49a84bcc207231eb6808eef2d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2476318 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#76913}
-
- 05 Jul, 2021 1 commit
-
-
Liviu Rau authored
Bug: v8:11169 Change-Id: I32e9bb1f91c9583e900c96e158d66407d5560868 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3003466Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/master@{#75555}
-
- 02 Mar, 2021 1 commit
-
-
Clemens Backes authored
This removes all wasm includes from src/debug and src/inspector if webassembly is disabled (v8_enable_webassembly=false). It also removes the definition of {WasmValueObject} and {v8::debug::WasmScript}. This will allow to later fully exclude the src/wasm directory from compilation (once other components are fixed). R=bmeurer@chromium.org, machenbach@chromium.org Bug: v8:11238 Change-Id: I41a1d83d01fbb6c015cdfd6cc063bad90052505d Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2726506Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#73138}
-
- 01 Mar, 2021 1 commit
-
-
Dominik Inführ authored
To improve performance of parking, keep the thread state in an atomic variable instead of protecting it with a mutex. However the mutex was used e.g. to force Unpark() to block while the safepoint operation was still running. Therefore the safepoint algorithm has to change as well. Park() and Unpark() use CAS operation to transition the state. Safepoint() uses a relaxed load for checking whether a safepoint was requested. Since Safepoint(), Park() and Unpark() all have a slow path, there is no need for busy-waiting on the main thread. We need two more ThreadStates: * SafepointRequested: This state is set by GlobalSafepoint to force Running threads into the slow path on Safepoint() and Park(). This state also replaces the separate atomic<bool> safepoint_requested_ field we used before. * ParkedSafepoint: This state is set by GlobalSafepoint as well to force parked threads into the slow path on Unpark(). When stopping all threads, GlobalSafepoint transitions states from Running --> SafepointRequested and Parked --> ParkedSafepoint to force the slow path for all three methods. After performing the transition for each thread we know the exact number of Running threads and wait until each of them either reached a safepoint or parked itself. Design doc: https://docs.google.com/document/d/1p9klWyqT_AScAnK_PdHZTcNhZGzoBiYWPkUciIh2C58/edit?usp=sharing Bug: chromium:1177144, v8:10315 Change-Id: I8697da915c7d18e2fb941f1bedf6181226408feb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2704075Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#73089}
-
- 03 Feb, 2021 1 commit
-
-
Leszek Swirski authored
Fix some trailing whitespace issues in files in the tools directory. Change-Id: If9e9b1dab1d6f521e20619a2a1d093749f0528d9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2671660 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#72498}
-
- 12 Jan, 2021 1 commit
-
-
Camillo Bruni authored
Make sure gcmole detects issue in DisallowGarbageCollection scopes. DisallowGarbageCollection is widely used in the codebase to document code that doesn't allocate. However, this has the rather unexpected side-effect that gcmole is not run when such a scope is active. This CL changes the default behavior of gcmole to run even with DisallowGarbageCollection scopes present. This will give us the best results of both worlds, dynamic checks by the fuzzer, and static analysis by gcmole. To allow crazy local raw pointer operations there is a new DisableGCMole scope that explicitly disables gcmole. Change-Id: I0a78fb3b4ceaad35be9bcf7293d917a41f90c91f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2615419Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#72039}
-
- 04 Dec, 2020 1 commit
-
-
Leszek Swirski authored
Improve the performance of gcmole by * Precompiling the regexes in GCSuspectsCollector.Resolve * Merging those regexes into a single regex, using '|' * Changing multiprocess clang plugin invocation to threaded (running the plugin releases the GIL so this can efficiently thread). This uses a simple worker pool with a single work queue. * Change clang plugin invocation loop to yield after each invocation. This pipelines the dump-callees plugin and GCSuspectsCollector Parse/Resolve, so that the parse can happen while waiting for other callee dumps to finish. Change-Id: Ib9fca70dbcfd2f9d1aebc8bd11aa1d1f7d34e24a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2562242Reviewed-by: Maya Lekova <mslekova@chromium.org> Reviewed-by: Liviu Rau <liviurau@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#71617}
-
- 26 Nov, 2020 1 commit
-
-
Leszek Swirski authored
Fix the python call to sys.executable, and sort imports Change-Id: I948291e0835c79445108f215e55885fdb2c01052 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2560592 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#71423}
-
- 20 Nov, 2020 1 commit
-
-
Leszek Swirski authored
Because of LocalHeap safepoints, our existing assert scopes don't necessarily maintain the same guarantees as desired. In particular, DisallowHeapAllocation no longer guarantees that objects don't move. This patch transitions DisallowHeapAllocation to DisallowGarbageCollection, to ensure that code using this scope is also protected against safepoints. Change-Id: I0411425884f6849982611205fb17bb072881c722 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2540547 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#71319}
-
- 18 Nov, 2020 1 commit
-
-
Leszek Swirski authored
This removes the dependency on Lua for running gcmole, and Python's expressiveness lets us clean up the code a bit, including getting rid of global variables, embedding the multiprocessing (removing the need for a separate `parallel.py`), and using difflib for printing the test expectation diff. Bug: v8:11169, v8:8590, chromium:1097212 Change-Id: If0ab5ea6f764864855d73cd0ba63cb37c1823955 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2543927 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Liviu Rau <liviurau@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#71253}
-
- 17 Nov, 2020 1 commit
-
-
Leszek Swirski authored
Add a "combination" assert scope class, which combines multiple existing assert scopes. This will allow scopes with functional overlap, e.g. DisallowGarbageCollection and DisallowHeapAllocation, to share an assert type rather than rather than requiring users to remember to set both. To demonstrate this, this redefines DisallowGarbageCollection to a combination of DisallowHeapAllocation and a new DisallowSafepoints, and some of the DCHECKs checking both are simplified to only check one or the other, as appropriate. The combination classes become subclasses of the existing assert scopes, so that they can be used in their place as e.g. a function parameter, e.g. DisallowGarbageCollection can be passed to a function expecting const DisallowHeapAllocation&. As a drive-by, this also changes the per-thread assert scopes to use a bitmask, rather than a bool array, to store their per-thread data. The per-isolate scopes already used a bitmask, so this unifies the behaviour between the two. Change-Id: I209e0a56f45e124c0ccadbd9fb77f39e070612fe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2534814 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#71231}
-
- 16 Nov, 2020 1 commit
-
-
Leszek Swirski authored
This resolves issues building gcmole under LLVM 8.0.0 with gcc 10 (see https://bugs.gentoo.org/708730). Change-Id: I932def25fb3cc841cf21414a513fbe2a2fa8a8dc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2539946Reviewed-by: Tamer Tas <tmrts@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#71204}
-
- 27 Oct, 2020 2 commits
-
-
Jakob Gruber authored
This reverts commit 3c49308a. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Clusterfuzz%20Mac64%20ASAN%20-%20debug%20builder/18360 Original change's description: > [DEPS] Add abseil to deps > > Add a dependency on the chromium abseil-cpp subdir mirror. > > Bug: v8:11006 > Change-Id: Icaad757269d27c65bc368ed539f84c5bb79ee62d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2464940 > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Victor Gomes <victorgomes@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70786} TBR=rmcilroy@chromium.org,adamk@chromium.org,yangguo@chromium.org,hpayer@chromium.org,leszeks@chromium.org,victorgomes@chromium.org Change-Id: Iff2ac3b0da8725ec2df69aa527e5a4255ca3009c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:11006 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2501843Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#70787}
-
Leszek Swirski authored
Add a dependency on the chromium abseil-cpp subdir mirror. Bug: v8:11006 Change-Id: Icaad757269d27c65bc368ed539f84c5bb79ee62d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2464940 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#70786}
-
- 26 Oct, 2020 1 commit
-
-
Maya Lekova authored
GCMole mistakenly thought that GC guards such as DisallowHeapAllocation covered the whole scope of the function they are declared in. This CL fixes the false negatives and adds appropriate testing. Bug: v8:10071 Change-Id: Iffb369977af90ca053a55ca8f451e037a4f460f2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2497451 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#70763}
-
- 04 Oct, 2020 1 commit
-
-
Michael Achenbach authored
The build location is now universally in out/build after infra change: https://crrev.com/c/2426643 TBR=mslekova@chromium.org Bug: chromium:1132088 Change-Id: I0d8867ed58adec79ed66f5e4dac375827e2679e3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2448451Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#70296}
-
- 25 Sep, 2020 1 commit
-
-
Tobias Tebbi authored
This is a reland of 64caf2b0 Original change's description: > [torque] refactor: use -tq only in filenames derived from .tq files > > This is to establish a naming rule for Torque-generated files: > - If the file is called foo/bar-tq..., then it is derived from a > file foo/bar.tq > - Otherwise it doesn't belong to a specific .tq file. > > So far, we attached -tq to all Torque-generated file names, where it > sometimes corresponded to a .tq file name and sometimes not. > It is not necessary to add -tq to file names to indicate that they are > Torque-generated, since they are already in a directory called > torque-generated, and we always refer to them as > "torque-generated/filename", so there is no confusion even though some > files now have the same name as a corresponding hand-written file, for > example factory.cc. > > TBR: hpayer@chromium.org > Bug: v8:7793 > Change-Id: Ie172babad1fc7422fd1059c48f5dafaa53e50c8b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2414218 > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70060} Bug: v8:7793 TBR: hpayer@chromium.org jgruber@chromium.org Change-Id: I6c492bc64aee1ff167e7ef401825eca9097a7f38 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2431565 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#70137}
-
- 15 Sep, 2020 1 commit
-
-
Maya Lekova authored
This is an attempt to fix a gcmole failure in https://chromium-review.googlesource.com/c/v8/v8/+/2362960 Change-Id: Idff72ff3ae63863fb73f11231481469c700891c3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2410193Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#69907}
-
- 14 Sep, 2020 1 commit
-
-
Dominik Inführ authored
Add support for DisallowGarbageCollection scope. This scope will be introduced once this CL landed. DisallowGarbageCollection works like DisallowHeapAllocation but also disallows safepoints. Bug: v8:10315 Change-Id: Ia7d777d4104b32810dd481ad9dbdf0edd075b6cf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2395561 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#69881}
-
- 24 Jun, 2020 1 commit
-
-
Maya Lekova authored
GCMole now comes with the long forgotten use-after-free detection enabled by default. The CL also improves error logging when test expectations mismatch with the actual output and updates the hash of GCMole to be used with the newly built version with enabled UAF detection. The CL also contains an ignore for isolate.cc due to inability to fix a warning there and fixes a couple of UAF warnings. Bug: v8:9680 Change-Id: I7a009ffd5f67b1b5437567691ca4235ea873de70 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2257236 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#68505}
-
- 22 Jun, 2020 1 commit
-
-
Maya Lekova authored
Bug: v8:9993 Change-Id: I06428edd7f01805d08927718e4711298c731d2e3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2253844 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#68450}
-
- 19 Jun, 2020 1 commit
-
-
Maya Lekova authored
Bug: v8:10009 Change-Id: Iccc42a9b5f9f7340851542185473ac49683c838c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2253843Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#68430}
-
- 18 May, 2020 1 commit
-
-
Maya Lekova authored
Enhance gcmole --verbose printing with the GC suspect. Bug: v8:9986 Change-Id: Ia1454d4edec334eabb31a764583e4ee559f0fe07 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207174Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#67867}
-
- 13 May, 2020 1 commit
-
-
Marja Hölttä authored
We can't attach a meaningful stack trace to the AggregateError Promise.any rejects with, but we can augment the individual errors' stack traces with Promise.any and the index of the corresponding Promise in the input. Bug: v8:9808 Change-Id: I7ba754c9b043594decaac8b3a23be74f05c3dffd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2198983 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#67778}
-
- 08 Jan, 2020 1 commit
-
-
Leszek Swirski authored
Most dead variable warnings in GCMole are false positives, either from failing to detect that TryEvacuateObject returning false means it didn't allocate, or a regex error thinking that GarbageCollectionReasonToString causes garbage collection (because the mangled version is something like GarbageCollectionReasonToString[...]GarbageCollectionReason, and that matches /Collect.*Garbage/). Update the whitelist and fix the "Collect.*Garbage" regex to only look at the function name. Bug: v8:9985 Change-Id: I62284e97e4975a6a87616d1d535b2ac7958d17bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1989829 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#65622}
-
- 13 Dec, 2019 1 commit
-
-
Michael Starzinger authored
R=clemensb@chromium.org Change-Id: Ibd6790a222590fd4dce9f918219a19f01c2e1e0f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1960293Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#65439}
-