Commit c20ff735 authored by Jakob Gruber's avatar Jakob Gruber Committed by Commit Bot

Revert "[DEPS] Add abseil to deps"

This reverts commit 3c49308a.

Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Clusterfuzz%20Mac64%20ASAN%20-%20debug%20builder/18360

Original change's description:
> [DEPS] Add abseil to deps
>
> Add a dependency on the chromium abseil-cpp subdir mirror.
>
> Bug: v8:11006
> Change-Id: Icaad757269d27c65bc368ed539f84c5bb79ee62d
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2464940
> Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Reviewed-by: Victor Gomes <victorgomes@chromium.org>
> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#70786}

TBR=rmcilroy@chromium.org,adamk@chromium.org,yangguo@chromium.org,hpayer@chromium.org,leszeks@chromium.org,victorgomes@chromium.org

Change-Id: Iff2ac3b0da8725ec2df69aa527e5a4255ca3009c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:11006
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2501843Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70787}
parent 3c49308a
......@@ -1433,15 +1433,6 @@ group("v8_maybe_icu") {
}
}
group("v8_abseil") {
public_deps = [ "//third_party/abseil-cpp:absl" ]
public_configs = [
"//third_party/abseil-cpp:absl_define_config",
"//third_party/abseil-cpp:absl_include_config",
]
}
v8_source_set("torque_generated_initializers") {
visibility = [ ":*" ] # Only targets in this file can depend on this.
......@@ -1451,10 +1442,7 @@ v8_source_set("torque_generated_initializers") {
":v8_tracing",
]
public_deps = [
":v8_abseil",
":v8_maybe_icu",
]
public_deps = [ ":v8_maybe_icu" ]
sources = [
"$target_gen_dir/torque-generated/csa-types.h",
......@@ -1483,10 +1471,7 @@ v8_source_set("torque_generated_definitions") {
":v8_tracing",
]
public_deps = [
":v8_abseil",
":v8_maybe_icu",
]
public_deps = [ ":v8_maybe_icu" ]
sources = [
"$target_gen_dir/torque-generated/class-definitions.cc",
......@@ -1773,10 +1758,7 @@ v8_source_set("v8_snapshot") {
# Also top-level visibility targets can depend on this.
visibility += [ "//:gn_visibility" ]
public_deps += [
":v8_abseil",
":v8_maybe_icu",
]
public_deps += [ ":v8_maybe_icu" ]
sources += [ "$target_gen_dir/snapshot.cc" ]
}
......@@ -1934,10 +1916,7 @@ v8_source_set("v8_init") {
"src/init/setup-isolate-full.cc",
]
public_deps = [
":v8_abseil",
":v8_maybe_icu",
]
public_deps = [ ":v8_maybe_icu" ]
configs = [ ":internal_config" ]
}
......@@ -2239,7 +2218,6 @@ v8_source_set("v8_compiler_opt") {
public_deps = [
":generate_bytecode_builtins_list",
":run_torque",
":v8_abseil",
":v8_maybe_icu",
":v8_tracing",
]
......@@ -2265,7 +2243,6 @@ v8_source_set("v8_compiler") {
public_deps = [
":generate_bytecode_builtins_list",
":run_torque",
":v8_abseil",
":v8_maybe_icu",
":v8_tracing",
]
......@@ -3813,7 +3790,6 @@ v8_source_set("v8_base_without_compiler") {
public_deps = [
":generate_bytecode_builtins_list",
":run_torque",
":v8_abseil",
":v8_maybe_icu",
]
......@@ -5157,10 +5133,7 @@ v8_source_set("wasm_test_common") {
":v8_tracing",
]
public_deps = [
":v8_abseil",
":v8_maybe_icu",
]
public_deps = [ ":v8_maybe_icu" ]
configs = [
":external_config",
......@@ -5237,10 +5210,7 @@ v8_source_set("lib_wasm_fuzzer_common") {
":v8_tracing",
]
public_deps = [
":v8_abseil",
":v8_maybe_icu",
]
public_deps = [ ":v8_maybe_icu" ]
configs = [
":external_config",
......
......@@ -45,9 +45,6 @@ vars = {
'download_jsfunfuzz': False,
'check_v8_header_includes': False,
# This variable is overrided in Chromium's DEPS file.
'build_with_chromium': False,
'checkout_google_benchmark' : False,
'mac_xcode_version': 'default',
......@@ -309,15 +306,10 @@ deps = {
'url': Var('chromium_url') + '/external/github.com/kennethreitz/requests.git' + '@' + 'bfb93d4b7d269a8735f1b216093e7e9a9fdc4517',
'condition': 'checkout_android',
},
'third_party/abseil-cpp': {
'url': Var('chromium_url') + '/chromium/src/third_party/abseil-cpp.git' + '@' + '66b870c3b1cbbb7f85b31cc9a8a785329f5ebcb8',
'condition': 'not build_with_chromium',
}
}
include_rules = [
# Everybody can use some things.
'+absl',
'+include',
'+unicode',
'+third_party/fdlibm',
......
......@@ -93,7 +93,6 @@ v8_component("v8_debug_helper") {
":gen_heap_constants",
"../..:generate_bytecode_builtins_list",
"../..:run_torque",
"../..:v8_abseil",
"../..:v8_headers",
"../..:v8_libbase",
]
......
......@@ -116,7 +116,6 @@ local function MakeClangCommandLine(
.. " -I./"
.. " -Iinclude/"
.. " -Iout/build/gen"
.. " -Ithird_party/abseil-cpp"
.. " -Ithird_party/icu/source/common"
.. " -Ithird_party/icu/source/i18n"
.. " " .. arch_options
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment