- 28 Feb, 2017 38 commits
-
-
binji authored
This will be useful for sharing the implementation with SharedArrayBuffer.prototype.slice. BUG=v8:5897 Review-Url: https://codereview.chromium.org/2697013009 Cr-Commit-Position: refs/heads/master@{#43503}
-
kozyatinskiy authored
This method enables test of agent::restore methods. Bonus: forbid setCustomObjectFormatterEnabled on disabled agent. BUG=none R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2713023004 Cr-Commit-Position: refs/heads/master@{#43502}
-
Georg Neis authored
BUG= Change-Id: Id77205450d286be228b493deb69e1489a1e12895 Reviewed-on: https://chromium-review.googlesource.com/445906 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#43501}
-
Georg Neis authored
BUG=v8:6022 Change-Id: I54205cb3ecc2dd31ed62e55726f0ec5fcd202c30 Reviewed-on: https://chromium-review.googlesource.com/446349 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#43500}
-
Adam Klein authored
Previously, we over-approximated Scope::scope_calls_eval_ in arrow functions: if either the outer scope or the arrow function parameters had a direct eval call, we marked both scopes as calling eval. This over-approximation kept getting us into trouble, though, especially when eager or lazy parsing would disagree about the "calls eval" bit. This patch instead tracks eval calls accurately, using a boolean on Scope::Snapshot that is reset as appropriately depending on whether a particular AssignmentExpression turned out to be an arrow parameter list or not. BUG=chromium:691687 Change-Id: I527dc59b4d32a2797805ff26dc9f70b1311377b2 Reviewed-on: https://chromium-review.googlesource.com/446094 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#43499}
-
Georg Neis authored
This is more useful than always returning undefined. BUG=v8:1569,v8:5978 Change-Id: Id10cf87f7865db1a85de412460eaead4e4bf3b62 Reviewed-on: https://chromium-review.googlesource.com/446846Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#43498}
-
Georg Neis authored
The order in which things were done wasn't quite correct and lead to wrong behaviour for certain circular module graphs. BUG=v8:1569,chromium:694566 Change-Id: I291186e261268c853a30ad891ff362904e0b28ef Reviewed-on: https://chromium-review.googlesource.com/447399Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#43497}
-
yangguo authored
R=jgruber@chromium.org BUG=v8:5080 Review-Url: https://codereview.chromium.org/2725583002 Cr-Commit-Position: refs/heads/master@{#43496}
-
Toon Verwaest authored
This is mostly prework to also support prototype chain checks using data handlers BUG= Change-Id: I70aac1e86e45c78dfdc9f02d06b7e821494a4c9c Reviewed-on: https://chromium-review.googlesource.com/447679 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#43495}
-
Igor Sheludko authored
This CL also introduces Realm.navigate(i). BUG=chromium:683667 Change-Id: I9227292ea3a575f34367e82fc6297d234d3eecae Reviewed-on: https://chromium-review.googlesource.com/447638 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#43494}
-
kozyatinskiy authored
For breakpoints which are set by setBreakpointByUrl(url:..) backend calculates source hint on first related breakpoints resolved event and then uses this hint to adjust breakpoint position in later arrived scripts with the same url or on page reload. Doc: https://docs.google.com/a/google.com/document/d/1VtWo_-jelzEXSNbjESGTtruZngzXgbHLexfTzxNlnjE/edit?usp=sharing BUG=chromium:688776 R=pfeldman@chromium.org, alph@chromium.org Review-Url: https://codereview.chromium.org/2671193002 Cr-Commit-Position: refs/heads/master@{#43493}
-
hpayer authored
BUG=chromium:697049 Review-Url: https://codereview.chromium.org/2723473002 Cr-Commit-Position: refs/heads/master@{#43492}
-
mvstanton authored
It tests a pipeline configuration we are removing. BUG=v8:5778 Review-Url: https://codereview.chromium.org/2715153005 Cr-Commit-Position: refs/heads/master@{#43491}
-
Marja Hölttä authored
With the params (a, b, ...c) the param / variable declaration order used to be "temp, temp, c, a, b". Now it is "temp, temp, a, b, c" as you'd expect. This makes it easier for PreParser to match the parameter order of Parser. R=verwaest@chromium.org BUG=v8:5516 Change-Id: I79da04ef3f812bf52c032bed6263c009fecb7988 Reviewed-on: https://chromium-review.googlesource.com/447677Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#43490}
-
machenbach authored
Revert of Add several SIMD opcodes to IA32 (patchset #9 id:160001 of https://codereview.chromium.org/2695613004/ ) Reason for revert: Fails with nosse4: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug/builds/13853 Original issue's description: > Add several SIMD opcodes to IA32 > > CreateInt32x4, Int32x4ExtractLane, Int32x4ReplaceLane > Int32x4Add, Int32x4Sub > > Also add paddd and psubd to ia32-assembler > > BUG= > > Review-Url: https://codereview.chromium.org/2695613004 > Cr-Commit-Position: refs/heads/master@{#43483} > Committed: https://chromium.googlesource.com/v8/v8/+/4deb9ffdecf121c69a3db7eae6698eae23a80a15 TBR=bbudge@chromium.org,gdeepti@chromium.org,bmeurer@chromium.org,jing.bao@intel.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2717423003 Cr-Commit-Position: refs/heads/master@{#43489}
-
littledan authored
Reland of [test] Speculatively remove local-tests from archive (patchset #1 id:1 of https://codereview.chromium.org/2640223003/ ) Reason for revert: With the Windows bots fixed in https://chromium-review.googlesource.com/445786 , this should be good to reland. Thanks, Michael! Original issue's description: > Revert of [test] Speculatively remove local-tests from archive (patchset #2 id:20001 of https://codereview.chromium.org/2643983002/ ) > > Reason for revert: > Breaks all windows bots: > https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug/builds/6811 > > Original issue's description: > > [test] Remove local-tests from test262 archive and add to .isolate > > > > This might help fix the bots, which are broken in e.g., > > https://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/builds/14011 > > > > The archive was added in order to transmit test262 tests more rapidly. > > It doesn't serve much of a purpose for local-tests. I naively added > > local-tests there out of symmetry. However, the BUILD.gn file does not > > regenerate an archive when files are only deleted and not added or > > changed. Since the performance concern is not present for the small > > volume of local-tests, this patch reverts to the more normal mechanism > > for sending over dependencies, with test262.isolate. > > > > R=adamk > > > > Review-Url: https://codereview.chromium.org/2643983002 > > Cr-Commit-Position: refs/heads/master@{#42485} > > Committed: https://chromium.googlesource.com/v8/v8/+/9f545ea96f18b7036ac6ec43e359d63f41c3686a > > TBR=adamk@chromium.org,littledan@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Review-Url: https://codereview.chromium.org/2640223003 > Cr-Commit-Position: refs/heads/master@{#42491} > Committed: https://chromium.googlesource.com/v8/v8/+/4ffe0850dbb238dca4c1e2d14fb2984442a1fa24 TBR=adamk@chromium.org,machenbach@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2725643002 Cr-Commit-Position: refs/heads/master@{#43488}
-
yangguo authored
R=jgruber@chromium.org BUG=v8:5821 Review-Url: https://codereview.chromium.org/2720013003 Cr-Commit-Position: refs/heads/master@{#43487}
-
Toon Verwaest authored
This avoids creating unnecessary intermediate maps. BUG=chromium:588893 Change-Id: Ibc20908270a6fab58fc391f4b7e7941d9c043e9b Reviewed-on: https://chromium-review.googlesource.com/445785Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#43486}
-
yangguo authored
Unibrow is currently at Unicode version 7.0.0, which does not include mongolian vowel separator (\u180E) as white space. In order to appease test262 at the time however we kept it as a whitespace. Test262 has since then been updated. And while this is not an update of unibrow, we are removing \u180E as white space here. R=jshin@chromium.org, littledan@chromium.org BUG=v8:5155 Review-Url: https://codereview.chromium.org/2720953003 Cr-Commit-Position: refs/heads/master@{#43485}
-
Michael Achenbach authored
BUG=chromium:664068 NOTRY=true TBR=yangguo@chromium.org,jarin@chromium.org Change-Id: I180153f0cb70e81711e01c9c09060e9af2f85354 Reviewed-on: https://chromium-review.googlesource.com/446363Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#43484}
-
jing.bao authored
CreateInt32x4, Int32x4ExtractLane, Int32x4ReplaceLane Int32x4Add, Int32x4Sub Also add paddd and psubd to ia32-assembler BUG= Review-Url: https://codereview.chromium.org/2695613004 Cr-Commit-Position: refs/heads/master@{#43483}
-
Michael Achenbach authored
This relaxes the check if the test262 archive should be unpacked or not. A bug in the swarming isolate processor for windows makes the old check for the data directory pass and not unpack. With this work-around we actually start running tests on windows. This also fixes the regexp for exception extraction and handles the windows drive letter. It also strips whitespace to fix a case where a carriage return was included on windows. BUG=v8:5872 Change-Id: I363925665b0bad7530a1f93a2ea8f39b056d4174 Reviewed-on: https://chromium-review.googlesource.com/445786 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Daniel Ehrenberg <littledan@chromium.org> Cr-Commit-Position: refs/heads/master@{#43482}
-
Marja Hölttä authored
The x64 side is included in https://chromium-review.googlesource.com/c/444226/ BUG=v8:5294 Change-Id: Ie255604c5e38c72e3c2b76e1ca3557a5fde108ee Reviewed-on: https://chromium-review.googlesource.com/446394Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#43481}
-
Michael Starzinger authored
R=yangguo@chromium.org TEST=message/regress/regress-crbug-691194 BUG=chromium:691194 Change-Id: I72198e087f88abf89cdd38b99c19e10cbebda08d Reviewed-on: https://chromium-review.googlesource.com/445942Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#43480}
-
Michael Starzinger authored
The above intrinsic by now has to perform a check whether the prototype of a derived constructor is actually a constructor function itself. This is done as part of the {JSGetConstructorCall} operator. The intrinsic should just reduce down to the operator to maintain correct semantics. R=bmeurer@chromium.org TEST=mjsunit/regress/regress-crbug-696622 BUG=chromium:696622 Change-Id: Ia19c188f17ad16b12248db1f01a01b8d7258499b Reviewed-on: https://chromium-review.googlesource.com/447716Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#43479}
-
tebbi authored
R=bmeurer@chromium.org BUG= Review-Url: https://codereview.chromium.org/2680973013 Cr-Original-Commit-Position: refs/heads/master@{#43163} Committed: https://chromium.googlesource.com/v8/v8/+/f01c8a6e4b24ab38e58bb141fc251bc6b75dbe21 Review-Url: https://codereview.chromium.org/2680973013 Cr-Commit-Position: refs/heads/master@{#43478}
-
jarin authored
BUG=chromium:694088 Review-Url: https://codereview.chromium.org/2725593002 Cr-Commit-Position: refs/heads/master@{#43477}
-
ivica.bogosavljevic authored
In Wasm-to-interpeter entry creation, arguments for the interpreter are stored in an argument buffer. Depending on the order of the arguments some arguments may be misaligned and this causes crashes on those architectures that do not support unaligned memory access. TEST=cctest/test-wasm-interpreter-entry/TestArgumentPassing_AllTypes BUG= Review-Url: https://codereview.chromium.org/2705293011 Cr-Commit-Position: refs/heads/master@{#43476}
-
tebbi authored
The new NewUnmappedArgumentsElements node now takes two inputs: - the frame holding the arguments (current frame or arguments adaptor frame) - the length of the suffix of passed arguments to be copied into the backing store These inputs are computed with two new node types: ArgumentsFrame() ArgumentsLength[formal_parameter_count,is_rest_length](Node* arguments_frame) The node type NewRestParameterElements can now be expressed with NewUnmappedArgumentsElements and an appropriate length and is thus not needed anymore. In escape analysis, we lower loads from the length field of NewUnmappedArgumentsElements with its length input and if we find out that no write access to the arguments elements exists, we replace element loads with direct stack access and replace the NewUnmappedArgumentsElements node with a node of the new node type ArgumentsElementsState. This corresponds to an ObjectState node and gets translated into a deoptimizer instruction to allocate the backing store. Together with the already existing deoptimizer support for the actual arguments object/rest parameters, this allows to remove all allocations for arguments objects/rest parameters in this case. In the deoptimizer, we read the actual parameters from the stack while transforming the static deopt info into TranslatedValue objects. If escape analysis cannot remove the backing store allocation, NewUnmappedArgumentsElements gets lo BUG=v8:5726 Review-Url: https://codereview.chromium.org/2692753004 Cr-Commit-Position: refs/heads/master@{#43475}
-
jkummerow authored
Avoiding runtime call overhead. There's a fast path for Function.prototype loads, which are very common. BUG=v8:5269 Review-Url: https://codereview.chromium.org/2711353002 Cr-Commit-Position: refs/heads/master@{#43474}
-
hablich authored
TBR=machenbach@chromium.org NOTRY=true NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2721593004 Cr-Commit-Position: refs/heads/master@{#43473}
-
Michael Starzinger authored
R=bradnelson@chromium.org TEST=mjsunit/wasm/asm-with-wasm-off BUG=chromium:696655 Change-Id: I9375d8ac2f111009233dc480529fd0f0e00fe811 Reviewed-on: https://chromium-review.googlesource.com/447398Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#43472}
-
Michael Starzinger authored
This handles relational comparison operations (no equality yet) having number feedback during the early type-hint lowering (i.e. during graph construction). R=jarin@chromium.org Change-Id: Ia276d1d7c5931f1e92f31e4e24c181d82d48a138 Reviewed-on: https://chromium-review.googlesource.com/446762Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#43471}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/c7c2db6..d25400d Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/7e53759..b3771b1 Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/47b9857..4f3d6da Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/9913fb1..37d701b TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Change-Id: I23061bacabda9ed97edf9d849d6811ed313bac7e Reviewed-on: https://chromium-review.googlesource.com/447360Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#43470}
-
hablich authored
NOTRY=true TBR=machenbach@chromium.org Review-Url: https://codereview.chromium.org/2721663004 Cr-Commit-Position: refs/heads/master@{#43469}
-
yangguo authored
Add tests for local variables in function scopes and async features. R=jgruber@chromium.org BUG=v8:5821 Review-Url: https://codereview.chromium.org/2707043003 Cr-Commit-Position: refs/heads/master@{#43468}
-
aseemgarg authored
Revert "Revert of [Atomics] Implement ldaxr/stlxr instructions in ARM64 simulator (patchset #8 id:140001 of https://codereview.chromium.org/2711473002/ )" This reverts commit 2362f869. BUG=v8:4614 Review-Url: https://codereview.chromium.org/2720133004 Cr-Commit-Position: refs/heads/master@{#43467}
-
jbroman authored
This makes it no longer necessary to ensure that V8 and Blink have non-colliding tags, which makes it easier for them to evolve independently, and also makes the wire format more suitable for other V8 embedders, who would not necessarily be surveyed before V8 introduced a new tag that might collide with theirs. BUG=chromium:686159 Review-Url: https://codereview.chromium.org/2709023003 Cr-Commit-Position: refs/heads/master@{#43466}
-
- 27 Feb, 2017 2 commits
-
-
aseemgarg authored
BUG=v8:4124 R=bradnelson@chromium.org,bbudge@chromium.org,gdeepti@chromium.org Review-Url: https://codereview.chromium.org/2713613005 Cr-Commit-Position: refs/heads/master@{#43465}
-
bjaideep authored
R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2722603003 Cr-Commit-Position: refs/heads/master@{#43464}
-