-
littledan authored
Reland of [test] Speculatively remove local-tests from archive (patchset #1 id:1 of https://codereview.chromium.org/2640223003/ ) Reason for revert: With the Windows bots fixed in https://chromium-review.googlesource.com/445786 , this should be good to reland. Thanks, Michael! Original issue's description: > Revert of [test] Speculatively remove local-tests from archive (patchset #2 id:20001 of https://codereview.chromium.org/2643983002/ ) > > Reason for revert: > Breaks all windows bots: > https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug/builds/6811 > > Original issue's description: > > [test] Remove local-tests from test262 archive and add to .isolate > > > > This might help fix the bots, which are broken in e.g., > > https://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/builds/14011 > > > > The archive was added in order to transmit test262 tests more rapidly. > > It doesn't serve much of a purpose for local-tests. I naively added > > local-tests there out of symmetry. However, the BUILD.gn file does not > > regenerate an archive when files are only deleted and not added or > > changed. Since the performance concern is not present for the small > > volume of local-tests, this patch reverts to the more normal mechanism > > for sending over dependencies, with test262.isolate. > > > > R=adamk > > > > Review-Url: https://codereview.chromium.org/2643983002 > > Cr-Commit-Position: refs/heads/master@{#42485} > > Committed: https://chromium.googlesource.com/v8/v8/+/9f545ea96f18b7036ac6ec43e359d63f41c3686a > > TBR=adamk@chromium.org,littledan@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Review-Url: https://codereview.chromium.org/2640223003 > Cr-Commit-Position: refs/heads/master@{#42491} > Committed: https://chromium.googlesource.com/v8/v8/+/4ffe0850dbb238dca4c1e2d14fb2984442a1fa24 TBR=adamk@chromium.org,machenbach@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2725643002 Cr-Commit-Position: refs/heads/master@{#43488}
a48d7ce2