- 25 May, 2022 13 commits
-
-
Milad Fa authored
GN is not available as a cipd package for ppc/s390 and needs to be built from source. Change-Id: I5f6eda13cd6227d20fc800cab7f54496a2d33f68 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3663154Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#80743}
-
Igor Sheludko authored
When a callback does not intercept the request 1) it should not call info.GetReturnValue().Set(), 2) it must not produce side effects. Bug: v8:12873, chromium:1310062 Change-Id: If02994f24f1a68eb96c1af7cdd6dd7109f0617c4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3652786Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#80742}
-
Simon Zünd authored
This CL fixes an issue with async stacks. The async task stack is not torn down between page navigations or reloads. The result is that any new async tasks are stacked on top of the old pages async task stack. This was not prominent until now for two reasons: 1) Async tasks created in blink are always finished as long as destructors have time to run. 2) When V8 is terminated while running the micro task queue also all async tasks created for Promises (including `await`) are cleaned up properly. Introducing the stack tagging API made it more common for having unfinished async tasks open outside the MTQ, which left the async task stack non-empty during navigation. This CL fixes this problem by clearing out all the async task and async stack data structures for a context group when that context group is reset. R=bmeurer@chromium.org, victorporof@chromium.org Fixed: chromium:1328785 Change-Id: Iee0c3c4a55f66e643829dae3726dc03c735da1dd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3666620Reviewed-by:Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#80741}
-
Darius M authored
Bug: v8:12865 Change-Id: I539a5b0a9c3c78ef9a767de75b71dd06de337d9a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3647351Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Darius Mercadier <dmercadier@chromium.org> Cr-Commit-Position: refs/heads/main@{#80740}
-
Samuel Groß authored
V8_SANDBOX has been renamed to V8_ENABLE_SANDBOX in crrev.com/c/3647355 and its remaining uses in Chromium have now been renamed as well. Bug: v8:10391 Change-Id: Ibb23ecab6687438b462685ef7fa044c0024dd098 Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3660251Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Samuel Groß <saelo@chromium.org> Cr-Commit-Position: refs/heads/main@{#80739}
-
Clemens Backes authored
There were multiple fields missing from the output. R=jkummerow@chromium.org Change-Id: Ie4c3171339943414c58c2fe6f0e507cdd531dd8b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3664497Reviewed-by:
-
Liu Yu authored
Port commit 22a16bda Bug: chromium:1311960 Change-Id: Id06b901e5290a0c7d2c01f4fabbb98d0f47eb570 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3665938 Auto-Submit: Liu Yu <liuyu@loongson.cn> Reviewed-by:
Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/main@{#80737}
-
Leszek Swirski authored
Add a generic DefineNamedOwn node for DefineNamedOwnProperty, and a monomorphic fast path identical to SetNamedProperty for simple field stores. Bug: v8:7700 Change-Id: I35ff9d54be8bb8e437865e4d1ba38eb726034e24 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3663084 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Simon Zünd authored
This CL fixes a wrong assumption in the LiveEdit machinery. Namely the assumption that every FunctionLiteral the parser finds, will have a corresponding SFI created by the compiler. This assumption does not hold in all cases. Inner functions that are never referenced by the outer function don't get an SFI. R=bmeurer@chromium.org Fixed: chromium:1328453 Change-Id: I674f023f948954c1fcae04a4aa2afb69ea1642aa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3663443 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/37be1e8..7eb8c0f Introduce warmup phase to BenchmarkRunner (#1130) (#1399) (Matthdonau) https://chromium.googlesource.com/external/github.com/google/benchmark/+/7eb8c0f Add support to get clock for new architecture CSKY (#1400) (Zi Xuan Wu (Zeson)) https://chromium.googlesource.com/external/github.com/google/benchmark/+/6c46c9f R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org Change-Id: Id8121e8c4d87442bde184c7c940d8b102ebdf9c0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3665706 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#80734}
-
Andreas Haas authored
The CL https://crrev.com/c/3530115 deleted files that were referenced in the bazel build script. R=bmeurer@chromium.org Change-Id: I8e7bbcd90f7ada516209f478fe78e1437b04c697 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3664496 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Frank Tang authored
Also add AO: CompareTemporalTime Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.plaintime.compare https://tc39.es/proposal-temporal/#sec-temporal.plaintime.prototype.equals https://tc39.es/proposal-temporal/#sec-temporal-comparetemporaltime Bug: v8:11544 Change-Id: I8e2a320c2e296558e1fb15ef6e855e6b6a14ece2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3538669Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#80732}
-
Frank Tang authored
Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.plaindatetime.prototype.toplaindate https://tc39.es/proposal-temporal/#sec-temporal.plaindatetime.prototype.toplaintime Bug: v8:11544 Change-Id: Ifb7115823d1d3d1ff53806f1b376d69302e00ae1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3385761Reviewed-by:
-
- 24 May, 2022 27 commits
-
-
Frank Tang authored
Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.plaintime.prototype.tozoneddatetime Bug: v8:11544 Change-Id: I147b1d21b4728520c5667a30548ec77f71d7445a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3554456Reviewed-by:
-
Clemens Backes authored
The Runtime_WasmCompileLazy function was returning a ptr-sized address, wrapped in an Object. This worked because no GC is triggered between the return from the runtime function and the point where we jump to the returned address. In a pointer-compressed world though, generated code assumes that all objects live in the same 4GB heap, so comparisons only compare the lower 32 bit. On a 64-bit system, this can lead to collisions where a comparison determines that the returned address equals a heap object, even though the upper 32-bit differ. This happens occasionally in the wild, where the returned function entry pointer has the same lower half than the exception sentinel value. This leads to triggering stack unwinding (by the CEntry stub), which then fails (with a CHECK) because there is no pending exception. This CL fixes that by returning a Smi instead which is the offset in the jump table where the kWasmCompileLazy builtin should jump to. The builtin then gets the jump table start address from the instance object, adds the offset that the runtime function returned, and performs the jump. We do not include a regression test because this failure is very spurious and hard to reproduce. R=jkummerow@chromium.org Bug: chromium:1311960 Change-Id: I5a72daf78905904f8ae8ade8630793c42e223984 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3663093 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Patrick Thier authored
The underlying issue was fixed with https://crrev.com/c/3660258 Bug: v8:12883 Change-Id: If7a1fdaf122396396cfbaaae3a68ef89bafc1703 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3663342 Auto-Submit: Patrick Thier <pthier@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#80728}
-
Clemens Backes authored
The Wasm C API currently disabled dynamic tiering, in order to have deterministic behaviour for serialization of Wasm modules. As dynamic tiering is now shipped, also the C API should follow. Serialization of a Wasm module now just serializes the current state, so embedders are responsible for warming up a module before serializing it. If requested, we can add an internal API to enforce full tier-up of all functions, but we will leave that for later. R=ahaas@chromium.org, jkummerow@chromium.org Bug: v8:12899 Change-Id: I55df63f0b6c1f285e4983f9f7d5fb66aa41637bd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3660261Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#80727}
-
Junliang Yan authored
Change-Id: Ifbfa391482215ed13954422fef028a5697ac6bb8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3663149Reviewed-by:
Milad Farazmand <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#80726}
-
Junliang Yan authored
Change-Id: I25b6f6d76177394e3812ce506a06381a1afcc863 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3663148Reviewed-by:
-
Junliang Yan authored
Change-Id: Ic7ac221c18f242740ae088b856d9295cd1256936 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3663147Reviewed-by:
-
Leszek Swirski authored
Same pattern as Int32 compare ops. Bug: v8:7700 Change-Id: Ia090cb97d6c5c99c6aa719ec5db1a2a8e2156472 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3663340Reviewed-by:
-
Peter Kasting authored
Math between disparate enums is deprecated. Use constexprs instead. This requires switching some caller code to work with the new non-enum constants also. Bug: chromium:1284275 Change-Id: Ifb3c8757ed62e2a0966120f830f0a7e282b53a16 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3661148 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/main@{#80722}
-
Leszek Swirski authored
We can check map validity cells for Sminess without checking their value, since their value as a Smi (and not a Cell) should always be "valid" Change-Id: Ie73079107144e352c358c0ec42abd0c10bdcf73a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3663090 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#80721}
-
Leszek Swirski authored
Clean up a couple of the StoreHandler methods returning Builtins to directly return the Code object, so that it can be used as a handler straight away without having to go via the MakeCodeHandler helper (which wasn't making anything anymore). Change-Id: I4976829d25e2bdad0cf41088b76121ac9b500cd5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3663083 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Bug: v8:7700 Change-Id: I6b03c715153c7e9a63abc848ac87faef809b49a8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3663089Reviewed-by:
-
Dominik Inführ authored
Stop the unmapper tasks before running a full GC. This ensures that all freed memory is actually reusable in the following full GC. We also need to keep freed pages around until after the GC in order to be able to perform page flags checks on them when updating pointers. However, when unmapper tasks are still running pages freed during the GC may be unmapped too early. Bug: chromium:1327132 Change-Id: I4fde7853b987975ae6ef304e89c53eb20b004d55 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3660247 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#80718}
-
Dominik Inführ authored
Fix failing tests with --no-use-map-space enabled. Bug: v8:12578 Change-Id: I121b0d22cd69e76b6c5c02d1f83a166af0610b83 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3663343Reviewed-by:
-
Michael Lippautz authored
The phase is generally sub-ms. What's left as a follow up is to remove the finalization step that schedules a finalization step (including embedder callbacks) through a stack guard. Bug: v8:12775 Change-Id: I35f36e5ba07f9acb4e92acf2a414559ccd6ad9bd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3663081 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#80716}
-
Leszek Swirski authored
Print the function, bytecode and feedback vector of any function we attempt to compile with maglev while any of the printing flags are enabled. Bug: v8:7700 Change-Id: I92831fbd6c687e10afee7e0698ef2c42d11c63ee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3663085 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Liu Yu authored
Due to differences in compiler versions and optimization levels, std::floor treats snan differently, as does std::ceil and std::trunc. So the implementation of some instructions is sometimes inconsistent with the physical machine. We add extra processing to them. Besides, fix Loong64Debugger::Debug error in simulator, IsTrap returns true only if break is encountered. Change-Id: I240d91ed658645a2453162107b6dd172735fbfef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3661259Reviewed-by:
-
jameslahm authored
... timeout in the big websnapshot tests. Bug: v8:12891 Change-Id: I7837ba985f835e20af294ea0206dfafb5def7619 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3660705Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: 王澳 <wangao.james@bytedance.com> Cr-Commit-Position: refs/heads/main@{#80713}
-
Dominik Inführ authored
Instead of invoking both the generational and marking barrier explicitly, we can just invoke the combined barrier which does both for us. Also we simply use the full write barrier for all writes in the deserializer. While we could avoid the generational barrier in a few cases, this only costs us a single predictable untaken branch without an additional load. Bug: v8:11708 Change-Id: Iebd0af06efe42a3ac4e5725131362600ab16bc7a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3662900 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Solomon Kinard authored
Change-Id: I924a2b4dc4ab5e7be22fd2a9a1084473ba65fc35 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3651039Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#80711}
-
Patrick Thier authored
Disable --always-use-string-forwarding-table when --shared-string-table is set. With --shared-string-table we can have parallel GCs in multiple client isolates. With --always-use-string-forwarding-table we can have young generation strings in the forwarding table, requiring table updates when the string gets promoted. This is not supported for parallel GCs. This CL also reverts the incorrect try to fix an issue with these flag combination introduced in https://crrev.com/c/3650719 Bug: v8:12877, v8:12007 Change-Id: I49a2aa300af36b82007a7d215afe9a70ac1ce39e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3660258 Commit-Queue: Patrick Thier <pthier@chromium.org> Reviewed-by:
-
Frank Tang authored
Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.plaindate.prototype.tozoneddatetime Bug: v8:11544 Change-Id: I758e46efdc33cfc3f336e5c595a402123ae6c485 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3535920Reviewed-by:
-
Frank Tang authored
Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.plaindate.prototype.with https://tc39.es/proposal-temporal/#sec-temporal.plainyearmonth.prototype.with https://tc39.es/proposal-temporal/#sec-temporal.plainmonthday.prototype.with Bug: v8:11544 Change-Id: I311d6246646ce18503804352bc95a374af3d8c6e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3565014Reviewed-by:
-
Frank Tang authored
Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.plaindate.prototype.toplaindatetime Bug: v8:11544 Change-Id: Ie86a5d8a2f1206a44d0e74638392ae26e0f8e900 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3534454Reviewed-by:
-
Frank Tang authored
Spec text: https://tc39.es/proposal-temporal/#sec-temporal.plaindatetime.prototype.withplaintime Bug: v8:11544 Change-Id: I5277fb88675bb6d99b028a289329db06b95cc003 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3565026 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Frank Tang authored
Sync to PR2036 https://github.com/tc39/proposal-temporal/pull/2036 Treat -000000 in DateExtendedYear as syntax error Bug: v8:11544 Change-Id: I8cf7a506e85ad2b74d572142d646f3f98cd8bffa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3633620 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Lu Yahan authored
Change-Id: Ie6c88a0e371b2ce0bfad6ac887168e08fce26c05 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3662541 Commit-Queue: ji qiu <qiuji@iscas.ac.cn> Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Reviewed-by:
ji qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#80704}
-
