[sandbox] Remove V8_SANDBOX

V8_SANDBOX has been renamed to V8_ENABLE_SANDBOX in crrev.com/c/3647355
and its remaining uses in Chromium have now been renamed as well.

Bug: v8:10391
Change-Id: Ibb23ecab6687438b462685ef7fa044c0024dd098
Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3660251Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Samuel Groß <saelo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80739}

BUILD.gn

@@ -722,7 +722,6 @@ external_v8_defines = [
   "V8_31BIT_SMIS_ON_64BIT_ARCH",
   "V8_COMPRESS_ZONES",
   "V8_ENABLE_SANDBOX",
-  "V8_SANDBOX",  # TODO(saelo) remove once no longer used in blink
   "V8_SANDBOXED_POINTERS",
   "V8_SANDBOXED_EXTERNAL_POINTERS",
   "V8_DEPRECATION_WARNINGS",
@@ -753,7 +752,6 @@ if (v8_enable_zone_compression) {
   enabled_external_v8_defines += [ "V8_COMPRESS_ZONES" ]
 }
 if (v8_enable_sandbox) {
-  enabled_external_v8_defines += [ "V8_SANDBOX" ]
   enabled_external_v8_defines += [ "V8_ENABLE_SANDBOX" ]
 }
 if (v8_enable_sandboxed_pointers) {

samples/hello-world.cc

@@ -20,7 +20,7 @@ int main(int argc, char* argv[]) {
   v8::V8::InitializeExternalStartupData(argv[0]);
   std::unique_ptr<v8::Platform> platform = v8::platform::NewDefaultPlatform();
   v8::V8::InitializePlatform(platform.get());
-#ifdef V8_SANDBOX
+#ifdef V8_ENABLE_SANDBOX
   if (!v8::V8::InitializeSandbox()) {
     fprintf(stderr, "Error initializing the V8 sandbox\n");
     return 1;

samples/process.cc

@@ -703,7 +703,7 @@ int main(int argc, char* argv[]) {
   v8::V8::InitializeExternalStartupData(argv[0]);
   std::unique_ptr<v8::Platform> platform = v8::platform::NewDefaultPlatform();
   v8::V8::InitializePlatform(platform.get());
-#ifdef V8_SANDBOX
+#ifdef V8_ENABLE_SANDBOX
   if (!v8::V8::InitializeSandbox()) {
     fprintf(stderr, "Error initializing the V8 sandbox\n");
     return 1;

samples/shell.cc

@@ -73,7 +73,7 @@ int main(int argc, char* argv[]) {
   v8::V8::InitializeExternalStartupData(argv[0]);
   std::unique_ptr<v8::Platform> platform = v8::platform::NewDefaultPlatform();
   v8::V8::InitializePlatform(platform.get());
-#ifdef V8_SANDBOX
+#ifdef V8_ENABLE_SANDBOX
   if (!v8::V8::InitializeSandbox()) {
     fprintf(stderr, "Error initializing the V8 sandbox\n");
     return 1;

src/init/v8.cc

@@ -131,7 +131,7 @@ void V8::Initialize() {
     CHECK(GetProcessWideSandbox()->is_initialized());
   } else if (!GetProcessWideSandbox()->is_initialized()) {
     // For now, we still allow the sandbox to be disabled even if V8 was
-    // compiled with V8_SANDBOX. This will eventually be forbidden.
+    // compiled with V8_ENABLE_SANDBOX. This will eventually be forbidden.
     GetProcessWideSandbox()->Disable();
   }
 #endif  // V8_ENABLE_SANDBOX