- 01 Jul, 2020 3 commits
-
-
Jakob Gruber authored
The typed version takes Effect/Control arguments instead of untyped Node* arguments. Bug: v8:8888 Change-Id: Ia4b9895256ab9ea2a22f9e590490280d7536eac7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2274609 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#68626}
-
Zhao Jiazhong authored
Port ef1d6a3b https://crrev.com/c/2227257 Change-Id: Id829db611fdfd475462efec2aa0ab6f94d3ddce3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2251680 Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#68625}
-
v8-ci-autoroll-builder authored
Rolling v8/base/trace_event/common: https://chromium.googlesource.com/chromium/src/base/trace_event/common/+log/ef35868..23ef533 Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/3a5fbeb..29bc352 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/1ed9957..6099f10 Rolling v8/third_party/aemu-linux-x64: I_sHBnheTA3cmFAjzkyUAhsmhpWXu82YLidstkjgsvIC..OQ8c-S6dNd0LdVeElhAYBgsHeiiM4xyJ8E6hy3pRIUMC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/de622ae..3f5d1ca Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/d9391fd..fdd2cd6 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/6849229..b49c12a TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibab2c61210b9142ddd269b48aadc5a39c6996ede Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2275116Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#68624}
-
- 30 Jun, 2020 25 commits
-
-
Jake Hughes authored
Whether or not a store requires a write barrier depends on several invariants within V8. Some flags can break these invariants. In particular, it's not possible to use enable_single_generation with incremental marking because marking barriers are omitted in places where it is assumed an object will be allocated in the young generation. This CL introduces a new flag, enable_unconditional_write_barriers, which allows us to specify that full write barriers should always happens. The main purpose of this is to support single generation GC with incremental marking, but it can also aid as a debugging tool to check for missed write barriers. Bug: v8:10614 Change-Id: I3ab640436bcefc118c9c5c34765421cb9ea4896f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2270546Reviewed-by: Anton Bikineev <bikineev@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Jake Hughes <jakehughes@google.com> Cr-Commit-Position: refs/heads/master@{#68623}
-
Dominik Inführ authored
Release operation uses more expensive operations on some architectures. Change-Id: Iab84d92c84c791d429b6635641daadb2d608f791 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2276039Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#68622}
-
Daniel Clifford authored
Also should address minor performance regressions for instance types that should (and used to) use map compare rather than instance_type comparison. In the process, convert a bunch of IsXXX methods from the CSA into exported Torque methods that call through to the Cast<> to ensure there is only a single implementation of the type checkers. Also clean up and remove duplicate/redundant code and unused Torque imports. Bug: v8:7793, chromium:1098481 Change-Id: I3cd5146d913bb75bab4f73415b1b94bc30924725 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2270545 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#68621}
-
Jakob Kummerow authored
Bug: v8:7748 Change-Id: I6bbb73ceb397b102783ecfcc553264d83e926df2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2273126 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#68620}
-
Ng Zhi An authored
Prototype f64x2.nearest on ARM for both ARM v7 and ARM v8. ARM v8 has support for vrintn, and for ARM v7 we fallback to runtime. Since ARM v8 uses vrintn, which is the same instruction used for F64RoundTiesEven (scalar), wasm-compiler reuses the Float64RoundTiesEven check. Bug: v8:10553 Change-Id: Ia4c4245cac87c132331f54e81dad323fc3fb9f6d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2268358Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#68619}
-
Daniel Clifford authored
e.g. the following is now valid Torque code: macro TestA(implicit c: Context)() {} macro TestB(): bool { return TestA(); } This is handy for more flexible usage of generics that may or may not use implicit parameters deep inside their specializations. Note that this change doesn't change the fundamental rigor (or lack thereof) around checking the usage of implicit parameters, which already do not require '_' before their parameter identifier if unused. It just silences errors in cases where a call site doesn't implicitly pass a parameter that ultimately doesn't have a use site and adds meaningful error messages in the case that it does. Bug: v8:7793 Change-Id: I559d06c0864a7e79fe52bee5a9a7af9941889748 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2274127 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#68618}
-
Mike Stanton authored
Often at the d8 prompt, you'd like to explore some pointer found from calls to %DebugPrint(). %DebugPrintPtr() takes a pointer and attempts to print it as an object. Change-Id: Ibc3368136a2ed92f400b52dbf2855f3c7d80d887 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2276046Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#68617}
-
Jakob Gruber authored
This is likely the major change of the series, as Call nodes are the focus of call reducer (and to a lesser extent other phases like inlining). This CL essentially adds the new input to Call nodes, and updates the rest of the pipeline. As a (fairly large) drive-by, I also introduce the JSCallNode wrapper class and apply it in call reducer. This change, although large, will hopefully make future refactorings *much* easier, since it is now clear where certain assumptions about Call node layout are made. Bug: v8:8888 Change-Id: Ia15fe0ba459b6034863a5815a4e4662cee41fc83 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2264353 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#68616}
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: Id88f9a9334160687af5f6234bc1cb30472949684 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2274131 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68615}
-
Dominik Inführ authored
OldGenerationAllocationCounter() needs to be invoked in safepoint, otherwise invocation races with background threads incrementing the counter. First landed in https://crrev.com/c/2235544 and relanded in https://crrev.com/c/2259854 because of regressions. This CL also invokes UpdateNewSpaceAllocationCounter() in the safepoint. Bug: v8:10315 Change-Id: I6104bed0aad848250feecfe51d6d849b184a8842 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2260560 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#68614}
-
Jakob Kummerow authored
This patch does not include support for RTTs for i31ref yet. Bug: v8:7748 Change-Id: Ifbeb8e305c2d0a57e4d5d6be761d046e330e0da1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2273135 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#68613}
-
Nico Hartmann authored
Bug: v8:10658 Change-Id: Iccc20acea0b506e8acffca944d19b70af011ee3d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2276035 Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#68612}
-
Camillo Bruni authored
- Support loading combined trace json files from telemetry - Add "Blink RCS" source to separate blink details - Add prompt for naming newly loaded files - Add Group.addsToTotal variable for easier unclassified tracking Drive-by-fix: use let instead of var Change-Id: I5e471d8d1462987d1da98c2229090215c1fc6179 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2273857 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#68611}
-
Andreas Haas authored
R=clemensb@chromium.org Bug: v8:10108 Change-Id: Ibfcef171e1a34153ea925aa657e66e7720c416ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2274130 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#68610}
-
Dominik Inführ authored
Emit live bytes and evacuation mode as text for evacuated pages. Also emit the number of evacuated pages. Change-Id: Iadf1ac60f4fd35774f879277efb0b83fac39dd63 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2273136Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#68609}
-
Michael Achenbach authored
Mostly gc-related flags didn't flush out any bugs yet, but often reduce test performance and lead to timeouts. No-Try: true Bug: chromium:1044942 Change-Id: I2a7b55f78bfa3d597de1a5674658829e0812d01a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2273861Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#68608}
-
Michael Achenbach authored
Previously we ran baseline (e.g. ignition) and one random secondary comparison configuration (e.g. turbofan) from the list of experiments. But Clusterfuzz imposes limitations on the total amount of fuzz tests. Therefore this change enables more throughput by always running the default configuration (ignition_turbofan like V8 is shipped) additionally to the baseline and the secondary configuration. This, hence, doubles the number of comparisons we run, with less than 50% additional runtime, since the slow baseline configuration is only run once. The experiments table is updated accordingly. Explicit entries running ignition_turbofan are removed (as it always runs now), instead some of the other configurations are increased in their relative percentage. We also get a few new configurations that didn't run before (e.g. forcing the slow path on x86). No-Try: true Bug: chromium:1100114 Change-Id: I69b2a41d78c06e556b309743a2aace1053c22f91 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2270307Reviewed-by: Liviu Rau <liviurau@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#68607}
-
Simon Que authored
This is a reland of 32b685fa There was an unrelated breakage. See https://crbug.com/v8/10655#c10 Original change's description: > infra: Set gcc builders not to use Goma > > NOTRY=true > NOTREECHECKS=true > > Bug: chromium:1100009 > Change-Id: I67deb383d41e6609d5c3215e02422c8b1c16f8f4 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2272738 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68593} TBR=liviurau@chromium.org NOTREECHECKS=true Bug: chromium:1100009 Change-Id: If59371bbe474383156effc6dfc92d848c304a416 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2276031Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#68606}
-
zeynepCankara authored
Indicium is a new tool that integrates all our Map and IC processing tools into one tool. This CL does not attempt to cleanly integrate the Map Processor and IC explorer, but provides an in initial starting point for further integration work. Bug: v8:10644 Change-Id: I753c116fd409c8c07613bf15f22e14aa1e8c8a0e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2259935 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#68605}
-
Camillo Bruni authored
Bug: chromium:1098842 Change-Id: Id29edfda99f49a167a03b5158396a07559c75907 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2270231Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#68604}
-
Clemens Backes authored
It seems that the mix of atomic and non-atomic updates to the same memory location is not working correctly. One fix is changing all memory updates to be atomic. Another fix is removing the non-atomic access that happens while the workers are already running (using atomic accesses). This CL implements the latter. R=ahaas@chromium.org Bug: v8:10647, v8:10650 Change-Id: I84b4f3f442b6be3c4ea6e51962a523f443f5e43b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2273133Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#68603}
-
Manos Koukoutos authored
Change-Id: I04902e3f91dae6083b3de7630fd91d49ad805a2a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2272565 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68602}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/d83f4a5..3a5fbeb Rolling v8/third_party/aemu-linux-x64: FN-ckx_oV2JTqPuW3iMG50qdN5FgGqm-4XP9AkoLwPUC..I_sHBnheTA3cmFAjzkyUAhsmhpWXu82YLidstkjgsvIC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/8353ff9..de622ae Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/6e6c67d..d9391fd Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/2479626..6849229 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9e7c14e44cf7dc89f4a410a498af0ee306d9f0f2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2274519Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#68601}
-
Zhao Jiazhong authored
On mips platform, call operations may be followed by trampolines, which leading to wrong information of the call instr's location in safepoint. This CL fix it by adding a last_call_pc_ to record the location. Besides, this CL also fix a bind operation in CheckTrampolinePool, which may try to use trampoline before it's emission. Change-Id: Ic0cbdb93afffa60a7389ee8177c381087fcaf52e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2095645 Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#68600}
-
Zhi An Ng authored
This reverts commit fa9c6e17. Reason for revert: Didn't fix the build. Original change's description: > Revert "Add support for __declspec(nocf)." > > This reverts commit 0c58583b. > > Reason for revert: https://crbug.com/v8/10656 and failures in https://ci.chromium.org/p/v8/builders/ci/V8%20Win64%20-%20msvc/14135 > > Original change's description: > > Add support for __declspec(nocf). > > > > __declspec(nocf) syntax was added in https://reviews.llvm.org/D72167 > > and annotates that checks should not be added on indirect calls > > within that function. > > > > BUG=chromium:584575 > > > > Change-Id: Ib2e2d2a827186a9c1fd3de15356b2b04d6a69e49 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2270707 > > Reviewed-by: Clemens Backes <clemensb@chromium.org> > > Commit-Queue: Will Harris <wfh@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#68590} > > TBR=wfh@chromium.org,clemensb@chromium.org > > Change-Id: Icec64feb44715a65e905a93e0c47fb37d4f11a09 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:584575 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2274736 > Reviewed-by: Zhi An Ng <zhin@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68598} TBR=wfh@chromium.org,clemensb@chromium.org,zhin@chromium.org Bug: chromium:584575 Change-Id: I0e305374c8325d87e4b18963da4e90802f136187 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2274356 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#68599}
-
- 29 Jun, 2020 12 commits
-
-
Zhi An Ng authored
This reverts commit 0c58583b. Reason for revert: https://crbug.com/v8/10656 and failures in https://ci.chromium.org/p/v8/builders/ci/V8%20Win64%20-%20msvc/14135 Original change's description: > Add support for __declspec(nocf). > > __declspec(nocf) syntax was added in https://reviews.llvm.org/D72167 > and annotates that checks should not be added on indirect calls > within that function. > > BUG=chromium:584575 > > Change-Id: Ib2e2d2a827186a9c1fd3de15356b2b04d6a69e49 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2270707 > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Will Harris <wfh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68590} TBR=wfh@chromium.org,clemensb@chromium.org Change-Id: Icec64feb44715a65e905a93e0c47fb37d4f11a09 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:584575 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2274736Reviewed-by: Zhi An Ng <zhin@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#68598}
-
Milad Farazmand authored
Change-Id: Iaa0075ea16c289a369b354f2f44b3d1161f2faac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2273581Reviewed-by: Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#68597}
-
Michael Achenbach authored
TBR=santa NOTREECHECKS=true Change-Id: I629255ea3f65134bec8a1c7428b36426960aa311 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2274120 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#68596}
-
Zhi An Ng authored
This reverts commit 32b685fa. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20vtunejit/36094 Original change's description: > infra: Set gcc builders not to use Goma > > NOTRY=true > NOTREECHECKS=true > > Bug: chromium:1100009 > Change-Id: I67deb383d41e6609d5c3215e02422c8b1c16f8f4 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2272738 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68593} TBR=sque@chromium.org,machenbach@chromium.org Change-Id: Ia43f1ed69859d8face0adeefc820a06bf2e04c82 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1100009 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2274086Reviewed-by: Zhi An Ng <zhin@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#68595}
-
Ng Zhi An authored
When filling stack slots, the start offset can be too large to fit into the immediate of a str instruction (which is used to handle remainders after stp). For example, a function with 32 i64 params will require 256 bytes reserved for the params, so the offset starts at 256 + 16 (instance) = 272. This does not fit into a int9, so we hit an UNREACHABLE case when emitting str. The fix here checks that start can fit in an unscaled immediate, and if it doesn't fallback to the general case. We could use the Str from macro-asesmbler, but that uses another instruction, so we are not saving anything. A check for IsImmLSUnscaled(-start-12) is sufficient because 12 is the largest possible value for remainder. So if -start-12 fits, everything else will fit. Bug: v8:10645 Change-Id: I1c415499ada3a807d5f3889f091150bfefdf471d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2267369 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#68594}
-
Simon Que authored
NOTRY=true NOTREECHECKS=true Bug: chromium:1100009 Change-Id: I67deb383d41e6609d5c3215e02422c8b1c16f8f4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2272738 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#68593}
-
Ng Zhi An authored
Prototype f64x2.trunc on ARM for both ARM v7 and ARM v8. ARM v8 has support for vrintz, and for ARM v7 we fallback to runtime. Since ARM v8 uses vrintz, which is the same instruction used for F64 trunc (scalar), wasm-compiler reuses the Float64RoundTruncate check. Bug: v8:10553 Change-Id: I074d5b4172809915d4b37c59bd3b0dcbf9a45e1d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2268357 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#68592}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/2dc7c7a..d83f4a5 Rolling v8/third_party/aemu-linux-x64: UoYLOT0X6577j70eB9nPqYQs9Z3Nh5lA4I-pRtTchO0C..FN-ckx_oV2JTqPuW3iMG50qdN5FgGqm-4XP9AkoLwPUC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/95c1f42..8353ff9 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/35c6274..6e6c67d Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/02daed1..8603eee Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/42b285f..2479626 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3bd5df9f3c05eee0f135b0ee49708024edddc812 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2269870 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#68591}
-
Will Harris authored
__declspec(nocf) syntax was added in https://reviews.llvm.org/D72167 and annotates that checks should not be added on indirect calls within that function. BUG=chromium:584575 Change-Id: Ib2e2d2a827186a9c1fd3de15356b2b04d6a69e49 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2270707Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#68590}
-
Ng Zhi An authored
Prototype f64x2.floor on ARM for both ARM v7 and ARM v8. ARM v8 has support for vrintm, and for ARM v7 we fallback to runtime. Since ARM v8 uses vrintm, which is the same instruction used for Float64RoundDown (scalar), wasm-compiler reuses the Float64RoundDown check. Bug: v8:10553 Change-Id: I6f3d5c378a811ed94859535667aed1fa2d1ee552 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2265234Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#68589}
-
Ng Zhi An authored
This modernizes python code without breaking Py2 compat. Ran with command: futurize --stage1 -w predictable_wrapper.py futurize --stage1 -w run-num-fuzzer.py futurize --stage1 -w run-tests.py futurize --stage1 -w v8_presubmit.py This only adds the absolute import, which use these semantics. It doesn't do anything differently in our case, these scripts are already doing absolute imports. But with these changes, running `futurize --stage2` will be less messy. Bug: v8:9871 Change-Id: I28182ab73dac6cfcbd544c2046026f14e5157eb3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2252555Reviewed-by: Tamer Tas <tmrts@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#68588}
-
Michael Lippautz authored
Bug: chromium:1056170 Change-Id: I24442979954f63dc8a2f8fd0494cc5d537b733a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2273131 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#68587}
-