• Daniel Clifford's avatar
    [torque] Unused implicit parameters can be undefined · 9bd8e5f2
    Daniel Clifford authored
    e.g. the following is now valid Torque code:
    
      macro TestA(implicit c: Context)() {}
    
      macro TestB(): bool {
        return TestA();
      }
    
    This is handy for more flexible usage of generics that may or may not
    use implicit parameters deep inside their specializations.
    
    Note that this change doesn't change the fundamental rigor (or lack
    thereof) around checking the usage of implicit parameters, which
    already do not require '_' before their parameter identifier if
    unused. It just silences errors in cases where a call site doesn't
    implicitly pass a parameter that ultimately doesn't have a use site
    and adds meaningful error messages in the case that it does.
    
    Bug: v8:7793
    Change-Id: I559d06c0864a7e79fe52bee5a9a7af9941889748
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2274127
    Commit-Queue: Daniel Clifford <danno@chromium.org>
    Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68618}
    9bd8e5f2
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...