- 18 Nov, 2020 7 commits
-
-
Nico Hartmann authored
NOTRY=true TBR=szuend@chromium.org Bug: v8:11176 Change-Id: If10560a5c36e22ef0cd9f3c7344b4dc30d3bcf02 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2546687Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#71251}
-
Georg Neis authored
Bug: v8:10927 Change-Id: I37d3b591ceedeec0239fcec66d41bcf26f8503bd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2546683 Commit-Queue: Georg Neis <neis@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#71250}
-
Zhi An Ng authored
Bug: v8:11074 Change-Id: Ifd47a3256ec23d2c62ff7bbaf4de226fdfd3f68d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2546123Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#71249}
-
Jakob Gruber authored
To be unskipped once root cause is fixed. Bug: v8:11166 Change-Id: I03c3ac9a7e715fce7683d230965bd92a410c8f91 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2546681 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#71248}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/c854b81..a3c2a5d Rolling v8/third_party/aemu-linux-x64: FwzgY9X10eGIOA-l6ukRroKmBYo1As7yOiPDRfc6PxAC..ZJSAA8Pwi2mDf7nU7eRK7e3lmUHyrNUgCmzdRwsMbnMC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/f92a763..80f68fb Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/d4e6fb6..868f530 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/c72342c..1b039cb TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic47da443ac8cd3b2ce6a83e3d80a54df8df7db8f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2546167Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#71247}
-
Zhi An Ng authored
Bug: v8:11074 Change-Id: I71fabf7628ec13440585c24381f5ba89e4df03d3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2543168Reviewed-by:
-
Zhi An Ng authored
These are prototype instructions, and were missing validation checks for lane immediates. Bug: chromium:1149040 Change-Id: I22537061e26980a1aa0b3944839ab947e5351d9a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2543164Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#71245}
-
- 17 Nov, 2020 31 commits
-
-
Frank Tang authored
This is a reland of 915f729a Original change's description: > Add regression tests for 4 calendar bugs > > These bugs was fixed by ICU68 > > Bug: v8:10526, v8:10527, v8:10528, v8:10529 > Change-Id: I8d0dcb52d849f742e0a29314ac8a148370f60a1a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2527086 > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71062} Cq-Include-Trybots: luci.v8.try:v8_android_arm64_n5x_rel_ng Bug: v8:10526 Bug: v8:10527 Bug: v8:10528 Bug: v8:10529 Change-Id: I8857fb8c104bb4bede8fe816574bfd46ccbcd082 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2536737 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#71244}
-
Milad Fa authored
Change-Id: Ic5d52b3a7be345cfc4f104f83f23a4deb5972e4f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2545622Reviewed-by:
Junliang Yan <junyan@redhat.com> Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#71243}
-
Santiago Aboy Solanes authored
In https://crrev.com/c/v8/v8/+/2536465 we added acquiring the lock in WriteToFlat. Then, acquiring in TryStringToDouble not only is not necessary but also has undefined behaviour. This was causing timeouts and meant the tests were disabled in https://crrev.com/c/v8/v8/+/2543398. Bug: v8:7790, v8:11171 Change-Id: Iaab4e5079bac96786e536a2e4b766e93ea17e2c4 Fixes: v8:11171 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2544544Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#71242}
-
Dominik Inführ authored
Guard for extremely large and small values passed to Isolate::AdjustAmountOfExternalAllocatedMemory from the embedder. Bug: chromium:1147372 Change-Id: Ib1470bdf2dd16cbc6e61dd1bca97fa5a66f04c77 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2543925 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Georgia Kouveli authored
Use the recently added -mmark-bti-property Clang flag to add GNU_PROPERTY_AARCH64_FEATURE_1_BTI to the ELF GNU program properties. Bug: v8:10026 Change-Id: Id35a60c9f5a8b3019313d56a142ab8f481e095a5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2543934Reviewed-by:
-
Clemens Backes authored
It took me a while to figure out how to set up everything to run the fuzzer locally. These improved error messages would have helped to find errors earlier. R=machenbach@chromium.org Bug: chromium:1142437 Change-Id: I414de0a8448cd81fdbf999cc7c3c8cf9394354f6 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2543397 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Michael Achenbach authored
This reverts commit 800307f6. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Mac%20-%20arm64%20-%20release%20builder/1258 Original change's description: > [wasm][memory64] Prepare Liftoff for ptrsize offsets > > This CL prepares the LiftoffAssembler interface for uintptr_t offsets. > Many places can still only handle 32-bit values, but after this CL we can > start storing the offsets as uintptr_t in the memory access immediates. > Some TODOs are placed to extend code generation for 64-bit additions, if > memory64 is enabled. > All of this will be addressed in follow-up CLs. > > R=manoskouk@chromium.org > > Bug: v8:10949 > Change-Id: Id3b9b8aa555ab41f082ba012f4f8d80586c35b89 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2529452 > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Manos Koukoutos <manoskouk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71236} TBR=clemensb@chromium.org,manoskouk@chromium.org Change-Id: I6246d2f16bc44b328915c6a66e9933f516459038 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10949 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2544546Reviewed-by:
-
Santiago Aboy Solanes authored
Make the three map's bitfields use release/acquire semantics. This ensures, for example, that when we set the number of own descriptors on the map we will do so with a release store. Also, start reading and writing said bitfields concurrently when concurrent inlining is enabled. Note the BIMODAL_ACCESSOR_WITH_FLAG_B macro which enables this. Bug: v8:7790 Change-Id: I16561d8e065c50ce272b085d9606b98e37922633 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2536640Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#71237}
-
Clemens Backes authored
This CL prepares the LiftoffAssembler interface for uintptr_t offsets. Many places can still only handle 32-bit values, but after this CL we can start storing the offsets as uintptr_t in the memory access immediates. Some TODOs are placed to extend code generation for 64-bit additions, if memory64 is enabled. All of this will be addressed in follow-up CLs. R=manoskouk@chromium.org Bug: v8:10949 Change-Id: Id3b9b8aa555ab41f082ba012f4f8d80586c35b89 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2529452 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#71236}
-
Nico Hartmann authored
TBR=solanes@chromium.org Bug: v8:11171 Change-Id: I8639f9becbb9fa8faa0a1823d58a83bf706d0fdd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2543398Reviewed-by:
-
Milad Fa authored
Change-Id: Ie09b35d2e2cd28996bb7ebaa54175c14a4f5cea8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2543162Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#71234}
-
Manos Koukoutos authored
Changes: - Fix read_value_type description. - Make sure read_value_type always emits an error for an invalid type. Remove checks for errors at call sites. - (Drive-by) Fix validation flags in DecodeLocals. Change-Id: I82bd8a61f0e26f39506fc6e4ab4be331dfe24ad7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2526390 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#71233}
-
Vicky Kontoura authored
This CL increases the budget for the tiering strategy of the js-to-wasm wrappers from 6 (which was initially picked at random, as the feature was experimental) to 1000 calls (which is picked based on benchmarking). The high-level rationale behind such a choice can be summarized in the following: - The generic wrapper is not that much slower than the specific wrappers, so it can handle up to some thousands of calls quite well. - After that, the generic wrapper starts lacking compared to the specific wrappers, even if compiling a specific wrapper means blocking the main thread. - Real-life applications do call exported functions thousands of times, so this is not an unrealistic choice. Bug: v8:10982 Change-Id: I143dd11e535101fd24810f63ed8b987cd03c4326 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2539913 Commit-Queue: Vicky Kontoura <vkont@google.com> Reviewed-by:
-
Leszek Swirski authored
Add a "combination" assert scope class, which combines multiple existing assert scopes. This will allow scopes with functional overlap, e.g. DisallowGarbageCollection and DisallowHeapAllocation, to share an assert type rather than rather than requiring users to remember to set both. To demonstrate this, this redefines DisallowGarbageCollection to a combination of DisallowHeapAllocation and a new DisallowSafepoints, and some of the DCHECKs checking both are simplified to only check one or the other, as appropriate. The combination classes become subclasses of the existing assert scopes, so that they can be used in their place as e.g. a function parameter, e.g. DisallowGarbageCollection can be passed to a function expecting const DisallowHeapAllocation&. As a drive-by, this also changes the per-thread assert scopes to use a bitmask, rather than a bool array, to store their per-thread data. The per-isolate scopes already used a bitmask, so this unifies the behaviour between the two. Change-Id: I209e0a56f45e124c0ccadbd9fb77f39e070612fe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2534814 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Vicky Kontoura authored
This CL just updates an outdated comment. Bug: v8:10982 Change-Id: I3ae60c9bf345b50c8e6fd7ce9c19ae9d0894734e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2539911 Commit-Queue: Vicky Kontoura <vkont@google.com> Reviewed-by:
-
Leszek Swirski authored
Port the fix from https://crrev.com/c/1414858 to ia32. TL;DR, _xgetbv is a reserved name. Change-Id: I97cb90ea7d244c02326432cfbfd55419a0a9854a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2543933 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Michael Achenbach authored
This reverts commit e95e1b62. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20arm%20-%20sim%20-%20debug/23064 Original change's description: > [heap] Introduce LocalIsolate for main thread > > Add a LocalIsolate for the main thread to Isolate. This LocalIsolate is > kept alive during the whole lifetime of the Isolate. The main thread > LocalIsolate starts in the Running state in contrast to the background > thread LocalIsolates (those start in Parked). > > Code paths in Turbofan that used to create a LocalIsolate on the main > thread can now simply use the main thread LocalIsolate. > > LocalIsolate for the main thread will help in reducing differences > between the main and background threads. The goal is that the main > thread behaves more like a background thread. > > The main thread LocalIsolate should also make it simpler to share code > between main thread and background threads by using LocalIsolate for > both. > > Bug: v8:10315 > Change-Id: I7fd61d305a6fd7079e2319d75c291c1021e70018 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2509593 > Reviewed-by: Simon Zünd <szuend@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71226} TBR=ulan@chromium.org,yangguo@chromium.org,neis@chromium.org,leszeks@chromium.org,szuend@chromium.org,dinfuehr@chromium.org Change-Id: Ia70b4bfe3b8fa26bf8d6a7dc612a310b0ed54073 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10315 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2543937Reviewed-by:
-
Vicky Kontoura authored
This CL adds a cctest to verify that the tiering strategy for the js-to-wasm wrappers works for functions that are only indirectly exported through exported tables. Bug: v8:10982 Change-Id: I8eede14ab620dbadb75af42b78bfac88230a6dd3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2536644 Commit-Queue: Vicky Kontoura <vkont@google.com> Reviewed-by:
-
Dominik Inführ authored
Add a LocalIsolate for the main thread to Isolate. This LocalIsolate is kept alive during the whole lifetime of the Isolate. The main thread LocalIsolate starts in the Running state in contrast to the background thread LocalIsolates (those start in Parked). Code paths in Turbofan that used to create a LocalIsolate on the main thread can now simply use the main thread LocalIsolate. LocalIsolate for the main thread will help in reducing differences between the main and background threads. The goal is that the main thread behaves more like a background thread. The main thread LocalIsolate should also make it simpler to share code between main thread and background threads by using LocalIsolate for both. Bug: v8:10315 Change-Id: I7fd61d305a6fd7079e2319d75c291c1021e70018 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2509593Reviewed-by:
Simon Zünd <szuend@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Allows embedders to allocate C++ objects on the internal managed C++ heap. Bug: chromium:1056170 Change-Id: Ibd81d0fc915478a81f14e8ab12a631e442790f04 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2536642Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#71225}
-
Jakob Gruber authored
This CL enables a first batch of feedback-based optimizations in NCI code. Specifically, optimizations based on unary, binary, compare, for-in-next, and for-in-prepare feedback are now enabled. This has two main implications: 1. NCI code can now deopt. Deoptimized code is currently thrown away permanently and cannot be reused. Now that shared/cached NCI code can deopt, this leads to an interesting question of what should happen with deoptimized NCI code. The answer in this CL is to remove the cache entry (it may later be re-added). 2. Tiering up from NCI to TF still requires feedback; since NCI code, starting with this CL, no longer collects full feedback, feedback must be created in some other way. This is solved by sharing a context-independent encoding of feedback across native contexts. Feedback is shared through a new SerializedFeedback object type, essentially a byte array of serialized feedback. Currently, only smi-based feedback is shared, but map-based feedback will be added in the future. SerializedFeedback is kept in the NCI cache alongside NCI Code objects. It is created on NCI cache insertion, and deserialized upon NCI cache hits. Bug: v8:8888 Change-Id: Ic0d5fbea3aa4d3b0a165624dab9d0283b07dcee7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2531775Reviewed-by:
Mythri Alle <mythria@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
Drive-by change: Fix wrong reference to FixedRangeBodyDescriptor in implementation-visitor.cc TBR: ulan@chromium.org Change-Id: I8a1f468f35c38f5be1f4e8d1cfcc9f0fd2a16381 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2540546 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Auto-Submit: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: -
Vicky Kontoura authored
This CL just refactors the `test-run-wasm-wrappers.cc` cctest. Bug: v8:10982 Change-Id: Ib8881c97c0cf395766d9b27a68ee440850df5d59 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2534819Reviewed-by:
-
Dominik Inführ authored
When a thread gets archived, we still need to scan and update debug roots on GCs for it. Otherwise we restore stale references when the thread becomes active again. Bug: v8:11145 Change-Id: I88f4c1534e826aed222e7fb67bd82bb0a4758fab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2537691Reviewed-by:
-
John Xu authored
Bug: v8:10927 Change-Id: Icbdc0d7329ddd466e7d67a954246a35795b4dece Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2507310 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#71220}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/944fd70..c854b81 Rolling v8/third_party/aemu-linux-x64: 2_kHlztQ5lFU-IhCP021uv4v5Ms-aBhhsqtZ1V02tbIC..FwzgY9X10eGIOA-l6ukRroKmBYo1As7yOiPDRfc6PxAC Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/fd5c198..d4e6fb6 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/013c5b9..c72342c TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4b81481d65743b3ff9aba9ede13659b540d26070 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2543315Reviewed-by:
-
Zhi An Ng authored
all_true, any_true, bitmask, and extract_lane all replace a simd type with single scalar, so we don't need to set nullptr for the extraneous lane, and can set num_lanes to 1. So for a call node with any of the above nodes as one of its value, we were incorrectly replacing the extract lane node with 4 nodes - it should only be 1 scalar node. Drive by fix for LowerShift, it needs to check if the shift value node has replacement (e.g. if it is an extract lane node). Also we weren't setting the lowered type of a kPhi node. This can be a problem if the output of a Phi node is used by a F32x4ExtractLane and I32x4ExtractLane, which is possible (and type correct since both take v128). This will require that the output be both a float and a int, which is impossible. So fix it to Int32x4, and the uses of the phi nodes will convert appropriately. Added a test for the call node. Also tested this code by running one of our benchmarks, which exercises the Phi logic. Bug: v8:10507 Change-Id: I01a76b349ba9d0e157b64e737bdb4c70f96aa954 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2536952 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#71218}
-
Zhi An Ng authored
The current name for the operator (for printing) is "Extract lane", without an indication of the shape. Add the shape (I32x4) and sign (for I8x16 and I16x8, s or u) to the name so that it is clearer what operation it is. Change-Id: I1ab30dee5ae820c378cdef8233de1c365dd126c5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2534630Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#71217}
-
Junliang Yan authored
Change-Id: Iaea977a35ea85d561368b04ecfbd2f16693a87a9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2543311Reviewed-by:
-
Zhi An Ng authored
With more of scalar lowering implemented, this test can now run with lowering. The only other tests that skip lowering are prototype instructions. Bug: v8:10507 Change-Id: Ia149956d2d406b6f76eb9155765474c23b89b894 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2507317Reviewed-by:
Ben Smith <binji@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#71215}
-
Zhi An Ng authored
S128Select and S128AndNot relies on the inputs being lowered to I32x4, since they use Word32Xor, but it wasn't correctly specified. This means that by default, their lowered type was set to be the output's lowered type. If the result of these operations were used by F32x4ExtractLane, then their lowered type will be set to Float32x4, so the inputs will be lowered to Float32x4, and we get incorrect type of registers allocated. Bug: v8:10507 Change-Id: I16dc7f2dcdaf2188997ff345a6b0fd22e10b7b36 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2536953Reviewed-by:
-
- 16 Nov, 2020 2 commits
-
-
Junliang Yan authored
Change-Id: I1d342b80589bedb6365ef0c91ad156d71ecc0622 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2542982Reviewed-by:
-
Camillo Bruni authored
Bug: v8:11165, v8:10096 Change-Id: I4be596f74a231641b8032e70063f47f4776ec6a8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2539919Reviewed-by:
-
