• Leszek Swirski's avatar
    [asserts] Add combination assert scopes · 076687ab
    Leszek Swirski authored
    Add a "combination" assert scope class, which combines multiple existing
    assert scopes.  This will allow scopes with functional overlap, e.g.
    DisallowGarbageCollection and DisallowHeapAllocation, to share an assert
    type rather than rather than requiring users to remember to set both. To
    demonstrate this, this redefines DisallowGarbageCollection to a
    combination of DisallowHeapAllocation and a new DisallowSafepoints, and
    some of the DCHECKs checking both are simplified to only check one or
    the other, as appropriate.
    
    The combination classes become subclasses of the existing assert scopes,
    so that they can be used in their place as e.g. a function parameter,
    e.g. DisallowGarbageCollection can be passed to a function expecting
    const DisallowHeapAllocation&.
    
    As a drive-by, this also changes the per-thread assert scopes to use a
    bitmask, rather than a bool array, to store their per-thread data. The
    per-isolate scopes already used a bitmask, so this unifies the
    behaviour between the two.
    
    Change-Id: I209e0a56f45e124c0ccadbd9fb77f39e070612fe
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2534814
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#71231}
    076687ab
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...