- 29 Apr, 2021 23 commits
-
-
Vicky Kontoura authored
This is a reland of 7dcc70b8 Original change's description: > [web snapshot] Support numbers > > This CL adds support for integer and double values in web snapshots. > > Bug: v8:11525, v8:11706 > Change-Id: Ib75c52d440cd51bf78f57eecca09cecf35b801a4 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2854734 > Commit-Queue: Vicky Kontoura <vkont@google.com> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74259} Bug: v8:11525 Bug: v8:11706 Change-Id: Ia5912ab22db24559c6d0f028a8e744ec448e2250 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859942Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Vicky Kontoura <vkont@google.com> Cr-Commit-Position: refs/heads/master@{#74286}
-
Sam Parker authored
Modify TryAnyExtendMatch to combine Int64Add/Int64Sub(x, ChangeInt32ToInt64(y)) to use an extend register operand, removing the cast. Change-Id: Id130f8a9614e2c208f9ed8c17b923ee738fcb916 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2857964Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Martyn Capewell <martyn.capewell@arm.com> Cr-Commit-Position: refs/heads/master@{#74285}
-
Vasili Skurydzin authored
Change-Id: Idabbd2b1326fcca04cd937a730c5418f9c9cf8af Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2855075Reviewed-by: Milad Fa <mfarazma@redhat.com> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Vasili Skurydzin <vasili.skurydzin@ibm.com> Cr-Commit-Position: refs/heads/master@{#74284}
-
Junliang Yan authored
Change-Id: Ia3c703dc47744cffc3f86ec46abb341e6c37590c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2857637Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#74283}
-
Maya Lekova authored
This reverts commit 4ff37d3a. Reason for revert: Fails with stress_incremental_marking - https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20TSAN%20-%20stress-incremental-marking/3049/blamelist Original change's description: > cppgc: Fix test IteratePointersFindsCalleeSavedRegisters > > call the compiler can clobber the tested register. Moving this tricky > part into a noninlinable lambda allows to reduce pressure from the > register allocator and thereby avoid such clobbering. > > Subtle: between the first inline assembly and the IteratePointers() > Change-Id: Ibeca8fa2f4fd54d07c2f585a4e876504a6a991b7 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859843 > Commit-Queue: Anton Bikineev <bikineev@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74280} Change-Id: Ib257e30273f382d19ec922e2fa3279c39e918cde No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859847 Auto-Submit: Maya Lekova <mslekova@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#74282}
-
Camillo Bruni authored
Selecting a single script from related events was not implemented. Change-Id: Id6dbe7f8eb235c5917e48a9ade7347404c114618 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859943Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#74281}
-
Anton Bikineev authored
call the compiler can clobber the tested register. Moving this tricky part into a noninlinable lambda allows to reduce pressure from the register allocator and thereby avoid such clobbering. Subtle: between the first inline assembly and the IteratePointers() Change-Id: Ibeca8fa2f4fd54d07c2f585a4e876504a6a991b7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859843 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#74280}
-
Milad Fa authored
This CL adds Power10 recognition to Linux, AIX as well as IBMi. Enabled features include: MODULO FPR_GPR_MOV SIMD LWSYNC ISELECT VSX Change-Id: Ifc337e6497a3efe9697bcf03063a2b94471f96e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2855041Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Junliang Yan <junyan@redhat.com> Reviewed-by: Vasili Skurydzin <vasili.skurydzin@ibm.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#74279}
-
Dan Elphick authored
This is a reland of dbd5ae52 Less common configs were fixed in other CLs. Original change's description: > [build] Enable gn check for most of v8 > > Currently there are 32 gn check failures across v8 (not including > third_party). These are due to issues in cppgc and inspector, which are > not trivially resolveable, so for now 4 targets (+ third_party) are > being excluded from the checks. > > Bug: v8:7330 > Change-Id: I506abe8e452c26239262499fc1fe2a6347a4c84b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2851886 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Dan Elphick <delphick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74255} Bug: v8:7330 Change-Id: I82047cfa7f8213312158123885808c2a4ad02160 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859842 Commit-Queue: Dan Elphick <delphick@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#74278}
-
Dan Elphick authored
Converts two deps to public_deps and adds a missing dependency. Bug: v8:7330 Change-Id: Ib83920bbd9886d8ebd2d4e531fde0d40c5e8cc33 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2857967Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#74277}
-
Benedikt Meurer authored
The "Restart frame" feature was implemented as part of LiveEdit and primarily used to support LiveEdit of active functions, but that was previously disabled as part of https://crrev.com/c/2846892 because it's too brittle and causes crashes when using seemingly unrelated features. The "Restart frame" feature was also available as a context menu item separately in the DevTools front-end, but that was also already removed as part of https://crrev.com/c/2854681 earlier. So all uses are gone now. This change works by marking Debugger.restartFrame as deprecated and having it respond with a ServerError all the time. It thus allows us to remove a whole bunch of machinery that was essentially just put in various places to support the restart_fp_ magic. In particular the debugger no longer needs any machine specific builtins now. Bug: chromium:1195927 Change-Id: I1153ba6b00e979620af57dd9f58aa1c035ec4484 Fixed: chromium:1203606 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2854750Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#74276}
-
Michael Lippautz authored
- Reset parent object and signal stack with nullptr sentinel - Adjust FATAL messaging - Fix dispatch for in-construction objects on stack Bug: v8:11709 Change-Id: I4da0f0f373699aa1fa09745231911c7056978a4f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2856837Reviewed-by: Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#74275}
-
Georg Neis authored
Tbr: nicohartmann@chromium.org Change-Id: I88048691595dcd8df55082d57455c49f32a5fe31 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2857966Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#74274}
-
Junliang Yan authored
Root slots are full pointer size. Using tagged ptr loads will lead to errors on big endian platform. Change-Id: I477597fadee025b6fb060d67a83bee60290aeb14 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2857636 Commit-Queue: Junliang Yan <junyan@redhat.com> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#74273}
-
Dan Elphick authored
This fixes the gn check errors for configs using v8_use_external_startup_data = false and v8_enable_vtunejit = true. Bug: v8:7330 Change-Id: If7eb48bbf339ba53646e4722c7c90d6e5857ff22 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859162 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#74272}
-
Dominik Inführ authored
We don't need to iterate all heap objects here since we are only interested in builtins. Bug: v8:11641 Change-Id: Ib5b959010ad82b6fe50991f85a93d165030bd804 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2857962 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#74271}
-
Wenyu Zhao authored
* Will bring them back after TPH supports collection. Bug: v8:11641 Change-Id: Ia170302ccaad9595663cf6bc618e725545a916e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2858294 Auto-Submit: Wenyu Zhao <wenyu.zhao@anu.edu.au> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#74270}
-
Camillo Bruni authored
Change-Id: I424e4de75cfd628d034033c99ce2a6e7b88c6a52 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2857958Reviewed-by: Patrick Thier <pthier@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#74269}
-
Toon Verwaest authored
While evaluating a class literal the containing function points to Token::CLASS. It may have pushed a context for that class that uses the range of the class scope. So far the class scope had a range that started after the class name or class token in case of anonymous classes. That means the source position of the function frame doesn't point to a position that is included in the active context range. This breaks the debugger because it relies on being able to find the matching parser scope for the active context by looking at the source position. The fix is two-fold: - extend the class scope source range to include Token::CLASS - update ScopeChainRetriever::ContainsPosition to include the start position of class scopes as a valid source position. We can't always include start due to arrow functions that don't have braces. Bug: chromium:1156498 Change-Id: I9ec640c6326289dadcb154bb0a329ca6f8188f8b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2857957Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#74268}
-
Camillo Bruni authored
Bug: chromium:1201936 Change-Id: I1ee545e33587ddf4a5c7e1cbd64b53d36c75a146 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2850936Reviewed-by: Marja Hölttä <marja@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#74267}
-
Jakob Kummerow authored
Replacing a crash with a TypeError. Bug: chromium:1203692 Change-Id: I6970f980b46f20033f29c1deb9bc5d49ea2014ae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2856842 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#74266}
-
Jakob Gruber authored
Drive-by: Fix type hierarchies of a few FixedArray-related classes. Done in this CL because it's based on the changes to FixedArrayData. Drive-by: Allow AllocateFastLiteral (now TryAllocateFastLiteral) to fail. Needed since currently ObjectRef creation may fail. Bug: v8:7790 Change-Id: I1f8cf35a16408ed0e327f12602c832838254bb03 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2853592 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#74265}
-
Jakob Gruber authored
In non-object-print builds, we were missing a trailing newline int tracing output, messing up Memory.json parsing. Tbr: machenbach@chromium.org Change-Id: Ic826a4e20e348be6687c4981b48e6ab094f470ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2857955Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#74264}
-
- 28 Apr, 2021 17 commits
-
-
Junliang Yan authored
Change-Id: Idf927a4c8bc5e4751e5e8913fe9912fd44001190 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2857854Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#74263}
-
Michael Lippautz authored
GCC 7.4 has problems with combining [[nodiscard]] with __attribute__((visibility(""))). Disable as there's enough compilation coverage for clang to find issues. Bug: v8:11707 Change-Id: I9e61463c4d11dbc3b03d458e2810206fb93de108 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2854737Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Santiago Aboy Solanes <solanes@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#74262}
-
Shu-yu Guo authored
This CL factors out a CodeRange class out of MemoryAllocator. When V8_COMPRESS_POINTERS_IN_SHARED_CAGE is defined, there is a single CodeRange shared by all Isolates in the process. This also turns short builtins back for both configurations of pointer compression. When sharing a cage, there is a single copy of the re-embedded builtins. Since a shared pointer cage is still experimental, to avoid API churn this CodeRange's size is not configurable and is always the maximal size depending on the underlying platform. Change-Id: Ie94f52746f2c5450247a999cc6071e3914d4cf0c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2819206Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#74261}
-
Zhi An Ng authored
This reverts commit 7dcc70b8. Reason for revert: Fails to compile on V8 Linux gcc https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20gcc/11474/overview Original change's description: > [web snapshot] Support numbers > > This CL adds support for integer and double values in web snapshots. > > Bug: v8:11525, v8:11706 > Change-Id: Ib75c52d440cd51bf78f57eecca09cecf35b801a4 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2854734 > Commit-Queue: Vicky Kontoura <vkont@google.com> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74259} Bug: v8:11525 Bug: v8:11706 Change-Id: If107fb890c28a60c2d87859f634fdafeb73dc6c3 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2857156 Auto-Submit: Zhi An Ng <zhin@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#74260}
-
Vicky Kontoura authored
This CL adds support for integer and double values in web snapshots. Bug: v8:11525, v8:11706 Change-Id: Ib75c52d440cd51bf78f57eecca09cecf35b801a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2854734 Commit-Queue: Vicky Kontoura <vkont@google.com> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#74259}
-
Dan Elphick authored
Use relative paths to access v8 root build rules since // means something different in a chrome build. Bug: v8:7330 Change-Id: I4eac73b394daaf0250b0fa2ad415af560b03c114 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2856840 Commit-Queue: Dan Elphick <delphick@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#74258}
-
Almothana Athamneh authored
Bug: v8:11694 Change-Id: I27122524ee2991aca324867186a9443c57af3552 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2856542Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Cr-Commit-Position: refs/heads/master@{#74257}
-
Michael Achenbach authored
This reverts commit dbd5ae52. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20-%20internal%20snapshot/33829 https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20vtunejit/41526 https://ci.chromium.org/p/v8/builders/ci/V8%20iOS%20-%20sim/12150 https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20-%20debug%20-%20perfetto%20-%20builder/12811 Original change's description: > [build] Enable gn check for most of v8 > > Currently there are 32 gn check failures across v8 (not including > third_party). These are due to issues in cppgc and inspector, which are > not trivially resolveable, so for now 4 targets (+ third_party) are > being excluded from the checks. > > Bug: v8:7330 > Change-Id: I506abe8e452c26239262499fc1fe2a6347a4c84b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2851886 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Dan Elphick <delphick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74255} Bug: v8:7330 Change-Id: I20e4f99217c93794ab523b4018c5161d8364f7b7 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2856839 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Dan Elphick <delphick@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#74256}
-
Dan Elphick authored
Currently there are 32 gn check failures across v8 (not including third_party). These are due to issues in cppgc and inspector, which are not trivially resolveable, so for now 4 targets (+ third_party) are being excluded from the checks. Bug: v8:7330 Change-Id: I506abe8e452c26239262499fc1fe2a6347a4c84b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2851886Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#74255}
-
Dan Elphick authored
Bug: v8:7330 Change-Id: I4bb602a41f127d4e3201defa3176f7e99e6d3753 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2851894 Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/master@{#74254}
-
Clemens Backes authored
After the --wasm-shared-engine flag was removed (in https://crrev.com/c/1864935), there is no point any more in holding the wasm engine in a shared_ptr. The engine is initialized once for the whole process, and only deallocated during global tear down. R=jkummerow@chromium.org Bug: v8:11384 Change-Id: Id8e96eaecfcab8b44842ec323c94529e9c5a5e25 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2853589Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#74253}
-
Dominik Inführ authored
This CL adds the new AllocationTypes kSharedOld and kSharedMap for the allocation of objects in the shared heap. An Isolate can be converted into a shared isolate with Isolate::UseAsSharedIsolate(). Client isolates can then be attached to the shared isolate. Bug: v8:11708 Change-Id: Ie2ed30b83b404e01e6f6079c5a4bdaa9302e8004 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2850709Reviewed-by: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#74252}
-
Dan Elphick authored
Moves the v8_check_header_includes part of v8_base_without_compiler into a separate v8_source_set that depends either directly or transitively on every rule containing a header file. Bug: v8:7330 Change-Id: I38bf4d62b514b3bede19c0180fbf436957a75391 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2854752 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#74251}
-
Georg Neis authored
The exception concerning type None actually seems avoidable and can cause issues with incomplete nodes remaining in the graph. Bug: chromium:1202312, chromium:1202625 Change-Id: I89062715e7f640c66b3f7cdca249db8cde768f29 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2850917 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#74250}
-
Benedikt Meurer authored
Previously we'd allow to replace the source of functions that are on the current execution stack under certain conditions, but this has resulted in an endless stream of bugs due to weird edge cases, and so we're now limiting LiveEdit to functions that don't have any activation (including not a suspended generator / async function activation). We might eventually add the ability to LiveEdit functions with activations and have them "upgrade upon next invocation", but that doesn't seem to be an extremely important use case right now. Fixed: chromium:1195927 Change-Id: I87a45ba4d0ddcfbf867bd4e73738d76b2d789e04 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2846892 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#74249}
-
Jochen Eisinger authored
When the embedder uses microtask scopes to control microtask execution, we check in the V8 API that there's always a microtask scope on the stack when entering V8. However, a microtask might call into the embedder which in turn can call into V8, so we have to put a fake scope on the stack before executing microtasks to avoid hitting the check. Bug: chromium:728583 Change-Id: I99bcbcca26eaaac827d0ec09064044f616fb9efc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2853597 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#74248}
-
Jakob Gruber authored
This reverts commit 317462be. Reason for revert: Landed prematurely. Original change's description: > [compiler] Make BigInts bg-serialized > > BigInts are immutable after initialization, thus an acquire-release > synchronization point is sufficient to read safely from the background > thread. This CL introduces the `length` field as that sync point. > > Bug: v8:7790 > Change-Id: I977f30836b311c3851896dd29e708f78a090f547 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2854745 > Auto-Submit: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Michael Stanton <mvstanton@chromium.org> > Commit-Queue: Michael Stanton <mvstanton@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74245} Tbr: mvstanton@chromium.org Bug: v8:7790 Change-Id: I0fab1a8e161c75267aead3735708e26620686fa6 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2854749 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#74247}
-