- 29 Jun, 2018 20 commits
-
-
Sergiy Byelozyorov authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/8e3406c..b79f5b5 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/9c9fd97..0dd5c6f Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/e2d6bbc..f76f0b4 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/ae1f033..a19649b Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/de629a4..dec27d7 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I5721136b50509762c2b22a0782b9fbfd370fbde5 Reviewed-on: https://chromium-review.googlesource.com/1121079Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#54117}
-
Aseem Garg authored
This CL adds simd select, addHoriz, shuffle, anyTrue and all true to the interpreter. It also gets rid of SIMD_COMPILED_AND_LOWERED_TEST and SIMD_COMPILED_TEST macros. R=gdeepti@chromium.org BUG=v8:6020 Change-Id: I44abbcaddc3223a95c79ccc65ae9c6bf1a911c5d Reviewed-on: https://chromium-review.googlesource.com/1119258 Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#54116}
-
Rodrigo Bruno authored
This is a reland of 6b810dad Original change's description: > [heap] Updated spaces Verify to check external memory count. > > Bug: chromium:845409 > Change-Id: Ieb690f2d6ed699f306f1ff351cb5f62d9e2db860 > Reviewed-on: https://chromium-review.googlesource.com/1114820 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Cr-Commit-Position: refs/heads/master@{#54035} Bug: chromium:845409 Change-Id: I71576bd397ca70d9ce76de279c2d9d1fa5a70596 Reviewed-on: https://chromium-review.googlesource.com/1120365Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Cr-Commit-Position: refs/heads/master@{#54115}
-
Rodrigo Bruno authored
This reverts commit 5863c0b6. Reason for revert: Breaks GPU bots (https://ci.chromium.org/p/v8/builders/luci.v8.ci/Mac%20V8%20FYI%20Release%20(Intel)/1648) Original change's description: > [heap] Added External Strings to external memory accounting. > > Bug: chromium:845409 > Change-Id: I3fe2b294f6e038d77787cf0870d244ba7cc20550 > Reviewed-on: https://chromium-review.googlesource.com/1118164 > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54110} TBR=ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org,rfbpb@google.com Change-Id: I77787df6aef2efec95c79714d1baf43feeb8a27e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:845409 Reviewed-on: https://chromium-review.googlesource.com/1120265Reviewed-by:
-
Clemens Hammacher authored
Liftoff needs to emit the same code, thus move it to a place where it can be reused. Also, switch the _MSC_VER switch to V8_OS_WIN. It is unclear if _MSC_VER would also be set in clang. V8_OS_WIN seems to fit better. Drive-by: Reorder the code to save one jmp in the loop (loop inversion). R=mstarzinger@chromium.org Bug: v8:7908, v8:6600 Change-Id: Ia76aa4dad3f96e179a9daad8c1551b1aab499878 Reviewed-on: https://chromium-review.googlesource.com/1120174 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#54113}
-
Hannes Payer authored
Bug: chromium:829771 Change-Id: I0e3f81b14d971d077afba2f4065e229b99948808 Reviewed-on: https://chromium-review.googlesource.com/1119687Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: Ia5f1d52df1b2ebbe4ea4d38464fc59b0d128426d Reviewed-on: https://chromium-review.googlesource.com/1119924Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#54111}
-
Rodrigo Bruno authored
Bug: chromium:845409 Change-Id: I3fe2b294f6e038d77787cf0870d244ba7cc20550 Reviewed-on: https://chromium-review.googlesource.com/1118164 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by:
-
Simon Zünd authored
This CL fixes the NumberDictionary fast-path in Array.p.sort, when storing to a read-only property that was never read from. R=jgruber@chromium.org Bug: v8:7907 Change-Id: I2b772fb5b1619a94a7d239ba4417ecb7902a167c Reviewed-on: https://chromium-review.googlesource.com/1119910 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#54109}
-
Rodrigo Bruno authored
This is a reland of 9072bef0 Original change's description: > Reland "[heap] Added per-page array buffer accouting (external memory)." > > This is a reland of d4792e8f > > Original change's description: > > [heap] Added per-page array buffer accouting (external memory). > > > > Bug: chromium:845409 > > Change-Id: Ibc568cdc501edf5d84d9c6379aff58be069369af > > Reviewed-on: https://chromium-review.googlesource.com/1114602 > > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#54028} > > Bug: chromium:845409 > Change-Id: I6b11d7f66313bcbcc31be9217c1b780cf3eaee99 > Reviewed-on: https://chromium-review.googlesource.com/1116638 > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54066} Bug: chromium:845409 Change-Id: Icff4e2a2b974942f73f5e6bb0bfd6ee8655e8ce7 Reviewed-on: https://chromium-review.googlesource.com/1119985Reviewed-by:
-
Clemens Hammacher authored
Since the wire bytes are now stored on the C++ heap, referenced directly from the {NativeModule}, there is no need any more for the additional copy in the {CompilationState}. R=mstarzinger@chromium.org Bug: v8:7868 Change-Id: I3ca25981b37bc14037a83a199354b70b4e52f8c7 Reviewed-on: https://chromium-review.googlesource.com/1118886 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Clemens Hammacher authored
R=mstarzinger@chromium.org Bug: v8:7754 Change-Id: I0cbd3e82a865aa2e52019057cea796cd6a8b17e2 Reviewed-on: https://chromium-review.googlesource.com/1118560 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Just a refactoring to make clear that we are talking about function names. Note that there are also names for locals inside functions, which we currently don't use. Drive-by: Remove style-guide violation by {WasmModule::names_} field. R=mstarzinger@chromium.org Bug: v8:7754 Change-Id: I9c47ea01893f128e1716be01032adfaf006ae28a Reviewed-on: https://chromium-review.googlesource.com/1118271Reviewed-by: -
jgruber authored
This change somehow got lost when relanding an earlier CL in https://crrev.com/c/1118139 Bug: v8:7891 Change-Id: I31244be136322cccfb465c24356f1d0fd5e0c6d6 Reviewed-on: https://chromium-review.googlesource.com/1119786Reviewed-by:
-
Sreten Kovacevic authored
Commit edec05ea Usage of Print function was not consistent with it's signature, which caused failures in compilation. Original commit message: `All Object::Print functions now take an Isolate* parameter. Various XX::XXPrint functions now take an Isolate if it's needed rather than calling GetIsolate(). Such method use DECL_PRINTER_WITH_ISOLATE rather than DECL_PRINTER. The _v8_internal_Print_ function (intended for use in gdb) now uses Isolate::Current() to get hold of an Isolate. Reduces the GetIsolate and GetHeap count by 9 and 5 respectively. Also removes unneeded gdb/lldb macros (along with their support functions), jfv, jfm, jda and jta, since job does the same thing.` Cr-Original-Commit-Position: refs/heads/master@{#54029} Change-Id: I5d4eb974340159ae91a50c1c2272ab195fc514ea Reviewed-on: https://chromium-review.googlesource.com/1116965Reviewed-by:
Dan Elphick <delphick@chromium.org> Reviewed-by:
Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Cr-Commit-Position: refs/heads/master@{#54103}
-
Clemens Hammacher authored
No need to go via the {ModuleEnv} in the {CompilationState}. R=mstarzinger@chromium.org Change-Id: I11ff647824ad107131ce329453b365d6ecaec7fb Reviewed-on: https://chromium-review.googlesource.com/1118561Reviewed-by: -
Clemens Hammacher authored
This reverts commit d8281a29. Reason for revert: breaks win32: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win32/14559 Original change's description: > Reland^2 "[wasm] Enable Liftoff by default on ia32 and x64" > > This is a reland of 20f33823. > The flakes that lead to the revert are hopefully fixed with > https://crrev.com/c/1118171. > > Original change's description: > > [wasm] Enable Liftoff by default on ia32 and x64 > > > > R=titzer@chromium.org, hablich@chromium.org > > > > Bug: v8:6600, chromium:787421 > > Change-Id: Ia8ae56ddef3b27b0721d5a66ff19abe098a2c6ca > > Reviewed-on: https://chromium-review.googlesource.com/1109899 > > Reviewed-by: Ben Titzer <titzer@chromium.org> > > Reviewed-by: Michael Hablich <hablich@chromium.org> > > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#53965} > > TBR=titzer@chromium.org, hablich@chromium.org > > Bug: v8:6600, chromium:787421 > Change-Id: Icfc6f5c7701f18891ede34edb2bc22a7c01c8d6d > Reviewed-on: https://chromium-review.googlesource.com/1118485 > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54099} TBR=titzer@chromium.org,hablich@chromium.org,clemensh@chromium.org Change-Id: I0caa20c70ab18a8da4665b565d35801c3cf03fed No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6600, chromium:787421 Reviewed-on: https://chromium-review.googlesource.com/1119885Reviewed-by:
-
Michael Hablich authored
This reverts commit 9072bef0. Reason for revert: Speculative revert because of https://chromium-review.googlesource.com/c/chromium/src/+/1118280 Original change's description: > Reland "[heap] Added per-page array buffer accouting (external memory)." > > This is a reland of d4792e8f > > Original change's description: > > [heap] Added per-page array buffer accouting (external memory). > > > > Bug: chromium:845409 > > Change-Id: Ibc568cdc501edf5d84d9c6379aff58be069369af > > Reviewed-on: https://chromium-review.googlesource.com/1114602 > > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#54028} > > Bug: chromium:845409 > Change-Id: I6b11d7f66313bcbcc31be9217c1b780cf3eaee99 > Reviewed-on: https://chromium-review.googlesource.com/1116638 > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54066} TBR=ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org,rfbpb@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:845409 Change-Id: I818e24d236d93a4645d1532b666056f89156eb86 Reviewed-on: https://chromium-review.googlesource.com/1119825Reviewed-by:
Michael Hablich <hablich@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#54100}
-
Clemens Hammacher authored
This is a reland of 20f33823. The flakes that lead to the revert are hopefully fixed with https://crrev.com/c/1118171. Original change's description: > [wasm] Enable Liftoff by default on ia32 and x64 > > R=titzer@chromium.org, hablich@chromium.org > > Bug: v8:6600, chromium:787421 > Change-Id: Ia8ae56ddef3b27b0721d5a66ff19abe098a2c6ca > Reviewed-on: https://chromium-review.googlesource.com/1109899 > Reviewed-by: Ben Titzer <titzer@chromium.org> > Reviewed-by: Michael Hablich <hablich@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53965} TBR=titzer@chromium.org, hablich@chromium.org Bug: v8:6600, chromium:787421 Change-Id: Icfc6f5c7701f18891ede34edb2bc22a7c01c8d6d Reviewed-on: https://chromium-review.googlesource.com/1118485Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/5fc0186..8e3406c Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/d96c633..e2d6bbc Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/b3853af..ae1f033 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I27e7412d84723d40d045e94ba87e9a36e9fd6373 Reviewed-on: https://chromium-review.googlesource.com/1119647 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
-
- 28 Jun, 2018 20 commits
-
-
Bill Budge authored
- Adds some unit tests for InstructionSelector::TryMatch* methods. - Adds a TryMatchIdentity method. We should detect identity shuffles and emit no code in that case. Bug: v8:6020 Change-Id: I5dea84738bf87db7112eb7d19f91b1e6b20811c7 Reviewed-on: https://chromium-review.googlesource.com/1116058 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#54097}
-
Caitlin Potter authored
When storing an indexed property in a typed array, it's necessary to convert the value to a Number (or to a Bigint) before performing the bounds check, per https://tc39.github.io/ecma262/#sec-integerindexedelementset. This CL adds appropriate type conversions in Object::SetPropertyInternal (which technically is reached after the bounds check has already occurred, but this isn't observable yet --- In the future, once OOB accesses on TypedArrays actually throw, this will need to be refactored again), and in StoreFastElementStub, and ElementsTransitionAndStoreStub (via CSA::EmitElementStore). The change was not necessary in TurboFan, as JSNativeContextSpecialization already performs the value conversion before the boundscheck. The result is some fixed test262 tests, and some new test coverage for this behaviour in mjsunit. BUG=v8:7896, v8:5327 R=neis@chromium.org, jkummerow@chromium.org, gsathya@chromium.org Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ibe6bec24c72ef6a4fd3e77d5bcafa03737f4c5e3 Reviewed-on: https://chromium-review.googlesource.com/1117372 Commit-Queue: Caitlin Potter <caitp@igalia.com> Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#54096}
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:857179 Change-Id: I6bbaa2601d62d303391d082a2ae1dff8d3c6e2b8 Reviewed-on: https://chromium-review.googlesource.com/1118562 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
The flake is hopefully fixed with https://crrev.com/c/1118171. R=titzer@chromium.org Bug: v8:7879 Change-Id: I67ac9a447cbf8a99dfc612e84b3e381cc86fa643 Reviewed-on: https://chromium-review.googlesource.com/1118381Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54094}
-
Ben Smith authored
Supporting postMessage from WebAssembly.Module requires implementing some logic in the ValueSerializer and ValueDeserializer delegates. This change implements some simple logic for d8. This change also fixes a DCHECK that occurs when sending a shared WebAssembly.Memory object to two Workers. Bug: chromium:857049 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Idddb23a48175c7175967af3fbc03d8572452a069 Reviewed-on: https://chromium-review.googlesource.com/1117871Reviewed-by:
-
Clemens Hammacher authored
We should only cancel asynchronous compilation jobs for the isolate which is being recycled. R=titzer@chromium.org Bug: chromium:854755 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I31d6c3ccb648f5465e52f4bc47c4261894458e60 Reviewed-on: https://chromium-review.googlesource.com/1118378Reviewed-by:
-
Clemens Hammacher authored
Another pair of {std::unique_ptr} and {size_t} that can be stored as one {OwnedVector}, which allows to pass it as one thing. R=mstarzinger@chromium.org Bug: v8:7754 Change-Id: Ideac0dbd390ba8147b6620daa86f0d3da6c3b609 Reviewed-on: https://chromium-review.googlesource.com/1118236 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Clemens Hammacher authored
Instead of storing both the {NativeModule} and the {WasmModule} in a {Managed} object, just store the {WasmModule} in the {NativeModule} directly. This fixes crashes that happen if the {Managed<WasmModule>} dies before the {Managed<NativeModule>}. R=mstarzinger@chromium.org Bug: chromium:854794, v8:7879, v8:7889 Change-Id: I6b11729943fe7a03d225138782655ee5dafd26a6 Reviewed-on: https://chromium-review.googlesource.com/1118171 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Théotime Grohens authored
This CL adds the newline character as a valid character in Torque strings. You can now write Print('Hello, World!\n') in Torque and it works! Change-Id: I2a1f87cfef492fedd3d24086e226d3ebaf882115 Reviewed-on: https://chromium-review.googlesource.com/1118229Reviewed-by:Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Théotime Grohens <theotime@google.com> Cr-Commit-Position: refs/heads/master@{#54089}
-
Georg Neis authored
R=sigurds@chromium.org Bug: v8:7902 Change-Id: I0a126221ffded34cccc7db793e92d0ae22952bb4 Reviewed-on: https://chromium-review.googlesource.com/1118235Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#54088}
-
Georg Neis authored
When run locally, one times out and the other runs out of stack space. R=sigurds@chromium.org Change-Id: I7cc1aa9bb0857f12ac46baf80de18a2c5175b8b9 Reviewed-on: https://chromium-review.googlesource.com/1118231Reviewed-by:
-
Clemens Hammacher authored
This reverts commit cd5d72fd. Reason for revert: breaks TSAN: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20TSAN/21284 Original change's description: > Reland "[heap] Clear from space after garbage collection. > > Bug: chromium:829771 > Change-Id: I829b4d40bdbe1474eb7f087059be3e58b154768c > Reviewed-on: https://chromium-review.googlesource.com/1106657 > Commit-Queue: Hannes Payer <hpayer@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54082} TBR=ulan@chromium.org,hpayer@chromium.org Change-Id: I6b719266bd088f8835d2c769d471c8872256fb40 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:829771 Reviewed-on: https://chromium-review.googlesource.com/1118298Reviewed-by:
-
Clemens Hammacher authored
R=mstarzinger@chromium.org Bug: chromium:856938 Change-Id: I57699de23b5c35a531c7601fd14a91f075abb0da Reviewed-on: https://chromium-review.googlesource.com/1117182 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This CL removes the friendship between {NativeModule} and {NativeModuleSerializer}/{NativeModuleDeserializer}. Instead, it adds a new public method ({AddDeserializedCode}) which is being called from the deserializer. Drive-by: Unify the argument order to {AddCode}, {AddOwnedCode} and {WasmCode}. R=mstarzinger@chromium.org Bug: chromium:856938 Change-Id: I88943c90c45650e21ae6bc17395a17f86319c046 Reviewed-on: https://chromium-review.googlesource.com/1117075Reviewed-by: -
Predrag Rudic authored
This CL complements commit f2695f73 for MIPS32. That commit addressed problem for MIPS64. Original message: >ArraySpliceTorque builtin triggers generation of MIPS specific >trampolines due to its large size, and this code is not PIC >and cannot be isolate independent. > >This CL is a workaround that marks ArraySpliceTorque as >isolate dependent on MIPS64. > >Bug: v8:7882 >Change-Id: I0b5764236268c2529e149b275dcf382dab709682 >Reviewed-on: https://chromium-review.googlesource.com/1111847 >Commit-Queue: Jakob Gruber <jgruber@chromium.org> >Reviewed-by: Michael Stanton <mvstanton@chromium.org> >Reviewed-by: Jakob Gruber <jgruber@chromium.org> >Cr-Commit-Position: refs/heads/master@{#53968} Bug: v8:7882 Change-Id: Iffdfab673781cca1eb14d11428ffcf7a01c21f27 Reviewed-on: https://chromium-review.googlesource.com/1117186 Commit-Queue: Sreten Kovacevic <sreten.kovacevic@mips.com> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#54083}
-
Hannes Payer authored
Bug: chromium:829771 Change-Id: I829b4d40bdbe1474eb7f087059be3e58b154768c Reviewed-on: https://chromium-review.googlesource.com/1106657 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Ross McIlroy authored
Merges DebugInfo field into the function_identifier field, storing the function identifier in the DebugInfo. Also moves some debugging_hints bits to the SFI flags, and others to the DebugInfo. Finally, changes the logic to store debugger patched bytecode array on the SFI instead of the DebugInfo, simplifying the logic in the InterpreterEntryTrampoline. BUG=chromium:818642,chromium:783853 TBR=hpayer@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: If440080c0f08fac4fb96f5e18dcc0eb9b86d4821 Reviewed-on: https://chromium-review.googlesource.com/1115819 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#54081}
-
jgruber authored
This is a reland of 7a0d6a50 Original change's description: > [build] Disable slow asserts for v8_enable_fast_mksnapshot > > Slow asserts double the time spent in mksnapshot. While we want them > enabled on our bot builds, local builds should be fast and don't > necessarily need them. > > This also adds v8_enable_fast_mksnapshot as default in gm.py. > > Bug: v8:7891,v8:6688 > Change-Id: I5ab1491f3396c4351de30dbbb80a81e2242c5db9 > Reviewed-on: https://chromium-review.googlesource.com/1116552 > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54074} TBR=jkummerow@chromium.org Bug: v8:7891, v8:6688 Change-Id: I3b1e80b3ca156b7d571ebc7f04e341f0ba716691 Reviewed-on: https://chromium-review.googlesource.com/1118139Reviewed-by:
-
jgruber authored
The multi-snapshot feature is only used on bots, where we need the ability to execute tests with/without mitigations controllable through a runtime flag. This disables the flag by default and only enables it on bot configs. Note: standard single-snapshot builds silently use the available snapshot regardless of the value of --untrusted-code-mitigations. Bug: v8:7891,v8:6688 Change-Id: I0d1a91e5c1c17b4d91b42d176b50ea44d2128d48 Reviewed-on: https://chromium-review.googlesource.com/1117687 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#54079}
-
Clemens Hammacher authored
We pass the {WasmModule} by non-const pointer and by non-const reference a lot. This violates the style guide, and adds the risk of accidentally modifying it. This CL makes the {WasmModule} const during compilation and instantiation. R=mstarzinger@chromium.org Bug: v8:7754 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ie1878322828b63284b341d97da595e8e91dd4f51 Reviewed-on: https://chromium-review.googlesource.com/1117194Reviewed-by:
-
