Commit cbd5e30d authored by Sreten Kovacevic's avatar Sreten Kovacevic Committed by Commit Bot

[mips] Port: `[explicit isolates] Pass Isolate to Object::Print`

Commit edec05ea

Usage of Print function was not consistent with it's signature,
which caused failures in compilation.

Original commit message:

`All Object::Print functions now take an Isolate* parameter. Various
XX::XXPrint functions now take an Isolate if it's needed rather than
calling GetIsolate(). Such method use DECL_PRINTER_WITH_ISOLATE rather
than DECL_PRINTER.

The _v8_internal_Print_ function (intended for use in gdb) now uses
Isolate::Current() to get hold of an Isolate.

Reduces the GetIsolate and GetHeap count by 9 and 5 respectively.

Also removes unneeded gdb/lldb macros (along with their support
functions), jfv, jfm, jda and jta, since job does the same thing.`

Cr-Original-Commit-Position: refs/heads/master@{#54029}
Change-Id: I5d4eb974340159ae91a50c1c2272ab195fc514ea
Reviewed-on: https://chromium-review.googlesource.com/1116965Reviewed-by: 's avatarDan Elphick <delphick@chromium.org>
Reviewed-by: 's avatarIvica Bogosavljevic <ivica.bogosavljevic@mips.com>
Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com>
Cr-Commit-Position: refs/heads/master@{#54103}
parent b0820c45
......@@ -478,7 +478,7 @@ void MipsDebugger::Debug() {
Object* obj = reinterpret_cast<Object*>(value);
os << arg1 << ": \n";
#ifdef DEBUG
obj->Print(os);
obj->Print(sim_->isolate_, os);
os << "\n";
#else
os << Brief(obj) << "\n";
......
......@@ -423,7 +423,7 @@ void MipsDebugger::Debug() {
Object* obj = reinterpret_cast<Object*>(value);
os << arg1 << ": \n";
#ifdef DEBUG
obj->Print(os);
obj->Print(sim_->isolate_, os);
os << "\n";
#else
os << Brief(obj) << "\n";
......
......@@ -202,7 +202,7 @@ TEST(jump_tables4) {
Handle<Code> code =
isolate->factory()->NewCode(desc, Code::STUB, Handle<Code>());
#ifdef OBJECT_PRINT
code->Print(std::cout);
code->Print(isolate, std::cout);
#endif
auto f = GeneratedCode<F1>::FromCode(*code);
for (int i = 0; i < kNumCases; ++i) {
......@@ -268,7 +268,7 @@ TEST(jump_tables5) {
Handle<Code> code =
isolate->factory()->NewCode(desc, Code::STUB, Handle<Code>());
#ifdef OBJECT_PRINT
code->Print(std::cout);
code->Print(isolate, std::cout);
#endif
auto f = GeneratedCode<F1>::FromCode(*code);
for (int i = 0; i < kNumCases; ++i) {
......@@ -358,7 +358,7 @@ TEST(jump_tables6) {
Handle<Code> code =
isolate->factory()->NewCode(desc, Code::STUB, Handle<Code>());
#ifdef OBJECT_PRINT
code->Print(std::cout);
code->Print(isolate, std::cout);
#endif
auto f = GeneratedCode<F1>::FromCode(*code);
for (int i = 0; i < kSwitchTableCases; ++i) {
......@@ -1129,7 +1129,7 @@ static GeneratedCode<F4> GenerateMacroFloat32MinMax(MacroAssembler* masm) {
masm->isolate()->factory()->NewCode(desc, Code::STUB, Handle<Code>());
#ifdef DEBUG
StdoutStream os;
code->Print(os);
code->Print(masm->isolate(), os);
#endif
return GeneratedCode<F4>::FromCode(*code);
}
......@@ -1271,7 +1271,7 @@ static GeneratedCode<F4> GenerateMacroFloat64MinMax(MacroAssembler* masm) {
masm->isolate()->factory()->NewCode(desc, Code::STUB, Handle<Code>());
#ifdef DEBUG
StdoutStream os;
code->Print(os);
code->Print(masm->isolate(), os);
#endif
return GeneratedCode<F4>::FromCode(*code);
}
......
......@@ -269,7 +269,7 @@ TEST(jump_tables4) {
Handle<Code> code =
isolate->factory()->NewCode(desc, Code::STUB, Handle<Code>());
#ifdef OBJECT_PRINT
code->Print(std::cout);
code->Print(isolate, std::cout);
#endif
auto f = GeneratedCode<F1>::FromCode(*code);
for (int i = 0; i < kNumCases; ++i) {
......@@ -342,7 +342,7 @@ TEST(jump_tables5) {
Handle<Code> code =
isolate->factory()->NewCode(desc, Code::STUB, Handle<Code>());
#ifdef OBJECT_PRINT
code->Print(std::cout);
code->Print(isolate, std::cout);
#endif
auto f = GeneratedCode<F1>::FromCode(*code);
for (int i = 0; i < kNumCases; ++i) {
......@@ -433,7 +433,7 @@ TEST(jump_tables6) {
Handle<Code> code =
isolate->factory()->NewCode(desc, Code::STUB, Handle<Code>());
#ifdef OBJECT_PRINT
code->Print(std::cout);
code->Print(isolate, std::cout);
#endif
auto f = GeneratedCode<F1>::FromCode(*code);
for (int i = 0; i < kSwitchTableCases; ++i) {
......@@ -1487,7 +1487,7 @@ static GeneratedCode<F4> GenerateMacroFloat32MinMax(MacroAssembler* masm) {
masm->isolate()->factory()->NewCode(desc, Code::STUB, Handle<Code>());
#ifdef DEBUG
StdoutStream os;
code->Print(os);
code->Print(masm->isolate(), os);
#endif
return GeneratedCode<F4>::FromCode(*code);
}
......@@ -1629,7 +1629,7 @@ static GeneratedCode<F4> GenerateMacroFloat64MinMax(MacroAssembler* masm) {
masm->isolate()->factory()->NewCode(desc, Code::STUB, Handle<Code>());
#ifdef DEBUG
StdoutStream os;
code->Print(os);
code->Print(masm->isolate(), os);
#endif
return GeneratedCode<F4>::FromCode(*code);
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment