Commit f2695f73 authored by Ivica Bogosavljevic's avatar Ivica Bogosavljevic Committed by Commit Bot

MIPS64: Mark ArraySpliceTorque as isolate dependent

ArraySpliceTorque builtin triggers generation of MIPS specific
trampolines due to its large size, and this code is not PIC
and cannot be isolate independent.

This CL is a workaround that marks ArraySpliceTorque as
isolate dependent on MIPS64.

Bug: v8:7882
Change-Id: I0b5764236268c2529e149b275dcf382dab709682
Reviewed-on: https://chromium-review.googlesource.com/1111847
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: 's avatarMichael Stanton <mvstanton@chromium.org>
Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53968}
parent 81527891
......@@ -316,6 +316,13 @@ bool Builtins::IsIsolateIndependent(int index) {
// of the builtin itself (and not just the trampoline).
case kInterpreterEntryTrampoline:
return false;
#if V8_TARGET_ARCH_MIPS64
// TODO(7882): The size of ArraySpliceTorque on MIP64 is greater than 128KB,
// and this triggers generation of MIPS specific trampolines. Trampoline
// code is not PIC and therefore the builtin is not isolate independent.
case kArraySpliceTorque:
return false;
#endif
default:
return true;
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment