- 17 Nov, 2020 21 commits
-
-
Milad Fa authored
Change-Id: Ie09b35d2e2cd28996bb7ebaa54175c14a4f5cea8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2543162Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#71234}
-
Manos Koukoutos authored
Changes: - Fix read_value_type description. - Make sure read_value_type always emits an error for an invalid type. Remove checks for errors at call sites. - (Drive-by) Fix validation flags in DecodeLocals. Change-Id: I82bd8a61f0e26f39506fc6e4ab4be331dfe24ad7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2526390 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#71233}
-
Vicky Kontoura authored
This CL increases the budget for the tiering strategy of the js-to-wasm wrappers from 6 (which was initially picked at random, as the feature was experimental) to 1000 calls (which is picked based on benchmarking). The high-level rationale behind such a choice can be summarized in the following: - The generic wrapper is not that much slower than the specific wrappers, so it can handle up to some thousands of calls quite well. - After that, the generic wrapper starts lacking compared to the specific wrappers, even if compiling a specific wrapper means blocking the main thread. - Real-life applications do call exported functions thousands of times, so this is not an unrealistic choice. Bug: v8:10982 Change-Id: I143dd11e535101fd24810f63ed8b987cd03c4326 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2539913 Commit-Queue: Vicky Kontoura <vkont@google.com> Reviewed-by:
-
Leszek Swirski authored
Add a "combination" assert scope class, which combines multiple existing assert scopes. This will allow scopes with functional overlap, e.g. DisallowGarbageCollection and DisallowHeapAllocation, to share an assert type rather than rather than requiring users to remember to set both. To demonstrate this, this redefines DisallowGarbageCollection to a combination of DisallowHeapAllocation and a new DisallowSafepoints, and some of the DCHECKs checking both are simplified to only check one or the other, as appropriate. The combination classes become subclasses of the existing assert scopes, so that they can be used in their place as e.g. a function parameter, e.g. DisallowGarbageCollection can be passed to a function expecting const DisallowHeapAllocation&. As a drive-by, this also changes the per-thread assert scopes to use a bitmask, rather than a bool array, to store their per-thread data. The per-isolate scopes already used a bitmask, so this unifies the behaviour between the two. Change-Id: I209e0a56f45e124c0ccadbd9fb77f39e070612fe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2534814 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#71231}
-
Vicky Kontoura authored
This CL just updates an outdated comment. Bug: v8:10982 Change-Id: I3ae60c9bf345b50c8e6fd7ce9c19ae9d0894734e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2539911 Commit-Queue: Vicky Kontoura <vkont@google.com> Reviewed-by:
-
Leszek Swirski authored
Port the fix from https://crrev.com/c/1414858 to ia32. TL;DR, _xgetbv is a reserved name. Change-Id: I97cb90ea7d244c02326432cfbfd55419a0a9854a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2543933 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Michael Achenbach authored
This reverts commit e95e1b62. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20arm%20-%20sim%20-%20debug/23064 Original change's description: > [heap] Introduce LocalIsolate for main thread > > Add a LocalIsolate for the main thread to Isolate. This LocalIsolate is > kept alive during the whole lifetime of the Isolate. The main thread > LocalIsolate starts in the Running state in contrast to the background > thread LocalIsolates (those start in Parked). > > Code paths in Turbofan that used to create a LocalIsolate on the main > thread can now simply use the main thread LocalIsolate. > > LocalIsolate for the main thread will help in reducing differences > between the main and background threads. The goal is that the main > thread behaves more like a background thread. > > The main thread LocalIsolate should also make it simpler to share code > between main thread and background threads by using LocalIsolate for > both. > > Bug: v8:10315 > Change-Id: I7fd61d305a6fd7079e2319d75c291c1021e70018 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2509593 > Reviewed-by: Simon Zünd <szuend@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71226} TBR=ulan@chromium.org,yangguo@chromium.org,neis@chromium.org,leszeks@chromium.org,szuend@chromium.org,dinfuehr@chromium.org Change-Id: Ia70b4bfe3b8fa26bf8d6a7dc612a310b0ed54073 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10315 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2543937Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#71228}
-
Vicky Kontoura authored
This CL adds a cctest to verify that the tiering strategy for the js-to-wasm wrappers works for functions that are only indirectly exported through exported tables. Bug: v8:10982 Change-Id: I8eede14ab620dbadb75af42b78bfac88230a6dd3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2536644 Commit-Queue: Vicky Kontoura <vkont@google.com> Reviewed-by:
-
Dominik Inführ authored
Add a LocalIsolate for the main thread to Isolate. This LocalIsolate is kept alive during the whole lifetime of the Isolate. The main thread LocalIsolate starts in the Running state in contrast to the background thread LocalIsolates (those start in Parked). Code paths in Turbofan that used to create a LocalIsolate on the main thread can now simply use the main thread LocalIsolate. LocalIsolate for the main thread will help in reducing differences between the main and background threads. The goal is that the main thread behaves more like a background thread. The main thread LocalIsolate should also make it simpler to share code between main thread and background threads by using LocalIsolate for both. Bug: v8:10315 Change-Id: I7fd61d305a6fd7079e2319d75c291c1021e70018 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2509593Reviewed-by:
Simon Zünd <szuend@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Allows embedders to allocate C++ objects on the internal managed C++ heap. Bug: chromium:1056170 Change-Id: Ibd81d0fc915478a81f14e8ab12a631e442790f04 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2536642Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#71225}
-
Jakob Gruber authored
This CL enables a first batch of feedback-based optimizations in NCI code. Specifically, optimizations based on unary, binary, compare, for-in-next, and for-in-prepare feedback are now enabled. This has two main implications: 1. NCI code can now deopt. Deoptimized code is currently thrown away permanently and cannot be reused. Now that shared/cached NCI code can deopt, this leads to an interesting question of what should happen with deoptimized NCI code. The answer in this CL is to remove the cache entry (it may later be re-added). 2. Tiering up from NCI to TF still requires feedback; since NCI code, starting with this CL, no longer collects full feedback, feedback must be created in some other way. This is solved by sharing a context-independent encoding of feedback across native contexts. Feedback is shared through a new SerializedFeedback object type, essentially a byte array of serialized feedback. Currently, only smi-based feedback is shared, but map-based feedback will be added in the future. SerializedFeedback is kept in the NCI cache alongside NCI Code objects. It is created on NCI cache insertion, and deserialized upon NCI cache hits. Bug: v8:8888 Change-Id: Ic0d5fbea3aa4d3b0a165624dab9d0283b07dcee7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2531775Reviewed-by:
Mythri Alle <mythria@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
Drive-by change: Fix wrong reference to FixedRangeBodyDescriptor in implementation-visitor.cc TBR: ulan@chromium.org Change-Id: I8a1f468f35c38f5be1f4e8d1cfcc9f0fd2a16381 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2540546 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Auto-Submit: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: -
Vicky Kontoura authored
This CL just refactors the `test-run-wasm-wrappers.cc` cctest. Bug: v8:10982 Change-Id: Ib8881c97c0cf395766d9b27a68ee440850df5d59 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2534819Reviewed-by:
-
Dominik Inführ authored
When a thread gets archived, we still need to scan and update debug roots on GCs for it. Otherwise we restore stale references when the thread becomes active again. Bug: v8:11145 Change-Id: I88f4c1534e826aed222e7fb67bd82bb0a4758fab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2537691Reviewed-by:
-
John Xu authored
Bug: v8:10927 Change-Id: Icbdc0d7329ddd466e7d67a954246a35795b4dece Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2507310 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#71220}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/944fd70..c854b81 Rolling v8/third_party/aemu-linux-x64: 2_kHlztQ5lFU-IhCP021uv4v5Ms-aBhhsqtZ1V02tbIC..FwzgY9X10eGIOA-l6ukRroKmBYo1As7yOiPDRfc6PxAC Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/fd5c198..d4e6fb6 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/013c5b9..c72342c TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4b81481d65743b3ff9aba9ede13659b540d26070 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2543315Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#71219}
-
Zhi An Ng authored
all_true, any_true, bitmask, and extract_lane all replace a simd type with single scalar, so we don't need to set nullptr for the extraneous lane, and can set num_lanes to 1. So for a call node with any of the above nodes as one of its value, we were incorrectly replacing the extract lane node with 4 nodes - it should only be 1 scalar node. Drive by fix for LowerShift, it needs to check if the shift value node has replacement (e.g. if it is an extract lane node). Also we weren't setting the lowered type of a kPhi node. This can be a problem if the output of a Phi node is used by a F32x4ExtractLane and I32x4ExtractLane, which is possible (and type correct since both take v128). This will require that the output be both a float and a int, which is impossible. So fix it to Int32x4, and the uses of the phi nodes will convert appropriately. Added a test for the call node. Also tested this code by running one of our benchmarks, which exercises the Phi logic. Bug: v8:10507 Change-Id: I01a76b349ba9d0e157b64e737bdb4c70f96aa954 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2536952 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#71218}
-
Zhi An Ng authored
The current name for the operator (for printing) is "Extract lane", without an indication of the shape. Add the shape (I32x4) and sign (for I8x16 and I16x8, s or u) to the name so that it is clearer what operation it is. Change-Id: I1ab30dee5ae820c378cdef8233de1c365dd126c5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2534630Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#71217}
-
Junliang Yan authored
Change-Id: Iaea977a35ea85d561368b04ecfbd2f16693a87a9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2543311Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#71216}
-
Zhi An Ng authored
With more of scalar lowering implemented, this test can now run with lowering. The only other tests that skip lowering are prototype instructions. Bug: v8:10507 Change-Id: Ia149956d2d406b6f76eb9155765474c23b89b894 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2507317Reviewed-by:
Ben Smith <binji@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#71215}
-
Zhi An Ng authored
S128Select and S128AndNot relies on the inputs being lowered to I32x4, since they use Word32Xor, but it wasn't correctly specified. This means that by default, their lowered type was set to be the output's lowered type. If the result of these operations were used by F32x4ExtractLane, then their lowered type will be set to Float32x4, so the inputs will be lowered to Float32x4, and we get incorrect type of registers allocated. Bug: v8:10507 Change-Id: I16dc7f2dcdaf2188997ff345a6b0fd22e10b7b36 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2536953Reviewed-by:
-
- 16 Nov, 2020 19 commits
-
-
Junliang Yan authored
Change-Id: I1d342b80589bedb6365ef0c91ad156d71ecc0622 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2542982Reviewed-by:
-
Camillo Bruni authored
Bug: v8:11165, v8:10096 Change-Id: I4be596f74a231641b8032e70063f47f4776ec6a8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2539919Reviewed-by:
-
Leszek Swirski authored
It is becoming difficult to continue supporting the compiler dispatcher and background compile task unittests alongside the off-thread finalization work, so disable those tests when that flag is enabled. Bug: chromium:1011762 Change-Id: Iba9aaa29b08723afb90edc127609fef1d63ceed5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2539908 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#71211}
-
Clemens Backes authored
Just as OS::Abort, OS::ExitProcess never returns. This is a minor cleanup which is not expected to reduce binary size considerably, since we do not call this function often. It is just nice to annotate it correctly. On windows, the {TerminateProcess} call is known to not return if called on the current process. Add an {UNREACHABLE} to enforce this. R=mlippautz@chromium.org Bug: v8:11074 Change-Id: I5c079fc459685c65f932404ce536ea28ad188073 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2536634Reviewed-by: -
Tobias Tebbi authored
... to fix GCC compile failures. Change-Id: I836fb6883354b26aa33085d9a96c5d957af5c5bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2537707Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#71209}
-
Jakob Kummerow authored
- allow arrays to be allocated in LargeObjectSpace - check requested array allocation length against maximum - fix array element offsets for pointer-typed elements - fix GC handling of arrays when there are forwarding pointers - module builder: fix rtt.sub global initializer expressions - debug printing: print "UNIMPLEMENTED" instead of crashing - WasmGCTester: make some exceptions easier to diagnose Bug: v8:7748, chromium:1141376 Change-Id: Ie0281658748f3dd5e5d90d85bab78f0ea2fc3865 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2534815Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#71208}
-
Camillo Bruni authored
- Reuse DOM nodes if possible - Delay slow DOM node removal to not block the UI - Fix global time range syncing when adding timelines to the state - Use a Proxy to cache CSS colors instead of querying CSS properties on every access - Set className on newly create DOM nodes instead of adding to the classList - Use bound functions for event handlers that are added multiple times - Speed up Chunk.getBreackdown - Use CSS gradient for timeline-track chunk backgrounds, which is an order of magnitude faster than the serialised canvas approach Bug: v8:10644 Change-Id: Ie2d6d5b404f18e920c10c0a6460669fd4d0b20e8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2539947 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#71207}
-
Jakob Kummerow authored
Constant-time subtype checks are only valid for struct/array objects. Previously, the code checked for JS_FUNCTION_TYPE to specifically catch funcrefs. With this patch, anything except struct/array objects is excluded, in preparation for anyref support. Additionally, this dynamic check is now only emitted when static type information is not enough. Bug: v8:7748 Change-Id: Ia2920902ee1d9e9714a4b8297a963ba3d6d3312a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2536290 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Frank Emrich authored
This CL adds partial support for objects whose slow mode dictionaries are OrderedNameDictionaries. This is the case for all slow mode objects if V8_DICT_MODE_PROTOTYPES is enabled. In particular, this part deals with those runtime functions called by the DefineClass builtin, located in literal-objects.cc and runtime-classes.cc. Bug: v8:7569 Change-Id: Ie4c479fd6f8872eea9f190590408a4aafd1c77e6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2523321 Commit-Queue: Frank Emrich <emrich@google.com> Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Leszek Swirski authored
This resolves issues building gcmole under LLVM 8.0.0 with gcc 10 (see https://bugs.gentoo.org/708730). Change-Id: I932def25fb3cc841cf21414a513fbe2a2fa8a8dc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2539946Reviewed-by:
Tamer Tas <tmrts@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#71204}
-
Michael Achenbach authored
No-Try: true Bug: chromium:1142437 Change-Id: Icba7a00ac996c0f81a67e0141496829e657a9a64 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2539917 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Auto-Submit: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Omer Katz authored
Ports updates to weak container handling in blink performed in [1]. These changes were needed to resolve timeouts for android. See [1] for more details. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2516363 Bug: chromium:1056170 Change-Id: I2b2c451d494438a37886a3c2bc73481bc9228664 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2538211 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
As Wasm code increasingly needs to deal with various HeapObject subtypes, the WasmGraphAssembler is a good place to consolidate common helper methods like LoadMap or LoadFixedArrayElement. This is clearly inspired by the CodeStubAssembler, and there is clearly room for much more refactoring in this direction. This CL does not intend to change any functionality. Bug: v8:11074 Change-Id: I1b768c5791bde7041bc9f41a3069afb1844cdb46 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2532083Reviewed-by:
-
Igor Sheludko authored
... and use Name::hash() where the hash is expected to be computed. In particular, when we are dealing with internalized strings or symbols. Bug: v8:11074 Change-Id: Ida22f134fee0ddf2c9b962d1bcca6aa0b632af5f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2529451Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Georg Neis authored
Split globals.js into two parts, one being skipped on NCI due to assertions about optimization status. Change-Id: Ifc572526d9c6aed369802a65d12c4456cde65ce0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2539909 Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
-
Georg Neis authored
Main changes: - Remove the kUninitialized and kInvalidated cell type aliases. They were confusing because their meaning depended on the current value in the cell. I think kUninitialized was obsolete anyways. - Remove a DCHECK from the compiler. The property that was asserted, while true, is irrelevant. - Remove the obsolete function GetConstantType. The only left use was in the object printer, but it's pointless there because we already print the value anyways. Change-Id: Ic718c8ba39aeb5bf18f588535dfb755a023cb144 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2536647Reviewed-by:
-
Leszek Swirski authored
Add a requirement to String::GetChars that we either have a string access lock, or a string access lock is not needed. This prevents us from reading strings during internalization that may be in the middle of being made external. To avoid taking the lock too often when known to be unnecessary (e.g. for strings that were only just created), there's now a static SharedStringAccessGuardIfNeeded::NotNeeded(). This is hopefully ugly enough that it's used sparingly. One fix required for this is to enter the Isolate when tearing down IsolateData in inspector tests -- this is so that the V8Inspector instance being torn down will see the current Isolate and be able to verify its thread id against the current thread. Bug: chromium:1011762, chromium:1148680 Change-Id: Ic5d29c1b066ebae5a351c7b4bb116b9b1bf61889 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2536465 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#71197}
-
Marja Hölttä authored
- Add tests comparing super property access to normal property access - Shift the work so that the framework takes less time and the thing we're trying to measure takes more time. - Optimize / disable the optimization for the target function, not the whole test framework. - Reduce the amount of boilerplate code in the tests. Bug: v8:9237 Change-Id: Idde133298c9b8ffb3d49945ef9c67f5039634598 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2536635Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#71196}
-
Almothana Athamneh authored
Bug: chromium:1148779 Change-Id: Ied690b7b2cf6286d497179cab36dce90b6941d12 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2536645Reviewed-by:
-
