- 22 Jun, 2021 18 commits
-
-
Dan Elphick authored
Now that SimpleStringBuilder is only used in conversions.cc, it can be moved there making it easier to assess its safety and limit further use of this potentially unsafe API. (Additionally unused methods Reset and size are removed). Bug: v8:11917 Change-Id: I0515fe4f34bb8f7e7ea464b75394fa3d03939af1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2978253 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#75300}
-
Georg Neis authored
It was not in sync with the optimization, which relies on inspecting up the length and name fields even for bound functions. To make a now meaningful serializer test actually pass, I have to to make some changes to the test setup. I'm also moving the function name and length index constants from JSFunction to JSFunctionOrBoundFunction for clarity. TBR=marja@chromium.org Bug: v8:7790 Change-Id: I36dd3c80996ccb53810c7ea9bfceb5c84ffd60ab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2972919 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#75299}
-
Dan Elphick authored
StringBuilder and its base class SimpleStringBuilder aren't very safe and are a potential source of memory leaks or double-frees. This removes the StringBuilder class and converts all of its usages to use the standard library. (As a drive-by, this converts std::ostream* to std::ostream& which is more idiomatic C++). Bug: v8:11917 Change-Id: I0eaf9d60cf49836e65bb28f0e114b33ef8103a61 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2978252 Auto-Submit: Dan Elphick <delphick@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#75298}
-
Mike Stanton authored
If a test specifies --stress-concurrent-inlining it shouldn't be run in predictable mode, since it is depending on some concurrent behavior (a race condition) between threads. Bug: v8:11907 Change-Id: I027eed056689a8ee62675fce7dfa0701d202e970 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2975298Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#75297}
-
Clemens Backes authored
After a series of CLs per component, this removes all remaining NOLINT annotations that my script identified as not needed (because removing them does not cause a presubmit error). R=mlippautz@chromium.org, jkummerow@chromium.org, leszeks@chromium.org R=cbruni@chromium.org Bug: v8:11879 Change-Id: Ia403c23588a0c2871b987931f6c26f85821e9e9c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2972733Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#75296}
-
Manos Koukoutos authored
We can get rid of this by deferring adding a new global to the module's globals, and using the current size of globals to determine allowed global indices. Bug: v8:11895 Change-Id: Ide80eab2de4abdbab96a7298acf3665599c394ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2972908 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#75295}
-
Georg Neis authored
Various field dependencies assume that the receiver map and the field owner map agree on field meta data. That's not necessarily true when the receiver map is already deprecated. We should skip over deprecated maps. - Fix a bug in SerializerForBackgroundCompilation. It used to process even deprecated maps. - Fix a bug in FilterRelevantReceiverMaps. It used to store the original map rather than the new version. - Turn some compilation dependency DCHECKs into CHECKs. - CHECK in MapRef::FindFieldOwner that the map is not deprecated. While there might be valid use cases for calling the underlying Map::FindFieldOwner on a deprecated map, we never want to do that in the compiler. Note that we skip any deprecated maps in JSNativeContextSpecialization's ReduceNamedAccess. That's why I believe the issue could only be observed with --concurrent-inlining and only in the form of a failing DCHECK. Bug: chromium:1221812, v8:7790 Change-Id: I998b4ce1954be01eb6e0feb491ccc6b8306c685f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2976655 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#75294}
-
Al Muthanna Athamina authored
Bug: v8:11656 No-Try: true Change-Id: I60bdedc1eb7fc04a3ed1f09bf02fbddffa05c4dd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2975861 Auto-Submit: Almothana Athamneh <almuthanna@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#75293}
-
Manos Koukoutos authored
- Add an expected type argument in DecodeWasmInitExprForTesting. This eliminates the need to check for kWasmVoid in consume_init_expr. - Invoke StartDecoding() to initialize module in DecodeWasmInitExprForTesting. - Pass the current module to DecodeInitExprForTesting. - Adjust tests. Bug: v8:11895 Change-Id: I13b71b68a2011bf08742701cb9dd986afd6e55f8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2972907 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#75292}
-
Victor Gomes authored
1. Adds the flag --sparkplug-on-heap 2. Creates OnHeapAssemblerBuffer 3. Generates code on heap (but still relocates later) 4. Provides Assembler::IsOnHeap function Bug: v8:11872 Change-Id: I6223bf27a5fbcfb5f94f3462b951443b35273661 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2949097 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#75291}
-
Sara Tang authored
Feedback suggests that it would be easier to trace minified JS code if line numbers were included in the ETW JIT events, so I added them. Bug: v8:11043 Change-Id: I1660c695db2e4659184b2b679839dafe256fb3ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2971625Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Sara Tang <sartang@microsoft.com> Cr-Commit-Position: refs/heads/master@{#75290}
-
Clemens Backes authored
This is a reland of 0f90a2aa. The issue was inverted destructor order between WasmCodeManager and WasmEngine. WasmEngine has to be destructed first, because it contains a barrier to ensure that background compile threads finished before global state is being destructed. Original change's description: > [wasm] Provide a global WasmCodeManager > > The WasmCodeManager was part of the WasmEngine so far, but there is only > exactly one WasmEngine. Hence we can pull it out, and also remove the > pointer in the WasmCodeAllocator. > > The argument passed from the single constructor call is now inlined in > the constructor itself. > > Drive-by: Replace "GetPlatformPageAllocator()->CommitPageSize()" by just > "CommitPageSize()". > > R=jkummerow@chromium.org > > Bug: v8:11879 > Change-Id: I6c0e74cea308f5806d1aa479945d90b6ef8d1613 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2972909 > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75270} Bug: v8:11879 Change-Id: I0eaa2395f5c1e30f3f7303c5f3df70c227b74d3d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2975859 Auto-Submit: Clemens Backes <clemensb@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#75289}
-
Michael Achenbach authored
This will download a prebuilt bazel on Ubuntu bots if gclient variable download_prebuilt_bazel is set. The currently pinned version is: 5.0.0-pre.20210604.6. This is planned to only run on specific bots that use a new recipe for building with bazel: https://crrev.com/c/2972749 Bug: v8:11912 Change-Id: I8ff405fc03bfede4762bf4e8577cb1feab56f7c4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2972918 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by: Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/master@{#75288}
-
Maya Lekova authored
This reverts commit 3296de2f. Reason for revert: Blocks the roll - https://chromium-review.googlesource.com/c/chromium/src/+/2970676 Original change's description: > [sparkplug] Trigger compilation when a FBV exists > > We were gating baseline compilation on FBV allocation, but in some > cases, the feedback vector may be allocated eagerly (notably, if we are > logging function events). Instead, unconditionally try baseline > compilation after ensuring the feedback vector exists. > > Bug: v8:11420 > Change-Id: I1264a1d541a74d4eccb5caf65c360ac23836a1a8 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2953161 > Auto-Submit: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Patrick Thier <pthier@chromium.org> > Reviewed-by: Patrick Thier <pthier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75242} Bug: v8:11420 Change-Id: Ia9524e3a57eda7ec069f29652acc7593bf680509 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2976654 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#75287}
-
Maya Lekova authored
This reverts commit a93293d9. Reason for revert: Need to revert a dependency which is blocking the roll - https://chromium-review.googlesource.com/c/v8/v8/+/2953161 Original change's description: > [sparkplug] Trigger compilation only when we don't have baseline data > > If we trigger baseline compilation unconditionally on bytecode budget > interrupt after we have compiled the function with sparkplug already, we > will arm back-edges for OSR unconditionally. Since the OSR arming > mechanism is the same for Sparkplug and TurboFan, this means that we > will immediately arm back-edges for OSR to TurboFanned code. > > Bug: v8:11656 > Change-Id: Ic8e5d1899a3a203321e063ada474d39f2627ea88 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2972922 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Patrick Thier <pthier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75285} Bug: v8:11656 Change-Id: I2e2910f8882314260ff70a3c996ef74903b6851b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2976653 Auto-Submit: Maya Lekova <mslekova@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#75286}
-
Patrick Thier authored
If we trigger baseline compilation unconditionally on bytecode budget interrupt after we have compiled the function with sparkplug already, we will arm back-edges for OSR unconditionally. Since the OSR arming mechanism is the same for Sparkplug and TurboFan, this means that we will immediately arm back-edges for OSR to TurboFanned code. Bug: v8:11656 Change-Id: Ic8e5d1899a3a203321e063ada474d39f2627ea88 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2972922Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/master@{#75285}
-
Benedikt Meurer authored
When looking up the break index for a given source position, default to the last break index if there is neither a precise match nor a breakable position after the source position (in which case we still pick the first candidate). Fixed: chromium:1222065 Bug: chromium:901819, chromium:782461, chromium:1222060 Change-Id: I10d6a086b2d5fadc9e6dca0c49ed4187eb0359ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2972917 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Reviewed-by: Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/master@{#75284}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e03cfed..69cba92 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/466954e..7bff39b Rolling v8/buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx/+log/8fa8794..79a2e92 Rolling v8/third_party/aemu-linux-x64: PN9-ZWJ3VamzkSeIVWLhS3mXDEVLPX86Ht5EEDH1O-EC..KN9a-2MYhLQ9kDLdCOca4xZcBjrhMIzoD4ReyO0u95IC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/cb63922..2ba6b1f Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/473499b..b714c17 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/03ff857..2d4e9fd TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I1c17166b07efae9631726b57f27260997571f120 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2977585Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#75283}
-
- 21 Jun, 2021 18 commits
-
-
Bill Budge authored
This reverts commit 24c626c1. Reason for revert: Blocks V8 roll into Chromium (changed error messages cause tests to fail): https://ci.chromium.org/p/chromium/builders/try/linux-rel/724109? Original change's description: > Improve error messages for property access on null/undefined > > Only print the property name when accessing null/undefined if we can > convert it to a string without causing side effects. > If we can't, omit the property name in the error message. > This should avoid confusion when the key is an object with toString(). > E.g. undefined[{toString:()=>'a'}] doesn't print 'read property [object > Object]' anymore, which was misleading since the property accessed would > be 'a', but we can't evaluate the key without side effects. > > Bug: v8:11365 > Change-Id: If82d1adb42561d4851e2bd2ca297a1c71738aee8 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2960211 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Commit-Queue: Patrick Thier <pthier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75250} Bug: v8:11365 Change-Id: Ic63f34033254f55b3871041633d84ea48586a75d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2977374 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#75282}
-
Milad Fa authored
This enables running some of the new instructions on the simulator including vcgd and vclgd. Change-Id: Icd1c6ced124aec8608dece855f85ba350c4247fd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2976027Reviewed-by: Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#75281}
-
Frank Tang authored
This is a reland of dd8845cd Original change's description: > [intl] Improve test coverage of "best fit" localeMatcher > > https: //docs.google.com/document/d/1cPGfiihn76yj2iAomKcspPFyLLcnk3WkCiqceBQPQyk/edit#heading=h.cc9tt7s0iwsd > Bug: v8:7051 > Change-Id: I8c35e859062c5bdb009334dd1b725751e6df2123 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2965481 > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75228} Bug: v8:7051 Change-Id: I9af13b8fdf7ec3de2ac24050074d13fcdef981c7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2973648Reviewed-by: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#75280}
-
Leszek Swirski authored
- Fix inline script line nos * Change the map source pos panel to a table 3. Fix script sorting to not crash on missing name Change-Id: I250c830f4be5f734a9489622ce162615bf80aab7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2964606 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#75279}
-
Nico Hartmann authored
This reverts commit 2588380d. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Arm%20-%20debug%20builder/34664/overview Original change's description: > [assembler][arm64][arm][ia32] Add more Assembler::CodeComment > > Use more code comments to better document generated assembler code. > This CL also attaches a CodeComment to FrameScope. > > Change-Id: I45afc3e4078dc161316b877fbbd1ae8bcd6e821d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2964392 > Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> > Reviewed-by: Victor Gomes <victorgomes@chromium.org> > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75277} Change-Id: I6d36535ca96133cc83b3d6194a3d53889f735499 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2972826Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#75278}
-
Camillo Bruni authored
Use more code comments to better document generated assembler code. This CL also attaches a CodeComment to FrameScope. Change-Id: I45afc3e4078dc161316b877fbbd1ae8bcd6e821d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2964392Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#75277}
-
Michaël Zasso authored
Without this, the files are ignored when V8 source is copied to another repository (for example Node.js). Change-Id: Ia1ac2d2673d13a266f2beaa1dadd93df903afd5d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2972915Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michaël Zasso <mic.besace@gmail.com> Cr-Commit-Position: refs/heads/master@{#75276}
-
Igor Sheludko authored
When v8_enable_external_code_space is enabled the Code objects are allowed only - in CodeDataContainer::code field - as uncompressed values embedded in Code instruction streams Bug: v8:11880 Change-Id: I080a678fd77a7e42c6a397e7145a640fd07d6e83 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2969828Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#75275}
-
Maya Lekova authored
This reverts commit 0f90a2aa. Reason for revert: Breaks MSAN, please see https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/38941/overview Original change's description: > [wasm] Provide a global WasmCodeManager > > The WasmCodeManager was part of the WasmEngine so far, but there is only > exactly one WasmEngine. Hence we can pull it out, and also remove the > pointer in the WasmCodeAllocator. > > The argument passed from the single constructor call is now inlined in > the constructor itself. > > Drive-by: Replace "GetPlatformPageAllocator()->CommitPageSize()" by just > "CommitPageSize()". > > R=jkummerow@chromium.org > > Bug: v8:11879 > Change-Id: I6c0e74cea308f5806d1aa479945d90b6ef8d1613 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2972909 > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75270} Bug: v8:11879 Change-Id: I110eec313762d73073f530aec7cf0be82c4db344 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2972921 Auto-Submit: Maya Lekova <mslekova@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#75274}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/d6115b1..e03cfed Rolling v8/buildtools/linux64: git_revision:7d803996740ccd587c54062750cbe04dfbc3c423..git_revision:170c2dba1e0c0299fe8c6a441caf2f2352a42ae0 Rolling v8/third_party/aemu-linux-x64: h_kO6UaQmxXGNfG0ofG4wgKw_URVHcderPkx6AlamR0C..PN9-ZWJ3VamzkSeIVWLhS3mXDEVLPX86Ht5EEDH1O-EC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/893c99a..cb63922 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/0e77445..03ff857 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Ic1579515b592206a34f25296d9e24e9d99a8e13d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2975087Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#75273}
-
Daniel Lehmann authored
Merges `NativeModuleModificationScope` (with an implementation using Intel PKU, if available, and mprotect otherwise) and `CodeSpaceWriteScope` (for Apple Silicon, where switching to RWX with mprotect is disallowed anyway, so MAP_JIT and thread-local switching must be used). Because `CodeSpaceWriteScope` sounded better (and is shorter), we kept its name (which unfortunately makes the diff a bit harder to read). R=clemensb@chromium.org CC=jkummerow@chromium.org Bug: v8:11714 Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel_ng Change-Id: Ib2a7d18e72797a725ed34b904c70769166d811dd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2972911Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Daniel Lehmann <dlehmann@google.com> Cr-Commit-Position: refs/heads/master@{#75272}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/5b75184..62937f9 Add missing trailing commas (#1182) (Dominic Hamon) https://chromium.googlesource.com/external/github.com/google/benchmark/+/62937f9 Provide helpers to create integer lists for the given ranges. (#1179) (PCMan) https://chromium.googlesource.com/external/github.com/google/benchmark/+/c932169 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org Change-Id: I81658863aa16aebb1c0f76d79bdbf6abcbd1accf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2975083Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#75271}
-
Clemens Backes authored
The WasmCodeManager was part of the WasmEngine so far, but there is only exactly one WasmEngine. Hence we can pull it out, and also remove the pointer in the WasmCodeAllocator. The argument passed from the single constructor call is now inlined in the constructor itself. Drive-by: Replace "GetPlatformPageAllocator()->CommitPageSize()" by just "CommitPageSize()". R=jkummerow@chromium.org Bug: v8:11879 Change-Id: I6c0e74cea308f5806d1aa479945d90b6ef8d1613 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2972909 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#75270}
-
Sigurd Schneider authored
The exception meta-data API created several objects in the wrong context, resulting in the exception context being kept alive for too long. Bug: chromium:1221089 Change-Id: I02aece4e10d9bd559d49f98fe1c3e44a09e27eef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2975301Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#75269}
-
Igor Sheludko authored
... and OPTIMIZED_CODE_LIST and DEOPTIMIZED_CODE_LIST slots of NativeContext which serve as heads of respective weak lists of Code objects. Drive-by: trivial NativeContext methods are moved to contexts-inl.h header. Bug: v8:11880 Change-Id: I0f2ca967b2820f84c279fea702bab28829f65d0e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2968416Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#75268}
-
Daniel Lehmann authored
In an effort to merge `CODE_SPACE_WRITE_SCOPE` and `NativeModuleModificationScope`, this CL moves the interface and implementation of the latter into code-space-access.{h,cc}, where the former already lives. No other changes to the code itself. R=clemensb@chromium.org CC=jkummerow@chromium.org Bug: v8:11714 Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel_ng Change-Id: I1aabce26f2033430523a7a3a0a4864e7267bee21 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2972803Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Daniel Lehmann <dlehmann@google.com> Cr-Commit-Position: refs/heads/master@{#75267}
-
Clemens Backes authored
There is exactly one WasmEngine per process, hence we do not need to store or pass a pointer to it. We just use {GetWasmEngine} (which just reads a global variable) whenever we need it. R=jkummerow@chromium.org Bug: v8:11879 Change-Id: I7e0e86e326f4cafe5a894af0ff6d35803c0340a9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2972725 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#75266}
-
Clemens Backes authored
The WasmEngine is shared across the whole process, so there is no need to store it in every Isolate. Instead, we can just get it from everywhere on any thread using {wasm::GetWasmEngine()}, which is a simple read of a global. R=jkummerow@chromium.org Bug: v8:11879 Change-Id: I13afb8ca3d116aa14bfaec5a4bbd6d71faa9aa17 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2969825Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#75265}
-
- 19 Jun, 2021 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/11f1e3d..d6115b1 Rolling v8/buildtools/linux64: git_revision:d2dce7523036ed7c55fbb8d2f272ab3720d5cf34..git_revision:7d803996740ccd587c54062750cbe04dfbc3c423 Rolling v8/third_party/aemu-linux-x64: R61GnhotR5EpRE5ZeVtRvIQPRz8z-LSXnxN1ighigqMC..h_kO6UaQmxXGNfG0ofG4wgKw_URVHcderPkx6AlamR0C Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/2573cff..893c99a Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/59140d4..473499b Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/66b4484..0e77445 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I00eab552662eb15afd50c8b77ff72932806d443b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2973786Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#75264}
-
- 18 Jun, 2021 3 commits
-
-
Frank Tang authored
This reverts commit f8a40f6d. Reason for revert: Performance regression Original change's description: > [intl] Ship "best fit" LocaleMatcher for m93 > > LGTM1 Mike West mkwst@chromium.org > LGTM2 Chris Harrelson chrishtr@chromium.org > LGTM3 Yoav Weiss yoavweiss@chromium.org > > Design Doc: > https://docs.google.com/document/d/1cPGfiihn76yj2iAomKcspPFyLLcnk3WkCiqceBQPQyk > R2T: https://groups.google.com/a/chromium.org/g/blink-dev/c/W7TcX1tSHDI/m/1AthUhEWBAAJ > I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/TpAvyXwHM_c/m/QXJKbClfAwAJ > Stage in m92 Canary 92 92.0.4500.0 Dev 92 92.0.4503.3 Beta 92 92.0.4515.40 > https://chromiumdash.appspot.com/commit/eb6482784ca71d3b22db449fd941bfa9872d244a > > > Bug: v8:7051, v8:11868, v8:11869 > Change-Id: Id1ae20234b764e6f6def83af651daf70056d0725 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2950559 > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75194} Bug: v8:7051, v8:11868, v8:11869 Change-Id: I1c5d2c2201f7724eb7db67f2c5268b787d6ca8eb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2973649 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#75263}
-
Frank Tang authored
This reverts commit dd8845cd. Reason for revert: Performance regression Original change's description: > [intl] Improve test coverage of "best fit" localeMatcher > > https: //docs.google.com/document/d/1cPGfiihn76yj2iAomKcspPFyLLcnk3WkCiqceBQPQyk/edit#heading=h.cc9tt7s0iwsd > Bug: v8:7051 > Change-Id: I8c35e859062c5bdb009334dd1b725751e6df2123 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2965481 > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75228} Bug: v8:7051 Change-Id: I4cf9484d727291ebc2868e3594ab1f18b19bec6b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2973227 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Frank Tang <ftang@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#75262}
-
Junliang Yan authored
Change-Id: Ie092921e4a9c1e4a0acee827f73570f3f9617712 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2971557Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#75261}
-