• Clemens Backes's avatar
    Reland "[wasm] Provide a global WasmCodeManager" · 4e19455b
    Clemens Backes authored
    This is a reland of 0f90a2aa.
    The issue was inverted destructor order between WasmCodeManager and
    WasmEngine. WasmEngine has to be destructed first, because it contains
    a barrier to ensure that background compile threads finished before
    global state is being destructed.
    
    Original change's description:
    > [wasm] Provide a global WasmCodeManager
    >
    > The WasmCodeManager was part of the WasmEngine so far, but there is only
    > exactly one WasmEngine. Hence we can pull it out, and also remove the
    > pointer in the WasmCodeAllocator.
    >
    > The argument passed from the single constructor call is now inlined in
    > the constructor itself.
    >
    > Drive-by: Replace "GetPlatformPageAllocator()->CommitPageSize()" by just
    > "CommitPageSize()".
    >
    > R=jkummerow@chromium.org
    >
    > Bug: v8:11879
    > Change-Id: I6c0e74cea308f5806d1aa479945d90b6ef8d1613
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2972909
    > Commit-Queue: Clemens Backes <clemensb@chromium.org>
    > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#75270}
    
    Bug: v8:11879
    Change-Id: I0eaa2395f5c1e30f3f7303c5f3df70c227b74d3d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2975859
    Auto-Submit: Clemens Backes <clemensb@chromium.org>
    Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#75289}
    4e19455b
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...