- 26 Jun, 2018 1 commit
-
-
Georg Neis authored
V8 knows heap numbers and mutable heap numbers. They have difference instance types, but in C++ code we've used the same class for both (HeapNumber). Confusingly, however, IsHeapNumber would return false for mutable heap numbers, while HeapNumber::cast would succeed. This CL adds a separate class MutableHeapNumber and eliminates the confusing behavior. TBR=bmeurer@chromium.org Change-Id: Id894d177c7fe8cc3f451be80c273b50daee91378 Reviewed-on: https://chromium-review.googlesource.com/1113544 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#54012}
-
- 25 Jun, 2018 22 commits
-
-
Aseem Garg authored
This reverts commit 82d44722. Reason for revert: we want to keep register allocation general simd binary case Original change's description: > [wasm] reduce registers for simd packing in ia32 > > R=gdeepti@chromium.org > BUG=v8:6020 > > Change-Id: I01644bca95ff5715122c1bc3923024145586a6fd > Reviewed-on: https://chromium-review.googlesource.com/1112070 > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > Commit-Queue: Aseem Garg <aseemgarg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53985} TBR=bbudge@chromium.org,gdeepti@chromium.org,aseemgarg@chromium.org,jing.bao@intel.com Bug: v8:6020 Change-Id: I878ca82b893fc019e9f769ab2b218fdbaad5f701 Reviewed-on: https://chromium-review.googlesource.com/1114157 Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Reviewed-by:
Aseem Garg <aseemgarg@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#54011}
-
Yang Guo authored
TBR=machenbach@chromium.org Bug: v8:7881 Change-Id: I1fe6a64e3d64532411bdcbb95cd4dd36cbe234e0 Reviewed-on: https://chromium-review.googlesource.com/1111699Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#54010}
-
Michael Starzinger authored
In the two remaining places that call the {Reset} method, it is already guaranteed that the {next_instance} and {prev_instance} is undefined. R=titzer@chromium.org Change-Id: Iab2e764d88b7ba710c664fea363951fb6f9132e0 Reviewed-on: https://chromium-review.googlesource.com/1113551Reviewed-by:Ben Titzer <titzer@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#54009}
-
Camillo Bruni authored
Previously the KeyAccumulator incorrectly reused the filter properties when collecting the keys of a proxy target. This led to incorect behavior where for instance non-enumerable properties were filtered too early. Bug: v8:7818 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I9b43b65be168ef0975fea9245d433a54338d228e Reviewed-on: https://chromium-review.googlesource.com/1113743 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#54008}
-
Camillo Bruni authored
Bug: chromium:850005, chromium:852085, Change-Id: I777321306b1b68330e39e43aacc715478764649f Reviewed-on: https://chromium-review.googlesource.com/1104470 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#54007}
-
Sergiy Byelozyorov authored
Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/8c08316..b334665 TBR=hablich@chromium.org, machenbach@chromium.org Change-Id: If210d2822e17961099b42080bfb9d0e5747a5d42 Reviewed-on: https://chromium-review.googlesource.com/1113545 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#54006}
-
Théotime Grohens authored
This CL adds a fast path for DataView getters and setters when the load or store to be performed is aligned and when the requested endianness matches the platform endianness. In that case, we can just emit the right load/store instruction instead of having to read and write data byte by byte. Change-Id: I10bd95a7fe8d23f695899eb8173bc654fb38fbb0 Reviewed-on: https://chromium-review.googlesource.com/1106168 Commit-Queue: Théotime Grohens <theotime@google.com> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#54005}
-
Jaroslav Sevcik authored
This does not move the dependency management there, yet. Bug: v8:7790 Change-Id: Ia8b473a89c2853ffeba4adf84ac8814f403279c9 Reviewed-on: https://chromium-review.googlesource.com/1112256 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Mathias Bynens authored
The upstream test suite for Unicode property escapes [1] is exhaustive and is updated soon after every new release of the Unicode Standard. It is then upstreamed into Test262. This patch simplifies our own Script_Extensions tests and the script used to generate them. Now, only a few code points are tested for each Script_Extension. This avoids unnecessary friction every time ICU is updated based on a new Unicode version. [1] https://github.com/mathiasbynens/unicode-property-escapes-tests [2] https://github.com/tc39/test262/tree/master/test/built-ins/RegExp/property-escapes Bug: chromium:850334, v8:7825 Change-Id: I792d6848ef48b41ea5e9db18b777040d019822f3 Reviewed-on: https://chromium-review.googlesource.com/1112250Reviewed-by:
-
Rodrigo Bruno authored
Bug: chromium:845409 Change-Id: I7a4e19529193f7e8369b7db02c7bcf01ae302ee3 Reviewed-on: https://chromium-review.googlesource.com/1113439 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by:
-
Michael Starzinger authored
R=titzer@chromium.org Change-Id: I760a2568194edce486383d2bf32d598bdb9d44b1 Reviewed-on: https://chromium-review.googlesource.com/1109938Reviewed-by:
-
Michael Starzinger authored
R=herhut@chromium.org Change-Id: I648c0247985c434df36586cbe702287516c54580 Reviewed-on: https://chromium-review.googlesource.com/1113337Reviewed-by:
Stephan Herhut <herhut@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#54000}
-
Sergiy Byelozyorov authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/169887d..59ac9bd TBR=hablich@chromium.org, machenbach@chromium.org Change-Id: Ie5992189071dffe8b26ae4dc51741bc853de5892 Reviewed-on: https://chromium-review.googlesource.com/1113314 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Unittests may take compilation dependencies without committing them, because no code object is ever created. This CL ensures that after each unittest, all uncommitted dependencies are discarded. Without this, the compilation dependencies leaks pointers to already freed C++ objects between test-cases, which are then accessed after free if a unittest invalidates the corresponding compilation dependency. Bug: v8:851886 Change-Id: I55d989c42d45f5d713613bc1d3f86e00bd1b8d21 Reviewed-on: https://chromium-review.googlesource.com/1113313 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#53998}
-
Leszek Swirski authored
Roughly: GetIsolate(): -31 handle(HeapObject): -6 TBR=verwaest@chromium.org Bug: v8:7786 Change-Id: I3857f8c45f1f93c727d575d5f9244d9811949a7f Reviewed-on: https://chromium-review.googlesource.com/1111838Reviewed-by:Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#53997}
-
Peter Marshall authored
Currently we perform the full iteration protocol even when we don't need to. When IterableToListCanBeElided is true, we still need to create a copy of the array (from a spec correctness point of view, in case there are user-JS side-effects that would modify the original). This CL copies the array directly, skipping the iteration protocol. This recovers the JSTests/TypedArrays/ConstructArrayLike benchmark almost completely. Change-Id: I7f1593dd9af6e4a0485bd654e6c02186c5ae99d0 Reviewed-on: https://chromium-review.googlesource.com/1105995Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#53996}
-
Sergiy Byelozyorov authored
Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/6f4dae2..5941c1b Rolling v8/third_party/android_tools: https://chromium.googlesource.com/android_tools/+log/c22a664..3545ab5 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/fdacd16..2e625dc Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/e09b684..d91a468 Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/9077ec7..ce468a1 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/37fc68b..c6e5ea2 Rolling v8/tools/luci-go: https://chromium.googlesource.com/chromium/src/tools/luci-go/+log/4cc6820..0e27f88 Rolling v8/tools/swarming_client: https://chromium.googlesource.com/infra/luci/client-py/+log/281c390..9a518d0 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I988c02cd04943c96e28badf97ac232d71e03e935 Reviewed-on: https://chromium-review.googlesource.com/1113185Reviewed-by:
-
Camillo Bruni authored
This reverts commit a800e050. Original change's description: > Revert "[parser][log] Log script id during background compilation" > > This reverts commit aafd5c52. > > Reason for revert: Tentative revert for > > https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64/24825 > https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20msvc/3242 > > Original change's description: > > [parser][log] Log script id during background compilation > > > > - Add separate script-create, script-reserve-id and script-details log events > > - Add log events for CompilationCache hits and puts > > - Simplify function event logging by only pass along the script id > > - Explicitly create Scripts in parse-processor.js on script events only > > - Create a temporary script id in the ParseInfo for use during background > > parsing and compilation > > - Clean up ParseInfo initialization to centralize creation and use of > > script ids > > - Allow creating Scripts with predefined script ids > > > > Bug: chromium:757467, chromium:850038 > > Change-Id: I02dfd1d5725795b9fe0ea94ef57b287b934a1efe > > Reviewed-on: https://chromium-review.googlesource.com/1097131 > > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#53978} > > TBR=ulan@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org > > Change-Id: I629f72f51d5e086e2b54658c1fdd18cec268aab2 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:757467, chromium:850038 > Reviewed-on: https://chromium-review.googlesource.com/1112538 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53984} TBR=ulan@chromium.org,yangguo@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:757467, chromium:850038 Change-Id: I3088c86362c06ee50464f1f14e25350b1b8048ad Reviewed-on: https://chromium-review.googlesource.com/1112539Reviewed-by:
-
Tobias Tebbi authored
With this CL, switch jump tables are enabled even with --untrusted-code-mitigations Bug: chromium:849098 Change-Id: I60545ed7bef2cd847710fd9660ef1007aac3b428 Reviewed-on: https://chromium-review.googlesource.com/1110817Reviewed-by:
-
Shiyu Zhang authored
Migrate the Object.getOwnPropertyNames to the CodeStubAssembler and use the enum cache backing store when 1) the enum cache is avaible 2) the {object} has no elements 3) all own properties are enumerable This makes a speedup of 10x when using Object.getOwnPropertyNames with fast-path. It improves Speedometer2.0 Inferno case by ~9% on ATOM platform. Change-Id: I05e1df0e7d9d53d97664c322248cedb106a7b1d0 Reviewed-on: https://chromium-review.googlesource.com/1004434Reviewed-by:Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com> Cr-Commit-Position: refs/heads/master@{#53992}
-
Michael Starzinger authored
R=herhut@chromium.org Change-Id: I052aee6778e96feeac5610c52b34b65d26de4dcb Reviewed-on: https://chromium-review.googlesource.com/1112000Reviewed-by:
-
jing.bao authored
I32x4U/SConvertI16x8Low/High, I16x8U/SConvertI8x16Low/High Add pmovsxbw/wd, pmovzxbw/wd and AVX version Add Palignr, Pmovsxbw/wd, Pmovzxbw/wd macro. Reconstruct ptest/vptest, Ptest using macro Change-Id: I4a26b3bb6d5791f72e3192c914758287701e78a0 Reviewed-on: https://chromium-review.googlesource.com/1111691 Commit-Queue: Jing Bao <jing.bao@intel.com> Reviewed-by:
-
- 23 Jun, 2018 4 commits
-
-
v8-ci-autoroll-builder authored
Rolling v8/test/test262/data: https://chromium.googlesource.com/external/github.com/tc39/test262/+log/6c2503a..9bddfae TBR=adamk@chromium.org,gsathya@chromium.org Change-Id: I55dc31096a88cb0663bc87f53939c35e3c6422c2 Reviewed-on: https://chromium-review.googlesource.com/1112913Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#53989}
-
Leszek Swirski authored
Bug: v8:7786 Change-Id: I2d2e62001294c15411e26b022cad410d54577927 Reviewed-on: https://chromium-review.googlesource.com/1111837 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Access Isolate* and Heap* wherever already available. Roughly: GetIsolate(): -20 GetHeap(): -22 Handle<>(HeapObject): -315 handle(HeapObject): -21 Bug: v8:7786 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I2da36ed1909d849812a1cb6bf94cb735eedca45b Reviewed-on: https://chromium-review.googlesource.com/1111707 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Deepti Gandluri authored
R=clemensh@chromium.org CC=titzer@chromium.org Change-Id: Ie9cfc0902e765fe3c7945540a609be9901faedff Reviewed-on: https://chromium-review.googlesource.com/1110847 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#53986}
-
- 22 Jun, 2018 13 commits
-
-
Aseem Garg authored
R=gdeepti@chromium.org BUG=v8:6020 Change-Id: I01644bca95ff5715122c1bc3923024145586a6fd Reviewed-on: https://chromium-review.googlesource.com/1112070Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Cr-Commit-Position: refs/heads/master@{#53985}
-
Yang Guo authored
This reverts commit aafd5c52. Reason for revert: Tentative revert for https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64/24825 https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20msvc/3242 Original change's description: > [parser][log] Log script id during background compilation > > - Add separate script-create, script-reserve-id and script-details log events > - Add log events for CompilationCache hits and puts > - Simplify function event logging by only pass along the script id > - Explicitly create Scripts in parse-processor.js on script events only > - Create a temporary script id in the ParseInfo for use during background > parsing and compilation > - Clean up ParseInfo initialization to centralize creation and use of > script ids > - Allow creating Scripts with predefined script ids > > Bug: chromium:757467, chromium:850038 > Change-Id: I02dfd1d5725795b9fe0ea94ef57b287b934a1efe > Reviewed-on: https://chromium-review.googlesource.com/1097131 > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53978} TBR=ulan@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org Change-Id: I629f72f51d5e086e2b54658c1fdd18cec268aab2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:757467, chromium:850038 Reviewed-on: https://chromium-review.googlesource.com/1112538Reviewed-by:
-
Yang Guo authored
This reverts commit 31815e73. Reason for revert: Several failures: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win32/14453 https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win32%20-%20debug/15144 https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Mac64%20ASAN/18385 https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20ASAN/3469 Original change's description: > Reland "[wasm] Enable Liftoff by default on ia32 and x64" > > This is a reland of 20f33823. > The GC crash should be fixed by https://crrev.com/c/1108208. > > Original change's description: > > [wasm] Enable Liftoff by default on ia32 and x64 > > > > R=titzer@chromium.org, hablich@chromium.org > > > > Bug: v8:6600, chromium:787421 > > Change-Id: Ia8ae56ddef3b27b0721d5a66ff19abe098a2c6ca > > Reviewed-on: https://chromium-review.googlesource.com/1109899 > > Reviewed-by: Ben Titzer <titzer@chromium.org> > > Reviewed-by: Michael Hablich <hablich@chromium.org> > > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#53965} > > TBR=titzer@chromium.org, hablich@chromium.org > > Bug: v8:6600, chromium:787421 > Change-Id: I2228084d7bd8ef8e96027bbd3dd81bc42d1dc533 > Reviewed-on: https://chromium-review.googlesource.com/1112097 > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53982} TBR=titzer@chromium.org,hablich@chromium.org,clemensh@chromium.org Change-Id: Id53c3cf08fa084108b656b7697786a364dfdf827 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6600, chromium:787421 Reviewed-on: https://chromium-review.googlesource.com/1112537Reviewed-by:
-
Clemens Hammacher authored
This is a reland of 20f33823. The GC crash should be fixed by https://crrev.com/c/1108208. Original change's description: > [wasm] Enable Liftoff by default on ia32 and x64 > > R=titzer@chromium.org, hablich@chromium.org > > Bug: v8:6600, chromium:787421 > Change-Id: Ia8ae56ddef3b27b0721d5a66ff19abe098a2c6ca > Reviewed-on: https://chromium-review.googlesource.com/1109899 > Reviewed-by: Ben Titzer <titzer@chromium.org> > Reviewed-by: Michael Hablich <hablich@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53965} TBR=titzer@chromium.org, hablich@chromium.org Bug: v8:6600, chromium:787421 Change-Id: I2228084d7bd8ef8e96027bbd3dd81bc42d1dc533 Reviewed-on: https://chromium-review.googlesource.com/1112097Reviewed-by:
-
Clemens Hammacher authored
This is a reland of ada64800, fixed for 32 bit architectures (register pairs). Original change's description: > [Liftoff] Fix register use count > > In {SetLocalFromStackSlot}, we decrement the use count of the register > in the target slot without updating this slot, and then call > {GetUnusedRegister}. At that point, the register use counts do not > match the cache state, which leads to errors later on. > This CL fixes this by marking the target slot as a stack slot after > reducing the register use count. > > It also adds a Validation which helped to find that error and will > catch similar errors earlier. > > R=titzer@chromium.org > > Bug: chromium:854050, v8:6600 > Change-Id: I74d3a5aa947ec4247d7b4557567f642bf4082316 > Reviewed-on: https://chromium-review.googlesource.com/1111958 > Reviewed-by: Ben Titzer <titzer@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53976} TBR=titzer@chromium.org Bug: chromium:854050, v8:6600 Change-Id: Ibc8801737e9604a8490382c569b0378585625376 Reviewed-on: https://chromium-review.googlesource.com/1112238 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Alexey Kozyatinskiy authored
It looks like we do not need live_edit flag. R=dgozman@chromium.org,yangguo@chromium.org Bug: v8:7862 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I2b635f7d24138894b7a0f94fc90293d50e40f22c Reviewed-on: https://chromium-review.googlesource.com/1108386 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This reverts commit ada64800. Reason for revert: Failure with slow dchecks: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20debug/20982 Original change's description: > [Liftoff] Fix register use count > > In {SetLocalFromStackSlot}, we decrement the use count of the register > in the target slot without updating this slot, and then call > {GetUnusedRegister}. At that point, the register use counts do not > match the cache state, which leads to errors later on. > This CL fixes this by marking the target slot as a stack slot after > reducing the register use count. > > It also adds a Validation which helped to find that error and will > catch similar errors earlier. > > R=titzer@chromium.org > > Bug: chromium:854050, v8:6600 > Change-Id: I74d3a5aa947ec4247d7b4557567f642bf4082316 > Reviewed-on: https://chromium-review.googlesource.com/1111958 > Reviewed-by: Ben Titzer <titzer@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53976} TBR=titzer@chromium.org,clemensh@chromium.org Change-Id: I5b8d8d405dcd7f82ee431cba290419425b9859a1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:854050, v8:6600 Reviewed-on: https://chromium-review.googlesource.com/1112277Reviewed-by:
-
Camillo Bruni authored
- Add separate script-create, script-reserve-id and script-details log events - Add log events for CompilationCache hits and puts - Simplify function event logging by only pass along the script id - Explicitly create Scripts in parse-processor.js on script events only - Create a temporary script id in the ParseInfo for use during background parsing and compilation - Clean up ParseInfo initialization to centralize creation and use of script ids - Allow creating Scripts with predefined script ids Bug: chromium:757467, chromium:850038 Change-Id: I02dfd1d5725795b9fe0ea94ef57b287b934a1efe Reviewed-on: https://chromium-review.googlesource.com/1097131Reviewed-by:
-
Clemens Hammacher authored
The wire bytes are currently stored as {SeqOneByteString} on the JS heap. In order to make the {NativeModule} isolate independent, and to ensure fast access to the wire bytes, they should move to the native heap. R=titzer@chromium.org Bug: chromium:854794, v8:7868, v8:7424 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I36811ec87f780c5b1f6863cd6de89a165aa0b7d5 Reviewed-on: https://chromium-review.googlesource.com/1108208 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Clemens Hammacher authored
In {SetLocalFromStackSlot}, we decrement the use count of the register in the target slot without updating this slot, and then call {GetUnusedRegister}. At that point, the register use counts do not match the cache state, which leads to errors later on. This CL fixes this by marking the target slot as a stack slot after reducing the register use count. It also adds a Validation which helped to find that error and will catch similar errors earlier. R=titzer@chromium.org Bug: chromium:854050, v8:6600 Change-Id: I74d3a5aa947ec4247d7b4557567f642bf4082316 Reviewed-on: https://chromium-review.googlesource.com/1111958Reviewed-by: -
Clemens Hammacher authored
The method does not do much, and all callers actually overwrite or delete the stack slot right after calling this method anyways, so there is no need to make the slot a stack slot first. R=titzer@chromium.org Bug: v8:6600 Change-Id: I4fd54d2ed5f86a3e011ddc2748833dc81052ef5b Reviewed-on: https://chromium-review.googlesource.com/1111848Reviewed-by:
-
Clemens Hammacher authored
This reverts commit e3229485. Reason for revert: just landed to gather perf feedback. Original change's description: > [array] Change QuickSort to TimSort for Array.p.sort > > R=jgruber@chromium.org > > Bug: v8:7382 > Change-Id: I95d2187d22c3bea4323789042b3426d65fde4999 > Reviewed-on: https://chromium-review.googlesource.com/1111959 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Simon Zünd <szuend@google.com> > Cr-Commit-Position: refs/heads/master@{#53970} TBR=jgruber@chromium.org,szuend@google.com Change-Id: I1e150e856a32039eb241a745bd7e6180f2132430 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7382 Reviewed-on: https://chromium-review.googlesource.com/1112099Reviewed-by:
-
Dominic Farolino authored
As per https://github.com/whatwg/console/issues/27#issuecomment-289312546 and https://bugs.chromium.org/p/chromium/issues/detail?id=706804 we're leaving the console timeline/timelineEnd methods out of the specification and testing that implementations do not expose them (relevant WPTs at https://github.com/web-platform-tests/wpt/blob/master/console/console-tests-historical.any.js). Their implementations should be removed from Chrome, one of the last implementers of these legacy methods. The same goes for markTimeline, as it is deprecated in Chrome and not being included in the spec. R=bmeurer@chromium.org, kozyatinskiy@chromium.org Bug: chromium:706804 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ibe05848fb664d26d16eeb5bdf6f519c1eeb4b2df Reviewed-on: https://chromium-review.googlesource.com/1082112Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Cr-Commit-Position: refs/heads/master@{#53973}
-
