Commit 8723374b authored by Clemens Hammacher's avatar Clemens Hammacher Committed by Commit Bot

Revert "[array] Change QuickSort to TimSort for Array.p.sort"

This reverts commit e3229485.

Reason for revert: just landed to gather perf feedback.

Original change's description:
> [array] Change QuickSort to TimSort for Array.p.sort
> 
> R=​jgruber@chromium.org
> 
> Bug: v8:7382
> Change-Id: I95d2187d22c3bea4323789042b3426d65fde4999
> Reviewed-on: https://chromium-review.googlesource.com/1111959
> Reviewed-by: Jakob Gruber <jgruber@chromium.org>
> Commit-Queue: Simon Zünd <szuend@google.com>
> Cr-Commit-Position: refs/heads/master@{#53970}

TBR=jgruber@chromium.org,szuend@google.com

Change-Id: I1e150e856a32039eb241a745bd7e6180f2132430
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:7382
Reviewed-on: https://chromium-review.googlesource.com/1112099Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53974}
parent 313bc6d4
This diff is collapsed.
......@@ -238,9 +238,7 @@ extern operator '!=' macro WordNotEqual(Object, Object): bool;
extern operator '+' macro SmiAdd(Smi, Smi): Smi;
extern operator '-' macro SmiSub(Smi, Smi): Smi;
extern operator '*' macro SmiMul(Smi, Smi): Smi;
extern operator '&' macro SmiAnd(Smi, Smi): Smi;
extern operator '|' macro SmiOr(Smi, Smi): Smi;
extern operator '>>>' macro SmiShr(Smi, constexpr int31): Smi;
extern operator '+' macro IntPtrAdd(intptr, intptr): intptr;
......@@ -666,7 +664,6 @@ extern macro IsJSArray(HeapObject): bool;
extern macro TaggedIsCallable(Object): bool;
extern macro IsDetachedBuffer(JSArrayBuffer): bool;
extern macro IsHeapNumber(HeapObject): bool;
extern macro IsFixedArray(HeapObject): bool;
extern macro IsExtensibleMap(Map): bool;
extern macro IsCustomElementsReceiverInstanceType(int32): bool;
......
......@@ -381,26 +381,6 @@ Node* ArrayBuiltinsAssembler::FindProcessor(Node* k_value, Node* k) {
void ArrayBuiltinsAssembler::NullPostLoopAction() {}
void ArrayBuiltinsAssembler::FillFixedArrayWithZero(TNode<FixedArray> array,
TNode<Smi> smi_length) {
TNode<IntPtrT> length = SmiToIntPtr(smi_length);
TNode<WordT> byte_length = WordShl(length, kPointerSizeLog2);
CSA_ASSERT(this, UintPtrLessThan(length, byte_length));
static const int32_t fa_base_data_offset =
FixedArray::kHeaderSize - kHeapObjectTag;
TNode<IntPtrT> backing_store = IntPtrAdd(
BitcastTaggedToWord(array), IntPtrConstant(fa_base_data_offset));
// Call out to memset to perform initialization.
TNode<ExternalReference> memset =
ExternalConstant(ExternalReference::libc_memset_function());
STATIC_ASSERT(kSizetSize == kIntptrSize);
CallCFunction3(MachineType::Pointer(), MachineType::Pointer(),
MachineType::IntPtr(), MachineType::UintPtr(), memset,
backing_store, IntPtrConstant(0), byte_length);
}
void ArrayBuiltinsAssembler::ReturnFromBuiltin(Node* value) {
if (argc_ == nullptr) {
Return(value);
......
......@@ -77,9 +77,6 @@ class ArrayBuiltinsAssembler : public BaseBuiltinsFromDSLAssembler {
return StoreFixedArrayElement(array, index, value);
}
// Uses memset to effectively initialize the given FixedArray with Smi zeroes.
void FillFixedArrayWithZero(TNode<FixedArray> array, TNode<Smi> smi_length);
protected:
TNode<Context> context() { return context_; }
TNode<Object> receiver() { return receiver_; }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment