• Sigurd Schneider's avatar
    [unittests] Fix use-after-free leak via compilation dependencies · 395d1e57
    Sigurd Schneider authored
    Unittests may take compilation dependencies without committing them,
    because no code object is ever created. This CL ensures that after each
    unittest, all uncommitted dependencies are discarded. Without this,
    the compilation dependencies leaks pointers to already freed C++ objects
    between test-cases, which are then accessed after free if a unittest
    invalidates the corresponding compilation dependency.
    
    Bug: v8:851886
    Change-Id: I55d989c42d45f5d713613bc1d3f86e00bd1b8d21
    Reviewed-on: https://chromium-review.googlesource.com/1113313
    Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
    Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#53998}
    395d1e57
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...