• Camillo Bruni's avatar
    Reland "[parser][log] Log script id during background compilation" · e7f5c5cc
    Camillo Bruni authored
    This reverts commit a800e050.
    
    Original change's description:
    > Revert "[parser][log] Log script id during background compilation"
    >
    > This reverts commit aafd5c52.
    >
    > Reason for revert: Tentative revert for
    >
    > https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64/24825
    > https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20msvc/3242
    >
    > Original change's description:
    > > [parser][log] Log script id during background compilation
    > >
    > > - Add separate script-create, script-reserve-id and script-details log events
    > > - Add log events for CompilationCache hits and puts
    > > - Simplify function event logging by only pass along the script id
    > > - Explicitly create Scripts in parse-processor.js on script events only
    > > - Create a temporary script id in the ParseInfo for use during background
    > >   parsing and compilation
    > > - Clean up ParseInfo initialization to centralize creation and use of
    > >   script ids
    > > - Allow creating Scripts with predefined script ids
    > >
    > > Bug: chromium:757467, chromium:850038
    > > Change-Id: I02dfd1d5725795b9fe0ea94ef57b287b934a1efe
    > > Reviewed-on: https://chromium-review.googlesource.com/1097131
    > > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
    > > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
    > > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#53978}
    >
    > TBR=ulan@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
    >
    > Change-Id: I629f72f51d5e086e2b54658c1fdd18cec268aab2
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: chromium:757467, chromium:850038
    > Reviewed-on: https://chromium-review.googlesource.com/1112538
    > Reviewed-by: Yang Guo <yangguo@chromium.org>
    > Commit-Queue: Yang Guo <yangguo@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#53984}
    
    TBR=ulan@chromium.org,yangguo@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: chromium:757467, chromium:850038
    Change-Id: I3088c86362c06ee50464f1f14e25350b1b8048ad
    Reviewed-on: https://chromium-review.googlesource.com/1112539Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#53994}
    e7f5c5cc
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...