- 17 Mar, 2022 14 commits
-
-
Jakob Gruber authored
This implements the last bits of basic concurrent Maglev compilation. When jobs have been processed, schedule an interrupt to trigger codegen and building the Code object on the main thread. Bug: v8:7700 Change-Id: I348ade4777ddddf7c3a6b0575d9f51e5fa00c9fb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3528494Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#79516}
-
Jakob Gruber authored
.. into new virtual subclass TurbofanCompilationJob. Update all TF code to derive from this class. Specifically, the OptimizedCompilationInfo is TF-specific and now lives in TurbofanCompilationJob. The motivation behind this is that Maglev now also uses this infrastructure. Drive-by: Replace CompilationMode with ConcurrencyMode. Bug: v8:7700 Change-Id: Iae6d1ffd1c810e2e45cad6c9b4e43d4c82ac54a7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3528493Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#79515}
-
jameslahm authored
In JSCallReducer::ReduceArrayPrototypeShift, add Unsigned32 TypeGuard for index Node used in fast path, avoid representing kRepFloat64 (Range(1, inf)) to kRepWord64 when converting input for kLoadElement. Bug: v8:12632 Change-Id: I2e4b00840dc5462e4351e13a372c33b6272b9ea1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3528373Reviewed-by:
-
Victor Gomes authored
Fixes wrong conditional logic in BaselineCompilerTask::Install. Removes is_compiled(), since CanCompileWithBaseline already checks for HasBytecodeArray. Bug: chromium:1307072 Change-Id: I4cc61e2bab8d1fb5a5b253d291c7079b82c3fa44 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3532230 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Jakob Gruber authored
This started out as a minor code move of early-osr logic, but became a more general refactor of the tiering decisions. Early-OSR: the intent here is to trigger OSR as soon as possible when matching OSR'd code is cached. Move this out of ShouldOptimize (since it has side effects), and into a dedicated function that's called early in the decision process. Note that with this change, we no longer trigger normal TF optimization along with the OSR request - TF tiering heuristics are already complex enough, let's not add yet another special case right now. Other refactors: - Clarify terminology around OSR. None of the functions in TM actually perform OSR; instead, they only increase the OSR urgency, effectively increasing the set of loops that will trigger OSR compilation. - Clarify the control flow through the tiering decisions. Notably, we only increment OSR urgency when normal tierup has previously been requested. Also, there is a bytecode size limit involved. These conditions were previously hidden inside other functions. Bug: v8:12161 Change-Id: I8f58b4332bd9851c6b299655ce840555fb7efa92 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3529448Reviewed-by:
-
王澳 authored
This reverts commit 9f9f36f8. Reason for revert: regressed ai-astar on the M1 Original change's description: > [call reducer] inline Array.prototype.indexOf/includes in js-call-reducer. > > - inline Array.prototype.indexOf in js-call-reducer > - inline Array.prototype.includes in js-call-reducer > > Bug: v8:12390 > Change-Id: Idb5669da3019f0f56af0084fccd1d616d4c5098e > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3473994 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Commit-Queue: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/main@{#79461} Bug: v8:12390, chromium:1306250 Change-Id: I91c666c2f56c30db4f43bb009ee6206ad219f51a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3532399 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by:
-
V8 Autoroll authored
Change-Id: I3485e5d41cbafae1318c285bf564bc7df4a8c0f8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3532189Reviewed-by:
Lutz Vahl <vahl@chromium.org> Commit-Queue: Lutz Vahl <vahl@chromium.org> Cr-Commit-Position: refs/heads/main@{#79510}
-
Jakob Gruber authored
- Restructure the runtime function implementation. - Rename osr_loop_nesting_level to osr_urgency and add helpers. The motivation for the latter: I've always struggled with the `osr_loop_nesting_level` term; it neither matches terminology of what it's compared against (= the loop depth), nor implies what it's used for (= osr is triggered when `loop depth < osr nesting level`). In this CL it's renamed to `osr_urgency` to reflect that as urgency rises, we consider more and more loops as OSR candidates. Bug: v8:12161 Change-Id: I194ec5a3f1f02526641af1c7796ee0956b6fd3a1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3528735Reviewed-by:
Patrick Thier <pthier@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Reviewed-by:
-
Michael Achenbach authored
This reverts commit 1289704a. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Mac%20-%20arm64%20-%20release/8735/overview Original change's description: > [tools] Clean up py2 code > > Bug: chromium:1292013 > Change-Id: Ic2c3a197005a2136bb0eda4cbb36d8eb57f42a7c > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3523047 > Reviewed-by: Liviu Rau <liviurau@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/main@{#79507} Bug: chromium:1292013 Change-Id: I48c38209220b775d0caa45f487ed163f78333e0c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3532228 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#79508}
-
Michael Achenbach authored
Bug: chromium:1292013 Change-Id: Ic2c3a197005a2136bb0eda4cbb36d8eb57f42a7c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3523047Reviewed-by:
Liviu Rau <liviurau@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#79507}
-
Michael Achenbach authored
Bug: chromium:1292013 Change-Id: If50c18249afe8b75154d4b111485280d158a5582 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3525137Reviewed-by:
-
Michael Achenbach authored
Bug: chromium:1292013 Change-Id: I8202fed4d59edcc98fff193f3a4b102a5c79d553 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3525136Reviewed-by:
Tamer Tas <tmrts@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#79505}
-
Shu-yu Guo authored
Bug: v8:12547 Change-Id: Ie27831b793f214368a003adac24b7c92f1a5fc11 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3518426Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Yuxiang Cao authored
Bug: v8:12707 Change-Id: I411950dc92336f73f10614e75bd64647d4137857 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3523995Reviewed-by:
ji qiu <qiuji@iscas.ac.cn> Reviewed-by:
Yahan Lu <yahan@iscas.ac.cn> Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#79503}
-
- 16 Mar, 2022 15 commits
-
-
Darius M authored
CL https://chromium-review.googlesource.com/c/v8/v8/+/3514072 tried to improve code generation for patterns like "x >> n == k" when n and k are constant, and to generate instead "x == k << n" (with "k << n" being computed at compile time). However, this was also done when "x >> n" was reused later, which caused "x" to be kept alive longer that it could have, which could increase register pressure. This CL thus ensures that this optimization is done only if "x >> n" has a single use. Bug: chromium:1305389 Change-Id: I377e120c4825e2a0deb4a5478138da838bcebc77 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3528987Reviewed-by:
-
Vasili Skurydzin authored
Change-Id: I2ff012f0da2c536d78e12c7b8f02fe2d28b7b7ea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3526338Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
Milad Farazmand <mfarazma@redhat.com> Commit-Queue: Vasili Skurydzin <vasili.skurydzin@ibm.com> Cr-Commit-Position: refs/heads/main@{#79501}
-
Victor Gomes authored
We check if debugger needs to hook into every call when we enqueue the function to batch and when we compile, but we do not check it when we install it (that is, set_baseline_code), which is done in the main thread. Bug: v8:12713 Change-Id: I81ba221caed1060976e8865174d392a861f2ab24 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3528988 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Marja Hölttä authored
Please revert this CL if it causes any trouble! Bug: v8:11111 Change-Id: I6061fdc0aed82952f093ede9ecd252be1ac99519 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3528495Reviewed-by:
-
Clemens Backes authored
In text, we should use the properly capitalized "Wasm" instead of "WASM". In particular for frame output, other frames typically use CamelCase (like "JsToWasmFrame", "ExitFrame", "InternalFrame"), so Wasm should do the same. The "0xa" comment in some assemblers is also outdated, the current tag we emit for StackFrame::WASM is 0x8 (0x4 shifted by one). R=jkummerow@chromium.org Bug: v8:12425 Change-Id: Ic3e00c401b219c28b5424c82efb0f1a9df51690f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3525195Reviewed-by:
-
Samuel Groß authored
JSObject::InitializeBody now checks whether the instance type of the object being initialized can have embedder data slots around the initialization logic for these slots. This fixes a performance regression on certain benchmarks. To perform this check efficiently, a new instance type, JSObjectWithEmbedderSlots, is introduced so that the check becomes a simple range check. Bug: chromium:1304139 Change-Id: I00c892bc2276e950b59602257ca1c2435c10e517 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3507712Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Samuel Groß authored
This method now handles external pointers in HeapObjects during serialization by encoding the representation of the external pointer (sandboxed, raw), the origin (internal, api) and potentially the external pointer tag. It is currently only used to handle JSExternalObjects but could, in the future, be extended to handle all external pointers that need special handling during serialization/deserialization. Bug: v8:12700 Change-Id: Ib0747d765ddc632e4ca4ee94521616d0271be0bc Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3521904Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Frank Tang authored
Implement the Intl.PluralRules.prototype.selectRange (start, end) of the spec See https://tc39.es/proposal-intl-numberformat-v3/out/pluralrules/diff.html https://chromestatus.com/guide/edit/5707621009981440 Design Doc: https://docs.google.com/document/d/19jAogPBb6W4Samt8NWGZKu47iv0_KoQhBvLgQH3xvr8/edit Bug: v8:10776 Change-Id: Ie9c56df7ce68199492281fdf2483c3d6f822cc9e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3504421Reviewed-by:
-
Marja Hölttä authored
Bug: v8:11111 Change-Id: Id6eafbd3a70cd8edd552d06942517ffaf413f568 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497815Reviewed-by:
-
Zhao Jiazhong authored
Port commit I3cb2a4d386cb92a4dcd2edbdd3fba9ef71f354d6 Besides, clean some useless "SafepointRegister" stuff for MIPS. Change-Id: I85bc7592faa1a7939330bef8453ea5eff4ac7f71 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3527185Reviewed-by:
Yu Liu <liuyu@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/main@{#79493}
-
Clemens Backes authored
This reverts commit f01a6098. Reason for revert: Consistent TSan failures: https://crbug.com/v8/12713 Original change's description: > [baseline] Enable concurrent sparkplug > > Bug: v8:12054 > Change-Id: I1b0ee1a9541a75412b882b259e421aa6e88317da > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259658 > Auto-Submit: Victor Gomes <victorgomes@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Commit-Queue: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/main@{#79485} Bug: v8:12054 Change-Id: Ide6bbac8c280a1373c5082bbe5356a205f3396c5 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3528496 Auto-Submit: Clemens Backes <clemensb@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#79492}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/18a1f19..3d95907 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/63a615b..b3fe2c1 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/3481645..b199f54 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/85f3c90..b60d34c R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I5d2149bbec079a8127089d33f38f64f952e9e9cd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3526718 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#79491}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/1fa4e39..8a5b728 Add af and ur to common ICU (Trevor Perrier) https://chromium.googlesource.com/chromium/deps/icu/+/8a5b728 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,ftang@chromium.org Change-Id: I313ca3e905c578ecaa6a55916f9011fb67516e6c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3526720 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#79490}
-
Jakob Gruber authored
This CL implements most parts of the concurrent maglev pipeline. - MaglevConcurrentDispatcher: controls concurrent jobs. - MaglevCompilationInfo: holds job-global data, controls handle fiddling between the main isolate and local isolates, owns job-global state like the Zone. - MaglevCompilationUnit: same as before, holds per-unit data. Still missing: job finalization. Bug: v8:7700 Change-Id: I281178d945e79a0ba97fa2ac7023285d84a16641 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3516036Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/9a71e5d..5704cd4 add note about wheels action to releasing docs (Dominic Hamon) https://chromium.googlesource.com/external/github.com/google/benchmark/+/5704cd4 Change artifact download name to dist to match upload name (#1371) (Nicholas Junge) https://chromium.googlesource.com/external/github.com/google/benchmark/+/3eab985 Remove conditional trigger from PyPI upload job (#1370) (Nicholas Junge) https://chromium.googlesource.com/external/github.com/google/benchmark/+/7d6f153 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org Change-Id: I85cd3a461f2a677973064ca51963e040d3cff8dd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3526719 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#79488}
-
- 15 Mar, 2022 11 commits
-
-
Samuel Groß authored
This is necessary due to the indirect call to memfd_create. The function is only used for testing though. Bug: v8:12682 Change-Id: Ifb9fd855213064165fa4c2125846ff592368b625 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3525534Reviewed-by:
-
Samuel Groß authored
The use of memfd_create causes V8 to require glibc 2.27 which wasn't previously needed. This CL rewrites the affected code to check at runtime whether memfd_create is available and otherwise use mkstemp. Bug: v8:12682 Change-Id: I84dc3f5ab7504cec2b599bc92501ddecc2ae22cf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3516870Reviewed-by:
-
Victor Gomes authored
Bug: v8:12054 Change-Id: I1b0ee1a9541a75412b882b259e421aa6e88317da Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259658 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Milad Fa authored
Port 8a0d1b6f Original Commit Message: Modernise the RegList interface to be a proper class, rather than a typedef to an integer, and add proper methods onto it rather than ad-hoc bit manipulation. In particular, this makes RegList typesafe, adding a DoubleRegList for DoubleRegisters. The Arm64 CPURegList isn't updated to use (or extend) the new RegList interface, because of its weird type-erasing semantics (it can store Registers and VRegisters). Maybe in the future we'll want to get rid of CPURegList entirely and use RegList/DoubleRegList directly. R=leszeks@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I997156fe4f4f2ccc40b2631d5cb752efdc8a5ad2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3525084Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#79484}
-
Al Muthanna Athamina authored
Bug: chromium:1306416 Change-Id: I103602ed1bea71d79a17a9a37c7eaf198575d371 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3521944Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Clemens Backes authored
It turned out that on arm and arm64 we over-estimated the code size of a Wasm module quite a bit. This CL adds some more output for the --trace-wasm-compilation-times flag, and adds a script to compute the factors we use for code size estimates from that output. I ran the script on a few benchmarks (an older Epic module, the current Photoshop module, and the benchmark from the linked bug), and adjusted the constants accordingly. Also, simplify the API of {ReservationSize} to only return a single number, and fail internally if we need to allocate more than the engine supports (which would only fail for artificially large modules). R=jkummerow@chromium.org Bug: chromium:1302310 Change-Id: I5b2c27ff3e360fb6738cf5dd697bcee09e106b6d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3522067Reviewed-by:Maya Lekova <mslekova@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#79482}
-
Maya Lekova authored
This CL adds a missing header that was implicitly included by "test/cctest/wasm/wasm-run-utils.h", which resulted in test failure with v8_enable_webassembly = true. Drive-by: Improve traceability of the fastcall cctests. Bug: chromium:1052746 Change-Id: I4cafbce2e390958befee896782ad13a9bdfc0f30 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3525113Reviewed-by:
-
Tamer Tas authored
R=machenbach@chromium.org,alexschulze@chromium.org,almuthanna@chromium.org,liviurau@chromium.org Bug: chromium:1298869 Change-Id: Ia08f5069bacf5134ba56265d64eff527d7dd96fb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3525134 Commit-Queue: Tamer Tas <tmrts@chromium.org> Auto-Submit: Tamer Tas <tmrts@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Victor Gomes authored
Fix compilation issue in ia32. Change-Id: I7603a3bcebda0faf4e44d02e6c22601f7531a7aa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3516746 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#79479}
-
Victor Gomes authored
Bug: v8:12709 Change-Id: Ia353ce364546fc34ca6b93a9873a20630a8085a5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3523045 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#79478}
-
Tamer Tas authored
Format strings are the convention in Py3 R=machenbach@chromium.org,alexschulze@chromium.org Bug: chromium:1298869 Change-Id: Ia660e933f07d2a592c2edadaa99df68c47adb80d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3521789 Auto-Submit: Tamer Tas <tmrts@chromium.org> Reviewed-by:
-
