• Clemens Backes's avatar
    [wasm] Tweak constants for estimating code space size · 4e983705
    Clemens Backes authored
    It turned out that on arm and arm64 we over-estimated the code size of a
    Wasm module quite a bit. This CL adds some more output for the
    --trace-wasm-compilation-times flag, and adds a script to compute the
    factors we use for code size estimates from that output.
    I ran the script on a few benchmarks (an older Epic module, the current
    Photoshop module, and the benchmark from the linked bug), and adjusted
    the constants accordingly.
    
    Also, simplify the API of {ReservationSize} to only return a single
    number, and fail internally if we need to allocate more than the engine
    supports (which would only fail for artificially large modules).
    
    R=jkummerow@chromium.org
    
    Bug: chromium:1302310
    Change-Id: I5b2c27ff3e360fb6738cf5dd697bcee09e106b6d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3522067Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#79482}
    4e983705
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...