Commit fc3f2b93 authored by Samuel Groß's avatar Samuel Groß Committed by V8 LUCI CQ

[base] Disable CFI_ICALL for OS::CreateSharedMemoryHandleForTesting

This is necessary due to the indirect call to memfd_create. The function
is only used for testing though.

Bug: v8:12682
Change-Id: Ifb9fd855213064165fa4c2125846ff592368b625
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3525534Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
Commit-Queue: Samuel Groß <saelo@chromium.org>
Auto-Submit: Samuel Groß <saelo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#79487}
parent 4e81f258
......@@ -578,6 +578,8 @@ void OS::FreeAddressSpaceReservation(AddressSpaceReservation reservation) {
// macOS specific implementation in platform-macos.cc.
#if !defined(V8_OS_MACOS)
// static
// Need to disable CFI_ICALL due to the indirect call to memfd_create.
DISABLE_CFI_ICALL
PlatformSharedMemoryHandle OS::CreateSharedMemoryHandleForTesting(size_t size) {
#if V8_OS_LINUX && !V8_OS_ANDROID
// Use memfd_create if available, otherwise mkstemp.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment