- 17 Mar, 2021 1 commit
-
-
Liu Yu authored
Port: 3f9ff062 Bug: v8:11238 Change-Id: I3ac454b7ea1addbbf41407c7acd6a18da7b35d10 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2763965 Auto-Submit: Liu yu <liuyu@loongson.cn> Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#73457}
-
- 09 Mar, 2021 1 commit
-
-
Liu Yu authored
Port: 75d7d127 Bug: v8:11238 Change-Id: I5369875fe66d2297cbd342db91b1ffd99a361616 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2738792Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Auto-Submit: Liu yu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/master@{#73289}
-
- 25 Feb, 2021 1 commit
-
-
Victor Gomes authored
Change-Id: I59b26323bd8d2fd35379fb73c799943315d5422b Bug: v8:11502 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2719564 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#73042}
-
- 24 Feb, 2021 1 commit
-
-
LiuYu authored
Besides, implement extended add pairwise and i64x2.abs in liftoff. Port: aee85229 Port: 8136e399 Port: 31aab838 Bug: v8:11086 v8:11416 Change-Id: I77539c745b67c6b9d4205b4e5e96504e5ad3da13 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2717150 Auto-Submit: Liu yu <liuyu@loongson.cn> Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#72992}
-
- 22 Feb, 2021 1 commit
-
-
LiuYu authored
Besides, fix i64x2 widen i32x4 instructions in mips32. Change-Id: I85e3f8f4ab16c268a5b17189f67c78ef45762e39 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2711737Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Auto-Submit: Liu yu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/master@{#72907}
-
- 02 Feb, 2021 1 commit
-
-
Liu Yu authored
Port: 3b302d5c Port: 45b99aaa Besides, removed redundant DCHECK. Change-Id: Ifac825ae7670b075750603b2c61a3d60a85cc373 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2662581Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Auto-Submit: Liu yu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/master@{#72471}
-
- 27 Jan, 2021 1 commit
-
-
LiuYu authored
Port: 9db3cb75 Port: 22e06c7b Change-Id: Ib42f9729220365f1803cfbc634e3f37f5209e142 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2650045 Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Auto-Submit: Liu yu <liuyu@loongson.cn> Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#72351}
-
- 21 Jan, 2021 1 commit
-
-
Liu Yu authored
Port: 624030e9 Bug: v8:11256 Change-Id: I48379a716fd5424448fb1fb1051a9d119f73bcdb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2642167 Auto-Submit: Liu yu <liuyu@loongson.cn> Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#72221}
-
- 18 Jan, 2021 1 commit
-
-
Victor Gomes authored
Removes: - v8_disable_arguments_adaptor GN flag - ArgumentsAdaptorTrampoline - ArgumentsAdaptorFrame class Change-Id: I382ebe6c25c3c172bee5df3e86e762fca10fa392 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2622911Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/master@{#72133}
-
- 12 Jan, 2021 1 commit
-
-
LiuYu authored
Change-Id: I1024b336ac3d24c69f5a47a919b69a9ef363ec66 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2620002 Auto-Submit: Liu yu <liuyu@loongson.cn> Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#72027}
-
- 04 Jan, 2021 1 commit
-
-
LiuYu authored
Change-Id: Id20ea44e9cf804d305731799045c45a577df47ec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2607266Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Auto-Submit: Liu yu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/master@{#71902}
-
- 24 Dec, 2020 1 commit
-
-
LiuYu authored
CallRecordWriteStub Port: 6b3994e8 Bug: chromium:1146813 Change-Id: I552f49193188d91d64a1d75307cd3390138c9e7a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2599426Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#71874}
-
- 19 Dec, 2020 1 commit
-
-
LiuYu authored
Port: 7bdb0fbb Bug: v8:10582 Change-Id: I2a2227ddc45b86f7ad496b524514db96f423b185 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2598463Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Auto-Submit: Liu yu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/master@{#71843}
-
- 17 Dec, 2020 1 commit
-
-
LiuYu authored
Port: 5e18ab50 Bug: v8:7748 Change-Id: I1ac349cf80b6689971bd6c686c6795daf85c5637 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2594536 Auto-Submit: Liu yu <liuyu@loongson.cn> Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#71815}
-
- 14 Dec, 2020 1 commit
-
-
LiuYu authored
Port: 6dbc2b01 Bug: v8:10975 Change-Id: Id3e70dda9f71ecf333890e70d6a5e64ed5a91ccf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2575731Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by: Zhi An Ng <zhin@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Auto-Submit: Liu yu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/master@{#71734}
-
- 02 Dec, 2020 1 commit
-
-
Liu Yu authored
Port: b6643320 Bug: v8:10582 Change-Id: I3efdd840a4f3f2eeb6156f8b446478311a2ccd26 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2568569Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Auto-Submit: Liu yu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/master@{#71560}
-
- 24 Nov, 2020 1 commit
-
-
Zhao Jiazhong authored
Now the ModS opcode and MacroAssembler::EmitFPUTruncate function are useless, and should be removed. Change-Id: I5ba7c2cd01084b322046c8267b7581ab9d1755c6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2554382Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#71352}
-
- 09 Nov, 2020 1 commit
-
-
Liu Yu authored
This is a reland of 7257dc93 Original change's description: > [mips] Remove arguments adaptor frame > > Port: 958d8e9f > > Bug: v8:10201 > > Change-Id: I27d29f2a1f1d5f659d558b5fd776b88474d9b140 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2513867 > Auto-Submit: Liu yu <liuyu@loongson.cn> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70964} Bug: v8:10201 Change-Id: Ic95dca5185316f1c877d11819296c70833f1b609 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2520639 Auto-Submit: Liu yu <liuyu@loongson.cn> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#71032}
-
- 05 Nov, 2020 1 commit
-
-
Liu yu authored
This reverts commit 7257dc93. Reason for revert: - New test fail on mips64el: https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket.appspot.com/8864502401132417824/+/steps/Check/0/logs/modules-import-large/0 Original change's description: > [mips] Remove arguments adaptor frame > > Port: 958d8e9f > > Bug: v8:10201 > > Change-Id: I27d29f2a1f1d5f659d558b5fd776b88474d9b140 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2513867 > Auto-Submit: Liu yu <liuyu@loongson.cn> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70964} TBR=jgruber@chromium.org,liuyu@loongson.cn Change-Id: Iddca9684995409fb9a1f3340b3a1931b1b5b472b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10201 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2519189Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#70980}
-
- 04 Nov, 2020 1 commit
-
-
Liu Yu authored
Port: 958d8e9f Bug: v8:10201 Change-Id: I27d29f2a1f1d5f659d558b5fd776b88474d9b140 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2513867 Auto-Submit: Liu yu <liuyu@loongson.cn> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#70964}
-
- 28 Oct, 2020 1 commit
-
-
Zhao Jiazhong authored
When switching buffers, the last_call_pc_ should be adjusted like pc_, because the buffer's start address is changed. Besides, add a missing BlockTrampolinePoolScope. Change-Id: Iee6d9795a256e041bb2dbf7d8ca63f346a248539 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2504855Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#70823}
-
- 26 Oct, 2020 1 commit
-
-
Zhao Jiazhong authored
Port c7cb9bec https://chromium-review.googlesource.com/c/v8/v8/+/2488682 Change-Id: I782663f35d0beeea83a95a266cb787ef4c192ea8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2496406Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#70748}
-
- 19 Oct, 2020 1 commit
-
-
Zhao Jiazhong authored
kDoubleRegZero register is not hardwired to 0.0, we need to check it's value before using it. Change-Id: I8a64ac55294f51a9a5f96a39a3b344f7e34d508a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2479223Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Zhi An Ng <zhin@chromium.org> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#70595}
-
- 15 Oct, 2020 1 commit
-
-
Zhao Jiazhong authored
The RoundFloat/RoundDouble functions should return the Canonical NaN if the input is a NaN. Change-Id: I19928a8a3d78770757c6fe2e240254efe9944bdc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2475493 Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#70530}
-
- 13 Oct, 2020 1 commit
-
-
Zhao Jiazhong authored
Change-Id: I3f5dbb0fbae3862a6da4146b83e49986c8be3bdc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2467015Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#70469}
-
- 18 Sep, 2020 1 commit
-
-
Zhao Jiazhong authored
Port 7f654693 https://chromium-review.googlesource.com/c/v8/v8/+/2411691 Change-Id: I8b06288b003d99d1ee76415aee3fafd5cd963ae7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2415852 Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#69979}
-
- 16 Sep, 2020 1 commit
-
-
Yu Yin authored
Bug: v8:10201 Change-Id: I313405983696546b817c96a820343e6cb9e3fdd4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2408977Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Yu Yin <xwafish@gmail.com> Cr-Commit-Position: refs/heads/master@{#69926}
-
- 10 Sep, 2020 1 commit
-
-
Zhao Jiazhong authored
Change-Id: Ic2bbf2b3ff542d916da43929445bd83553b5091f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2401952Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#69796}
-
- 08 Sep, 2020 1 commit
-
-
Zhao Jiazhong authored
Port a2fd94f0 https://crrev.com/c/2312783 Original Commit Message: This adds the argument count (as intptr) to the standard frame. StandardFrames are now in the same shape as OptimizedFrames. The argument count in the stack will be used to tear down the arguments when we remove the arguments adaptor frame. Change-Id: I5cff9874735c1bdbd685deb0d829e57f1ee07ac2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2393323Reviewed-by: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#69738}
-
- 30 Jun, 2020 1 commit
-
-
Zhao Jiazhong authored
On mips platform, call operations may be followed by trampolines, which leading to wrong information of the call instr's location in safepoint. This CL fix it by adding a last_call_pc_ to record the location. Besides, this CL also fix a bind operation in CheckTrampolinePool, which may try to use trampoline before it's emission. Change-Id: Ic0cbdb93afffa60a7389ee8177c381087fcaf52e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2095645 Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#68600}
-
- 13 May, 2020 1 commit
-
-
Dan Elphick authored
BasicMemoryChunk will become the base class for ReadOnlySpace pages which won't be MemoryChunks. Since ReadOnlySpace pages don't participate in GC they don't need slot_set_. Also some references to BasicMemoryChunk fields that were still prefixed with MemoryChunk:: Bug: v8:10454 Change-Id: If8ce40c7ee72d1617d2a1161ad9d4b7929f8a8e7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2198988 Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#67774}
-
- 05 May, 2020 1 commit
-
-
Dan Elphick authored
Also makes memory-chunk.h accessible from outside heap which allows removal of some heap-inl.h includes. Bug: v8:10473, v8:10496 Change-Id: Iec4fc5ce8ad201f6ee5fd924cc3cd935324429fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2172088 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#67551}
-
- 21 Apr, 2020 1 commit
-
-
Yu Yin authored
Port several CLs recorded in bug 9909. We test this on 3A4000, and find many issues in MSA implement, but they are not related with this patch, will fix in another CL. Looks like there is no 32-bit os for 3a4000, so we do not implements s128 for mips32. Bug: v8:9909 Change-Id: Iad7569ebb92904bae66d420c8306cde24afb034a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2147575 Commit-Queue: Yu Yin <xwafish@gmail.com> Reviewed-by: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#67259}
-
- 19 Mar, 2020 1 commit
-
-
Emanuel Ziegler authored
Ported changes from the following CLs to mips/mips64: - https://chromium-review.googlesource.com/c/v8/v8/+/2066964 - https://chromium-review.googlesource.com/c/v8/v8/+/2071866 - https://chromium-review.googlesource.com/c/v8/v8/+/2080242 This change is needed for profiling of Wasm code that calls C-function to ignore the C-stack above the Wasm stack that otherwise couldn't be parsed otherwise. Bug: chromium:1045860 Change-Id: Ifdce5be6c5373714a67b3ce8d8c4f0a18f63b6fa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2082566Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> Cr-Commit-Position: refs/heads/master@{#66785}
-
- 17 Mar, 2020 1 commit
-
-
Georgia Kouveli authored
Generate a BTI instruction at each target of an indirect branch (BR/BLR). An indirect branch that doesn't jump to a BTI instruction will generate an exception on a BTI-enabled core. On cores that do not support the BTI extension, the BTI instruction is a NOP. Targets of indirect branch instructions include, among other things, function entrypoints, exception handlers and jump tables. Lazy deopt exits can potentially be reached through an indirect branch when an exception is thrown, so they also get an additional BTI instruction. Bug: v8:10026 Change-Id: I0ebf51071f1b604f60f524096e013dfd64fcd7ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1967315 Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#66751}
-
- 10 Feb, 2020 1 commit
-
-
Pierre Langlois authored
Each assembler has it's own way to place breakpoints: - stop() for arm, mips*, ppc* and s390. - debug() for arm64. - int3() for ia32 and x64. We can mandate a macro-assembler `DebugBreak()` method that all should implement so one can place a breakpoint in a portable way using a macro-assembler. This way also assemblers are in line with TurboFan, CSA, Torque and Liftoff which all have a DebugBreak() facility. Change-Id: Ic4332bd19ca4db53e01441d54af6632c2c1189f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2020954Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Pierre Langlois <pierre.langlois@arm.com> Cr-Commit-Position: refs/heads/master@{#66198}
-
- 10 Jan, 2020 2 commits
-
-
Seth Brenith authored
This change moves the definitions of the bitfield flags used by Symbol and Map to Torque. Symbol could directly follow the pattern established by SharedFunctionInfo, but Map required some other changes: - Until now, Torque bitfield definitions have required unsigned types. I thought that this would be the least-surprising behavior, since we never sign-extend when decoding bitfield values. However, I believe that the amount of churn involved in making ElementsKind be unsigned outweighs the benefit we were getting from this restriction (and similar difficulties are likely to arise in converting other bitfield structs to Torque), so this CL updates Torque to allow signed bitfield values. - If we try to make Map extend from all of the generated classes that define its flags, we end up with class sizing problems because some compilers only apply empty base class optimization to the first in a row of empty base classes. We could work around this issue by generating macros instead of classes, but I took this as an opportunity for a minor clean-up instead: rather than having bitfield definitions for several different bitfield structs all jumbled together in Map, they can be split up. I think this makes the code a little easier to follow, but if others disagree I'm happy to implement macro generation instead. Change-Id: Ibf339b0be97f72d740bf1daa8300b471912faeba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1988934Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/master@{#65701}
-
Zhao Jiazhong authored
Bug: v8:8974 Change-Id: Ib1e1c84b79190359d5ad519509b881e93d519604 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1989323 Commit-Queue: Clemens Backes <clemensb@chromium.org> Auto-Submit: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#65697}
-
- 22 Nov, 2019 1 commit
-
-
Zhao Jiazhong authored
The previous implementation incorrectly used instructions for 32-bit data, this CL fixes it to implement 64-bit operations. Change-Id: Ib8e5236ea35f3a2c0e37e647ea89aad6a1127425 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1928501 Auto-Submit: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#65123}
-
- 08 Nov, 2019 1 commit
-
-
Michael Starzinger authored
This removes the support to emit runtime calls in Liftoff code and uses WebAssembly runtime stubs instead. Calls to such stubs are smaller and more efficient. They also use embedded builtins directly instead of the on-heap {Code} object trampolines. This also removes the last use of a runtime call that passes a dynamically loaded CEntry builtin from the macro assembler. R=clemensb@chromium.org Change-Id: I9fa9f3b7a2b66cb76a677b70ce3cee49cb340f0f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1903443 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64855}
-