- 11 May, 2020 23 commits
-
-
Ng Zhi An authored
See https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html for more on this warning. Bug: v8:10488 Change-Id: Ifa9443609fa30fa2d8f9fb9ed00ce9353fa9aa49 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2189910Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#67718}
-
Igor Sheludko authored
... when the element is read-only in one of the prototypes: * the length should not be updated, * in strict mode the store operation should throw TypeError. Bug: chromium:1055138 Change-Id: I7fc08e22c83f8a9848053cfe20851dc1b82f0e3d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2172090 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#67717}
-
Clemens Backes authored
If multiple isolates are using the same module, we need to keep it tiered down as long as any isolate still has a debugger open. Also, we cannot short-cut the {NativeModule::TierDown} method, since the previously triggered tier down might not have finished yet. For now, each isolate starts an independent tier down (i.e. a full recompilation). We could optimize this later by skipping functions that are already tiered down, or are already scheduled for tier down, but we still need to wait for tier-down to finish on each isolate. R=thibaudm@chromium.org Bug: v8:10359 Change-Id: I7ea6a6f5d3977e48718ac5bc94f9831541f6173f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2190758 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#67716}
-
Santiago Aboy Solanes authored
If a node is reduced in-place (i.e not replaced by another node) we check its inputs, and if we Recurse on at least one input we return early. If this happens, we weren't revisiting its uses. This CL changes this since we could have been missing revisiting of some uses. Change-Id: I7683a0747cec38484a047c6032980b5676b2d886 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2174505 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#67715}
-
Jakob Kummerow authored
With bounds checks, null checks, and a test case. Bug: v8:7748 Change-Id: I9e7d68ecd883bd0279f22d11c1dc73cc8716a4cb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2192659 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Bug: chromium:1056170 Change-Id: I99d073e268f5779f0985d6197432c50036060b60 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2192663 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#67713}
-
Manos Koukoutos authored
Add br_on_null opcode, encoding, decoding, and elementary tests. Bug: v8:7748 Change-Id: Id771ea7f57694e1c1bffc83c4232132bf9ad9dbd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2190424 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#67712}
-
Santiago Aboy Solanes authored
It will now return true for 32-bit constants as well. When enabling this, two errors popped up: one in dissassembler where we might have null hosts, and one in remembered set where we should be compressing the address before storing. As a drive-by: make ppc use full objects until their pointer compression implementation is fully done. Bug: v8:7703 Change-Id: I70f05f952d4e1305fe1fe030755f01f74ea5e5dc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2187622Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#67711}
-
Dominik Inführ authored
Need to use relaxed store for initializing bit_field. The concurrent marker accesses the has_prototype_slot bit in Map::bit_field to calculate header size. Bug: v8:10315 Change-Id: I1eebd4a6f42b9263de7e424957b32884f7b910ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2193712 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Scripts aren't callable functions. Even though internally they were for a while, they aren't anymore. We shouldn't return them to users as if they were. We already remove strict-mode functions from CallSites, so we now do the same for internal functions that are created for scripts. Bug: v8:10508 Change-Id: I270c714524439fba9ad90dd29826bed4811ba2b4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2193716 Auto-Submit: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#67709}
-
Clemens Backes authored
Passing an isolate to {RecompileNativeModule} feels wrong, since compilation and the generated code are totally isolate-independent. In fact, the isolate is only used for updating counters. Instead of passing the counters instead, this CL just refactors the code to support a nullptr for the counters everywhere (some code paths already supported that). The few recompilation would not make a significant difference in the histograms anyway, and even have the risk of skewing the data. Drive-by 1: Rename {TierUp} to {StartTierUp} and update comments. Drive-by 2: Remove non-actionable TODO. R=thibaudm@chromium.org Bug: v8:10359 Change-Id: Ic027f939bbc55398b90784922130fe1fe5573b0c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2187638Reviewed-by: -
Dominik Inführ authored
Loads target but with relaxed load. Concurrent marking needs to load field with relaxed load, since the main thread could change this field when unregistering. Change-Id: I809b1d4db1dd58c92bdb998601c2f709073104af Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2192661Reviewed-by:
-
Sami Kyostila authored
We are currently porting Chromium over to use the Perfetto client library for tracing[1]. When this mode is enabled, V8 should also use the Perfetto library built by Chromium instead of building an indepedendent copy. This patch enables that behavior, gated by the |use_perfetto_client_library| flag set by Chromium. We also roll Perfetto to the latest version, add a couple of missing dependencies on v8_tracing and add a missing tracing category group. [1] https://docs.google.com/document/d/1f7tt4cb-JcA5bQFR1oXk60ncJPpkL02_Hi_Bc6MfTQk/ (Internal) Bug: 155075662 Change-Id: I76d9626b1c83cb7a278dc3281b3a1db653ab8733 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2182637Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Tamer Tas <tmrts@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#67706}
-
Manos Koukoutos authored
Implement the instruction ref.as_non_null, as per the wasm gc extension. Changes: - Add the respective wasm opcode, move some asmjs opcodes around. - Add a new type of wasm trap, IllegalCast. - Modify wasm decoding and compilation pipeline. - Add a minimal test. - In wasm-compiler, generalize Unreachable to Trap. - Optimize struct.get and struct.set for non-null types. Bug: v8:7748 Change-Id: If2f794306c7cbfabc06e4f64988132346085d6dd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2187616 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
This replaces VisitMode with a set of option flags that allow skipping specific roots like unserializable, weak, global handles, etc. The advantage is that it is no longer coupled with the callers and does not know about different types of GCs and their phases. The CL is pure refactoring without behavior changes except for the heap verification where more roots are verified that before. Change-Id: I350b2ed14826e0efb75770111c6b28bb8d4d9845 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2190420Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#67704}
-
Jakob Gruber authored
Collecting feedback for {Call,InstanceOf,Construct} is similar but distressingly different. In preparation for adding a CollectConstructFeedback helper, this CL ports {Call,InstanceOf} feedback collection to Torque. Bug: v8:8888 Change-Id: Iaacc137ef46a77a4fe2857ec41c5cc30614dfdf0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2187497Reviewed-by:Igor Sheludko <ishell@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#67703}
-
Andreas Haas authored
In the existing code we used a register of the UseScratchRegisterScope for the destination address. However, this register is needed for the ParallelRegisterMove as well. With this CL we use fixed registers for the destination address and the offset as well. The CL also changes the implementation of CalculateActualAddress to allow to set an explicit register for the result. R=clemensb@chromium.org Bug: v8:10108, chromium:1079449 Change-Id: I39c11b9ffa5f3e937ce4820b9991482ad711b4b0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2192652 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Use same mangling as for x64 MacOS. Bug: v8:10517 Change-Id: I26d7c4ab950d86e9010e76a0a6d71ea266639d02 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2192653Reviewed-by:
-
Michael Lippautz authored
Bug: chromium:1056170 Change-Id: I778dc23c82e8cfda34559e5e2e7515a73010a9d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2192656Reviewed-by:
-
Dominik Inführ authored
This reverts commit 7f29c48e. Reason for revert: Causing TSAN failures on test bots. Original change's description: > [heap] Remove sweeping state in incremental marking > > Remove the SWEEPING state from incremental marking. Sweeping is now > always completed when starting incremental marking. Before this change > there needed to be a safepoint each for starting marking and completing > sweeping. Now both happens within a single safepoint. > > Bug: v8:10315 > Change-Id: Iad2835554865f2de24376372affe9a98992d1fa0 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2190419 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67678} TBR=ulan@chromium.org,dinfuehr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:10315 Change-Id: I5e76990155cf7aeee3ecefe5e37f9028cb188a00 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2192658Reviewed-by:
-
Clemens Backes authored
Also, rename the WASM_COMPILED frame type to just WASM. R=jkummerow@chromium.org Bug: v8:10389 Change-Id: I71f16f41a69f8b0295ba34bd7d7fad71729546f2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2187613 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Camillo Bruni authored
The V8-side of top-level await is complete. Staging this feature to get fuzzing coverage. Bug: chrome:1022182, v8:9344 Change-Id: I1b88d0450aa148b84c62659628d492ffc3074d0f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2185132Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#67697}
-
Leszek Swirski authored
This reverts commit 8374feed. Reason for revert: Breaking mjsunit/global-hash under the stress_snapshot variant, e.g. https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20-%20debug%20-%20fyi/12560 Original change's description: > [snapshot] rehash JSMap and JSSet during deserialization > > To rehash JSMap and JSSet, we simply replace the backing store > with a new one created with the new hash. > > Bug: v8:9187 > Change-Id: I90c25b18b33b7bc2b6ffe1b89fe17aa5f978b517 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2143983 > Commit-Queue: Joyee Cheung <joyee@igalia.com> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67663} TBR=cbruni@chromium.org,jgruber@chromium.org,verwaest@chromium.org,joyee@igalia.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:9187 Change-Id: I4a89768c031cd3971eefd9f88528ddd52e1284c9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2192657Reviewed-by:
-
- 10 May, 2020 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/fed20a4..10edae4 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/8b35029..aaf5669 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: Iebc6e8cb6649034ed4971b04a5c3b077982849c1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2191660Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#67695}
-
- 09 May, 2020 2 commits
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/2ec959d..fed20a4 Rolling v8/third_party/aemu-linux-x64: MeLYn-hjraOzvUMXrfer2KnMsBnC4w6qg8ctTIpuFcgC..fPXztkM0sEne8uTSiAXBgjYK_46aVSqohP1kVE4u-u8C Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/06f14d9..4ca83c7 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/9a73531..8b35029 Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/21c6af6..90fc47e Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/54f2e0d..de3e206 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I52e366c6899c4c6231242f7682dbdd4b24a01d36 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2191039Reviewed-by:
-
Bill Budge authored
- Reworks it to use a builtin to GetProperty, after making sure it's an "own" property. This reduces the size of the builtin by 2/3 (from 1476 to 596 bytes on x64). Change-Id: I41c1642369f73e5322790f3091b8cea9a650a529 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2181642Reviewed-by:
-
- 08 May, 2020 14 commits
-
-
Ng Zhi An authored
Bug: v8:10180 Change-Id: I830491f9141aba4b9b3165e08620723b5aaefa3c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2185480Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#67692}
-
Tobias Tebbi authored
Bug: v8:7793 TBR: danno@chromium.org Change-Id: If6b1229af2b282bd24bf222b2a06a45cc640c557 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2190750Reviewed-by:
-
Deepti Gandluri authored
This CL adds use counters, as well as the callbacks needed to register usage during the SIMD origin trial. Change-Id: I35b7f48277b519b72136f86cf03508adbaa069b8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2189334 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
-
Clemens Backes authored
All wasm code is compiled now. Hence merge the {WasmCompiledFrameSummary} into {WasmFrameSummary} and remove the dispatch. Also, rename {IsWasmCompiled} to {IsWasm} and {AsWasmCompiled} to {AsWasm}. R=jkummerow@chromium.org Bug: v8:10389 Change-Id: I33e413c7d0fa622249563091925b29631472b40c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2187170Reviewed-by: -
Ng Zhi An authored
This patch implements f32x4.pmin, f32x4.pmax, f64x2.pmin, and f64x2.pmax for x64 and interpreter. Pseudo-min and Pseudo-max instructions were proposed in https://github.com/WebAssembly/simd/pull/122. These instructions exactly match std::min and std::max in C++ STL, and thus have different semantics from the existing min and max. The instruction-selector for x64 switches the operands around, because it allows for defining the dst to be same as first (really the second input node), allowing better codegen. For example, b = f32x4.pmin(a, b) directly maps to vminps(b, b, a) or minps(b, a), as long as we can define dst == b, and switching the instruction operands around allows us to do that. Bug: v8:10501 Change-Id: I06f983fc1764caf673e600ac91d9c0ac5166e17e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2186630 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Michael Lippautz authored
The visitor was removing pages while at the same time iterating them on NormalPagedSpace. Removing all pages at once is safe and should also be faster. Bug: chromium:1056170 Change-Id: I56eedf6f09498f126cb09238e01962b48e75b657 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2190427Reviewed-by:
-
Ng Zhi An authored
This started as fixing a clang-tidy warning to use a explicitly defaulted destructor, see https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++-dos-and-donts.md#prefer-to-use. But we can clean it up a bit more to omit the destructor, since the all its members are trivially destructible. With this change, ByteData is now is_trivially_destructible. Bug: v8:10488 Change-Id: If6698ce181dc8bca2a6623987039f3116a375dd1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2182309 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Shu-yu Guo authored
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/6a18c27c..f1b0a1e2 Bug: v8:7834, v8:10510 Change-Id: I888eb57ef92bcce15bb015ea56ad2f61505a4fb8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2189911Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#67685}
-
Leszek Swirski authored
Bug: chromium:1011762 Change-Id: I3dc2975f3a93fa4c780e54e6e5bd8e689e008f36 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2190751 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Toon Verwaest authored
This changes the existing implementation that creates an unresolved reference for those cases to look at exactly what scopes are relevant so it can correctly handle catch scopes and avoid re-resolving later. Variable through with aren't marked as assigning since this information isn't relevant for the with itself; and if the with is passed through, there's no need to mark the outer variable as assigned since it's either initialized or it isn't. The catch variable is assigned since it is relevant for the catch variable. The CL uses LookupLocal which wouldn't work for deserialized scopes, but this isn't relevant because 1) eval scopes are declaration scopes, and 2) eval causes all outer variables to be maybe_assigned anyway. Bug: chromium:1074737 Change-Id: I3febca479ddd1f3c62eae299190b06c0b4cd3746 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2187272 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Georg Neis authored
... via a comment in the API and a CHECK in Isolate::RunHostInitializeImportMetaObjectCallback. Also restructure things a little bit such that this function really just runs the callback and doesn't deal with module internals. Memoization now happens in the SourceTextModule class. Bug: v8:7044 Change-Id: I5b850ae629c3638c4b30dfdeaa996642a33d14dc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2190413Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Bug: chromium:1079066 Change-Id: Ideb6704ce6ff0754250ba8dda4addf0841330db4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2190418Reviewed-by:
-
Daniel Bevenius authored
It looks like the usages of these were removed in Commit 8a1bafaf ("Reland "[platform] Implement TaskRunners in the DefaultPlatform"). Change-Id: I61865548020b6dc0ee7d658080ad148c7ffd6e42 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2187500Reviewed-by:
-
Manos Koukoutos authored
Changes: - Extend wasm/wasm-module-builder.cc to handle reference types. - Add testing infrastructure to wasm-macro-gen.h for reference types. - Add cc tests for ref types in blocks and globals. Bug: v8:7748 Change-Id: I527252a768469e1493ecee9ecf4b4afaf8a8013b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2182377Reviewed-by:
-
