• Clemens Backes's avatar
    [wasm][debug] Make recompilation isolate-independent · 14984372
    Clemens Backes authored
    Passing an isolate to {RecompileNativeModule} feels wrong, since
    compilation and the generated code are totally isolate-independent. In
    fact, the isolate is only used for updating counters.
    Instead of passing the counters instead, this CL just refactors the code
    to support a nullptr for the counters everywhere (some code paths
    already supported that). The few recompilation would not make a
    significant difference in the histograms anyway, and even have the risk
    of skewing the data.
    
    Drive-by 1: Rename {TierUp} to {StartTierUp} and update comments.
    Drive-by 2: Remove non-actionable TODO.
    
    R=thibaudm@chromium.org
    
    Bug: v8:10359
    Change-Id: Ic027f939bbc55398b90784922130fe1fe5573b0c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2187638Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67708}
    14984372
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...