- 04 Dec, 2019 15 commits
-
-
Leszek Swirski authored
Looks like even the small amount of logic needed to extract ReadOnlyRoots from a const Isolate* (e.g. a HeapObject check) is enough to cause regressions. Revert these predicates to take non-const Isolate*, while keeping const Isolate* elsewhere. If we ever need const Isolate* for the oddball predicates, we can add it in addition to the non-const one. Bug: chromium:1029457 Bug: chromium:1030001 Bug: chromium:1030003 Bug: chromium:1030102 Change-Id: Ia6fa45f282a1a1961c0afa8ed973baebf6fbafd3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1948721Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#65331}
-
Maya Lekova authored
Bug: v8:10032 Change-Id: Iff7ea0ce0f60b734a6f97b5bde068fa30a4774af Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1950484 Auto-Submit: Maya Lekova <mslekova@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#65330}
-
Michael Starzinger authored
This fixes the operation functions (i.e. WebIDL interface member and namespace member operations) for WebAssembly to not have 'prototype' properties and not be marked as constructors. R=ahaas@chromium.org TEST=mjsunit/wasm/js-api BUG=chromium:1027945 Change-Id: I4db753a9ca570b95c45cb033c36de65bcafafe8f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1950483Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#65329}
-
Maya Lekova authored
Bug: v8:7790 Change-Id: I75be15cae0b7ddc3ad5650008fdb3af0df7157f9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1950486 Commit-Queue: Maya Lekova <mslekova@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#65328}
-
Michaël Zasso authored
This fixes a compilation error with Xcode. Change-Id: Iaab7cab0d3200c5622f306c7ad0926931d5dce47 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1948716Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Michaël Zasso <mic.besace@gmail.com> Cr-Commit-Position: refs/heads/master@{#65327}
-
Ng Zhi An authored
This helper method is no longer needed since we have removed all usages of indexes for the purpose of accessing stack spill slot. The parameter names for FillStackSlotsWithZero in the header file is also corrected to match the names in the implementation. Bug: v8:9909 Change-Id: I6093f020e05701ff8e8d6362015d2e07165b2397 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1950224Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#65326}
-
Shu-yu Guo authored
Forgot to pass the method name to the message template. Bug: v8:9800 Change-Id: Id1b53b166a6908f6d906abb7a820bbf201e906fa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1947326 Auto-Submit: Shu-yu Guo <syg@chromium.org> Reviewed-by:
Joshua Litt <joshualitt@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#65325}
-
Ng Zhi An authored
Change-Id: Ia5c6793f22b3eeff3614542e455d46daa76657a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1948792Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#65324}
-
Ng Zhi An authored
Missed out ppc in https://crrev.com/c/1947350 Bug: v8:9909 Change-Id: I1cdd02b75fda093d279ec9f4e8d99835a3e6c962 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1950223Reviewed-by:
-
Ng Zhi An authored
Bug: v8:9561 Change-Id: I39a3148570664909eb08f1559b2cb418477a6c15 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1948717 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#65322}
-
Clemens Backes authored
Imports can also have associated names, and in fact we generate these names for asm.js. Thus in logging, just append this name to the generated signature. R=jkummerow@chromium.org Bug: chromium:1030103 Change-Id: I3969bcf8d1d17f4256b5a0643acdf8a24766f889 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1948705 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#65321}
-
Ng Zhi An authored
Bug: v8:9909 Change-Id: I997ae6f19c580f08eb9ff8ee039e0dd647091616 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1947350 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Clemens Backes authored
This was probably meant by the TODO removed in https://crrev.com/c/1946354, I just failed to see it because the TODO was placed at the wrong place. The fix triggered a bug in the profiler, which made the wrong assumption that the passed wasm name is null-terminated. This is also fixed in this CL. R=jkummerow@chromium.org, petermarshall@chromium.org Change-Id: Ibf798e7511e61f6b305dd2d05d1aeca43be774a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1948704Reviewed-by:
-
Simon Zünd authored
The ScopeIterator only requires accurate information for the whole script during local debug-evaluate, when the accurate scope information is used to build stack local blacklists. Otherwise it is enough to only reparse the closure. This should recover some performance during stepping, especially with large stacks and scripts. Drive-by: Remove unused COLLECT_NON_LOCALS enum option. Bug: chromium:1028093, v8:9938 Change-Id: I6b3a34e9015e564d683e76b88388daabc426e1cb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1948715 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#65318}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/a82ba26..e35470d Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/ca84a42..10bac4e Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/6d31ed5..9777ab3 Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/a841030..4225f68 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I6f02720a886864a85623ad8d6a469da8ff4d88ae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1947672Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#65317}
-
- 03 Dec, 2019 15 commits
-
-
Milad Farazmand authored
Port 9fcbb5e3 Original Commit Message: Replace unsigned extract lane followed by sign extend as added here https://chromium-review.googlesource.com/c/v8/v8/+/1846711 with a signed extract lane for I8x16 and I16x8. R=george.wort@arm.com, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I09254621c45298a431da44cc1670a90c7a8add0b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1949062Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#65316}
-
Jiayao Lin authored
Change-Id: I47f11509a4e0022ec0f50fdfd29f7cc3d4d547bd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1949054Reviewed-by:
-
Georg Neis authored
Bug: v8:7790 Change-Id: Ic82dbf1497913012138a62f22c53b936114df3e3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1948708 Auto-Submit: Georg Neis <neis@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Clemens Backes authored
Currently, we show wasm frames, js frames, and js-to-wasm frames (the latter two are identified as "OPTIMIZED"). This CL makes us also show wasm-to-js frames in CPU profiling. R=petermarshall@chromium.org Bug: chromium:1029470 Change-Id: I2d09f73e7d7e62867554f2a95dc8ad4500a2cde1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1948706Reviewed-by:
-
Nico Hartmann authored
Bug: chromium:1029576 Change-Id: If647f764da2682a0f278b9b8060d0665fab1c40c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1948711 Commit-Queue: Georg Neis <neis@chromium.org> Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#65312}
-
Deepti Gandluri authored
Bug: chromium:1001376 Change-Id: I63811e33272715dd5b87a6d58ab2d48d3fc096a7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1948791Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#65311}
-
Seth Brenith authored
I noticed that the generated code from the Torque macro EnsureArrayLengthWritable included an imul instruction, even though the inputs to that instruction are both constants. This change adds the ability for MachineOperatorReducer to get rid of that operation. Change-Id: Ia2050c888d76f110d1290fd9eab13853c3353a63 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1941138 Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#65310}
-
Ng Zhi An authored
Bug: v8:9813 Change-Id: I8907a207448a6d3a38b5454107100959d485b8e6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1925614Reviewed-by:
-
Joshua Litt authored
This reverts commit 3114000a. Reason for revert: Clusterfuzz issue should be fixed. Original change's description: > Revert "[replaceAll] Stage String.prototype.replaceAll." > > This reverts commit 825f65d3. > > Reason for revert: Clusterfuzzed > Bug: chromium:1028475 > > Original change's description: > > [replaceAll] Stage String.prototype.replaceAll. > > > > Intent to ship thread: > > https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/raep1X9R_SE > > > > Bug: v8:9801 > > Change-Id: I61c559b82b4119084420ffb0a14a27774e37c760 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1930608 > > Reviewed-by: Adam Klein <adamk@chromium.org> > > Commit-Queue: Joshua Litt <joshualitt@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#65161} > > TBR=adamk@chromium.org,joshualitt@chromium.org > > Change-Id: I7fa44eda475b8f421f74491e60a3131d381eb789 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: v8:9801 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1935024 > Reviewed-by: Joshua Litt <joshualitt@chromium.org> > Commit-Queue: Joshua Litt <joshualitt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65175} TBR=adamk@chromium.org,joshualitt@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1028475, v8:9801 Change-Id: Idb5fbd1ec38084222357aeb2d9ff05d703f10eb5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1946737Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Joshua Litt <joshualitt@chromium.org> Cr-Commit-Position: refs/heads/master@{#65308}
-
George Wort authored
Replace unsigned extract lane followed by sign extend as added here https://chromium-review.googlesource.com/c/v8/v8/+/1846711 with a signed extract lane for I8x16 and I16x8. Change-Id: I5a701417b772d12f5ef038efbb081716bb27e25a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1873700 Commit-Queue: Martyn Capewell <martyn.capewell@arm.com> Reviewed-by:
-
Ng Zhi An authored
Whenever we spill, num_used_spill_bytes_ is already updated using RecordSpillSpillSlot, so we don't need to add the number of locals. Bug: v8:9909 Change-Id: Ieecf957e71e0711be744a3f378d8ae11b941fc5b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1947349Reviewed-by:
-
Emanuel Ziegler authored
The following changes were introduced with the recent proposal update: - OOB access with 0 length traps - Double drop of segments is allowed - Dropped segments are treated like having size 0 (OOB error) - Active segments are dropped right after initialization R=ahaas@chromium.org Change-Id: I4e9fc4d9212841c7d858585c672143f99287520d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1946355Reviewed-by:
-
Igor Sheludko authored
Bug: chromium:1029658 Change-Id: I4cb201bbf0a05d2673fcb8a5d19e34a969294c5e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1946335 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Calculate the number of bytes of the stack frame used in PatchPrepareStackFrame using the size of the spill instead of the number of slots. We only need the number of bytes spilled (without adding the number of locals) because whenever we spill, we already track the largest offset, with RecordUsedSpillSlot. GetTotalFrameSlotCount can also be changed to remove the num_locals, in a future patch. Change-Id: I08fe3e81eaebf5f2cf1e11292645663474483447 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1945944 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/00a14de..a82ba26 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/0317de9..ca84a42 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/5ae4817..6d31ed5 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/ae5343c..d1940b1 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I9bc8f7f48dccef25770eeaa081b36444b79b0913 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1948103Reviewed-by:
-
- 02 Dec, 2019 10 commits
-
-
Jakob Kummerow authored
CSA::TryLookupElement must check the upper bound for dictionary-mode indices. The "stable map + accessor" branch of FastGetOwnValuesOrEntries must construct its LookupIterator such that it handles the named/indexed distinction correctly. Bug: chromium:1029338,chromium:1029369 Change-Id: I17e74ed24c260c5cfc20c61616e75db7d347f7a5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1943164 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#65301}
-
Georg Neis authored
These hints are different from the rest (they only ever grow) and there's no need to have them in each environment. Bug: v8:7790 Change-Id: I56ed9671f602bcb6faba4003d84fee8b1d6e0128 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1944156 Commit-Queue: Georg Neis <neis@chromium.org> Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
When converting a Smi to a String, we can skip the check for a cached array index on the result in case of a number-to-string cache hit. When trying to convert a String back to an index, the inlined fast path can check for a cached index (in addition to checking for a cached known negative). Locally this yields about 5% on the JSTests/Proxies/GetIndex* tests. Bug: chromium:1028021 Change-Id: I117eae01b1ad9c5d107ad7e598464b96dae9a6b9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1943160 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Maya Lekova authored
Add serialization of the virtual closures for Function.ptototype.apply and Function.prototype.call. Also add tests for those. Bug: v8:7790 Change-Id: I26374009c09958943ef36eae283a270875234e40 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1943155 Commit-Queue: Maya Lekova <mslekova@chromium.org> Auto-Submit: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Maya Lekova authored
This reverts commit c509bb8c. Reason for revert: Breaks arm64 - sim - MSAN, see https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/30050 Original change's description: > [wasm] Share native modules compiled from the same bytes > > Cache native modules in the wasm engine by their wire bytes. This is to > prepare for sharing {Script} objects between multiple {WasmModuleObject} > created from the same bytes. This also saves unnecessary compilation > time and memory. > > R=clemensb@chromium.org > > Bug: v8:6847 > Change-Id: Iad5f70efbfe3f0f134dcb851edbcec50691677e0 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1916603 > Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65296} TBR=clemensb@chromium.org,thibaudm@chromium.org Change-Id: I908b0f59bce26678d0b5d7fddc986384c40b4709 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6847 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1946334Reviewed-by:
-
Thibaud Michaud authored
Cache native modules in the wasm engine by their wire bytes. This is to prepare for sharing {Script} objects between multiple {WasmModuleObject} created from the same bytes. This also saves unnecessary compilation time and memory. R=clemensb@chromium.org Bug: v8:6847 Change-Id: Iad5f70efbfe3f0f134dcb851edbcec50691677e0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1916603 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by: -
Joshua Litt authored
Bug: v8:9838, chromium:1028016 Change-Id: Iae195ac12c8fc01506f04ed5e62fc3c0983c56e0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1944280Reviewed-by:
-
Milad Farazmand authored
Change-Id: I01a449f098c7be3f1e071f57542dac6b67fb366d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1944279Reviewed-by:
-
Georg Neis authored
... in order to be in sync with JSNativeContextSpecialization. This probably doesn't allow any more optimizations but avoids confusing misses in the broker trace. Bug: v8:7790 Change-Id: Ia99a5828651468af8450028a351692482c21670c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1944155 Commit-Queue: Georg Neis <neis@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
-
Dan Elphick authored
Removes the following functions: Flush AppendChars WriteAsCFile (only from header since impl was already removed) and moves local function AppendChars into anonymous namespace block. Bug: v8:9810 Change-Id: Icc3ca8458eed4711f25514ac71aa0e6b413ed281 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1921797 Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
