• Leszek Swirski's avatar
    [isolate] Revert oddball checks to non-const Isolate* · 29af4273
    Leszek Swirski authored
    Looks like even the small amount of logic needed to extract ReadOnlyRoots
    from a const Isolate* (e.g. a HeapObject check) is enough to cause
    regressions.
    
    Revert these predicates to take non-const Isolate*, while keeping const
    Isolate* elsewhere. If we ever need const Isolate* for the oddball
    predicates, we can add it in addition to the non-const one.
    
    Bug: chromium:1029457
    Bug: chromium:1030001
    Bug: chromium:1030003
    Bug: chromium:1030102
    Change-Id: Ia6fa45f282a1a1961c0afa8ed973baebf6fbafd3
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1948721Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Commit-Queue: Igor Sheludko <ishell@chromium.org>
    Auto-Submit: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65331}
    29af4273
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...