- 19 Dec, 2018 24 commits
-
-
Dan Elphick authored
The TODOs are wrong for now since even without full codegen, it's still possible for it to be compiled, so this just removes them Bug: v8:8562 Change-Id: Ia9f2539e22364b31c0b45b0408dfe434f212c72a Reviewed-on: https://chromium-review.googlesource.com/c/1384311Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#58367}
-
Clemens Hammacher authored
No need for empty header files and empty implementation files (which will be compiled even though they are empty). R=ishell@chromium.org Bug: v8:8562 Change-Id: Icd54b0cab7dba991d11c26262deb2b034f67869e Reviewed-on: https://chromium-review.googlesource.com/c/1384305Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#58366}
-
Clemens Hammacher authored
The platform-specific simulators are only included on the respective hardware, so no need to guard against other platforms. Also, unify where the USE_SIMULATOR macro is evaluated. Make it cover the whole implementation file. Also, make sure to include the respective header file first, as suggested by the style guide, and fix up includes in general. R=ishell@chromium.org Bug: v8:8562, v8:7490 Change-Id: Ifc6a87030364eab1e6a6fcbda008607ccd1c1f2f Reviewed-on: https://chromium-review.googlesource.com/c/1384090Reviewed-by:
-
Igor Sheludko authored
Bug: v8:8477, v8:8562 Change-Id: I0dab49a03b74abc68600885f4951c5cb727a3d73 Reviewed-on: https://chromium-review.googlesource.com/c/1366736Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#58364}
-
Mythri authored
Don't allocate feedback vectors and feedback metadata in lite mode. Also updates to skip tests that require feedback vectors. This is a reland of https://chromium-review.googlesource.com/c/v8/v8/+/1384087 after skipping the failing tests. Bug: v8:8394 Change-Id: I7766533b85a144e62996ceed8d542cdc534feeb5 Reviewed-on: https://chromium-review.googlesource.com/c/1384307Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Sergiy Belozorov authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/8ee3e8b..9945d79 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/7d88270..5cce74c Rolling v8/third_party/android_tools: https://chromium.googlesource.com/android_tools/+log/6fecaa5..e958d6e Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/368ebf1..203676d Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/7fa4fbc..c6a8d11 TBR=machenbach@chromium.org Change-Id: I55cd001dd1dd6d4c37dd2bd0c59ea3cb8ad8ad00 Reviewed-on: https://chromium-review.googlesource.com/c/1384308Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#58362}
-
Igor Sheludko authored
Bug: v8:8477, v8:8562 Change-Id: I37361ded733d21a5814a2a23a4155d7e8b562446 Reviewed-on: https://chromium-review.googlesource.com/c/1384092Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#58361}
-
Igor Sheludko authored
Also added != 0 for readability in checks like: if (FIELD_SIZE(kFooOffset) != 0) {...} Bug: v8:8477, v8:8562 Change-Id: Ibc305103475e6ec029e89e7ad095ec0a1fa30189 Reviewed-on: https://chromium-review.googlesource.com/c/1382743 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#58360}
-
Clemens Hammacher authored
Many callers of {DoReturn} either already call {EndControl}, or pop the control afterwards, hence we do not need to {EndControl}. Hence only call {EndControl} when really needed. R=herhut@chromium.org Bug: v8:8423 Change-Id: Ie4e7b2dd6918cc0f9619a72d624014222f58a251 Reviewed-on: https://chromium-review.googlesource.com/c/1384085Reviewed-by:Stephan Herhut <herhut@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#58359}
-
Sigurd Schneider authored
This addresses most of the regression in of Kraken's json-stringify-tinderbox-orig with 31bit Smis: Many object properties become heap numbers, and printing an integer which is represented as a double is slower than printing the integer directly. Change-Id: I9a14c4da61721b6c3f22e88145acc6a61ed4a419 Bug: v8:8344 Reviewed-on: https://chromium-review.googlesource.com/c/1382741Reviewed-by:
-
Toon Verwaest authored
We don't eagerly throw for assignments to calls; see v8:4480. They are simply turned into assignments to Property instead. We need to record a declaration error, however. Otherwise we'll end up with a Property in a declaration context. To reduce the scope of the lazy throwing, in this fix I record a pattern error instead, making calls as assignment target in a destructuring assignment context throw eagerly. Bug: chromium:916288 Change-Id: If94a46b5d2b65c3549c641e0e19135c6c8af7a9a Reviewed-on: https://chromium-review.googlesource.com/c/1384084Reviewed-by:
-
Igor Sheludko authored
These load operations will decompress values if pointer compression is enabled. Bug: v8:7703 Change-Id: I4c5cef39a735f3b03e36d27c0e5e7c21653bbbc0 Reviewed-on: https://chromium-review.googlesource.com/c/1382742 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This reverts commit 62e86b88. Reason for revert: Fails on arm sim lite debug: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20arm%20-%20sim%20-%20lite%20-%20debug/1075 Original change's description: > Do not allocate feedback vectors and feedback metadata in lite mode > > Don't allocate feedback vectors and feedback metadata in lite mode. > Also updates to skip tests that require feedback vectors. > > Bug: v8:8394 > Change-Id: I22c64a32c44bb8f25fb09003d6e9fc5a04e84f8a > Reviewed-on: https://chromium-review.googlesource.com/c/1378173 > Commit-Queue: Mythri Alle <mythria@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58351} TBR=rmcilroy@chromium.org,yangguo@chromium.org,mlippautz@chromium.org,mythria@chromium.org Change-Id: I88fd37ea4e21aa2cc81eceb87ddb35c23224beae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8394 Reviewed-on: https://chromium-review.googlesource.com/c/1384087Reviewed-by:
-
Sigurd Schneider authored
Change-Id: I68ede2cda0441cd9a032318462fe3a085480a1dd Bug: v8:8344 Reviewed-on: https://chromium-review.googlesource.com/c/1380111Reviewed-by:
-
Toon Verwaest authored
- Directly declares the special catch variable from the parser-base. - Tracks Scope on PreParserBlock and finds conflicting lexical declarations by simply walking the VariableMap of the block inserted for the pattern; or the catch variable in case of identifier. - This also enables throwing errors for duplicate let in the preparser. We may have to back that out if it breaks something. Bug: v8:2728, v8:7828 Change-Id: Id2eea62062533eb99cd6670c42a4b1da87139008 Reviewed-on: https://chromium-review.googlesource.com/c/1382095Reviewed-by:
-
Igor Sheludko authored
and fix platform builtins. This CL also introduces MacroAssembler::xxx_tagged() operations which operate on potentially compressed tagged values without doing decompression. This CL also drive-by fixes compilation failures when pointer compression is enabled. Bug: v8:7703 Change-Id: Id417f2a78907e8911aaa79ef404f5bcc87d9a3b8 Reviewed-on: https://chromium-review.googlesource.com/c/1382740Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Mythri authored
Don't allocate feedback vectors and feedback metadata in lite mode. Also updates to skip tests that require feedback vectors. Bug: v8:8394 Change-Id: I22c64a32c44bb8f25fb09003d6e9fc5a04e84f8a Reviewed-on: https://chromium-review.googlesource.com/c/1378173 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
Moving the declaration of operator<< from objects-printer.cc to heap-object.h makes sure that it is visible. Change-Id: I316db9c03a464974129b8e9c776423bb80066cdd Reviewed-on: https://chromium-review.googlesource.com/c/1382737Reviewed-by:
-
Sigurd Schneider authored
This refactoring reduces the LoC after preprocessor expansion by 370,322 gen ( 21 files): 71,503 to 1,631,168 ( 23x) src ( 624 files): 367,639 to 53,231,764 ( 145x) test ( 392 files): 490,770 to 37,450,839 ( 76x) third_party ( 432 files): 239,085 to 9,547,902 ( 40x) total ( 1521 files): 1,183,681 to 102,836,194 ( 87x) gen ( 21 files): 71,503 to 1,613,222 ( 23x) src ( 624 files): 367,634 to 52,964,046 ( 144x) test ( 392 files): 490,771 to 37,366,181 ( 76x) third_party ( 432 files): 239,085 to 9,547,902 ( 40x) total ( 1521 files): 1,183,677 to 102,465,872 ( 87x) Bug: v8:8562 Change-Id: Ib4e771c37471a2ff19c5538e62c038943cc74eaf Reviewed-on: https://chromium-review.googlesource.com/c/1382469Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
-
tzik authored
This CL moves variables that control MicrotaskQueue to MtQ itself. Namely, * is_running_microtasks_ and microtask_completed_callbacks_ from v8::internal::Isolate * microtasks_depth_, microtasks_suppressions_ and debug_microtask_depth_ from v8::internal::HandleScopeImplementer. As the current implementation has these variables one per-Isolate rather than per-MicrotaskQueue, this is needed to have multiple MicrotaskQueues for an Isolate. Bug: v8:8124 Change-Id: Id63075cbfb59cf5b7f45a4184affb206400150da Reviewed-on: https://chromium-review.googlesource.com/c/1358029 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Andreas Haas authored
The function InstanceBuilder::ProcessImports got long and hard to understand. This CL is the third change of a series which aims at extracting parts of ProcessImports into specialized functions. This CL extracts the processing of imported globals into a separate function. Aside from copying the code, I made the following changes: * Rename {index} to {import_index}. This CL does minimal changes to the processing of globals itself. That code looks quite complex at the moment. Therefore I want to do the refactoring of that code in separate CLs, so that each CL is smaller and more understandable. R=clemensh@chromium.org Bug: v8:8562 Change-Id: Ie553a2c9031cef07f0b9925144c79248084e428d Reviewed-on: https://chromium-review.googlesource.com/c/1382732 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Andreas Haas authored
The function InstanceBuilder::ProcessImports got long and hard to understand. This CL is the third change of a series which aims at extracting parts of ProcessImports into specialized functions. This CL extracts the processing of imported memory into a separate function. Aside from copying the code, I made the following changes: * Rename {index} to {import_index}. * Add one `return false;` after reporting a LinkError. - I think it should have been this way all along. R=clemensh@chromium.org Bug: v8:8562 Change-Id: I34d68d7bc1013c2743a68778dfc22a2d8e1d46af Reviewed-on: https://chromium-review.googlesource.com/c/1382731 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Yang Guo authored
Bug: v8:8558 Change-Id: Ib179947fb1b00f32a574ae3084e3107cc264a851 Reviewed-on: https://chromium-review.googlesource.com/c/1369951 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
tzik authored
On MIPS and MIPS64, UseScratchRegisterScope has only one register for the scratch register [1,2], and TurboAssembler::CallCFunctionHelper runs out of it as fast_c_call_caller_fp_address uses the register. That causes code generation failures. As a workaround, this CL reduces the number of nested UseScratchRegisterScope where the code generation is failing. [1]: https://chromium.googlesource.com/v8/v8.git/+/dde25872f58951bb0148cf43d6a504ab2f280485/src/mips/assembler-mips.cc#310 [2]: https://chromium.googlesource.com/v8/v8.git/+/dde25872f58951bb0148cf43d6a504ab2f280485/src/mips64/assembler-mips64.cc#287 Change-Id: I0813c656cafdb09ccd6f53d51f3620385e00022f Reviewed-on: https://chromium-review.googlesource.com/c/1379590Reviewed-by:
-
- 18 Dec, 2018 16 commits
-
-
Toon Verwaest authored
Now just accumulate right before we might validate a property and once we're done, so we're guaranteed to catch all PatternErrors. Bug: v8:8607 Change-Id: Ibc5bc7773756f4827868ca01d0f9fb0c5545e59b Reviewed-on: https://chromium-review.googlesource.com/c/1382749 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#58343}
-
Clemens Hammacher authored
The DISALLOW_COPY_AND_ASSIGN has the same semantics, as long as you do not explicitly add a move constructor or move assignment operator. This CL documents this better and removes the DISALLOW_COPY_AND_MOVE_AND_ASSIGN macro. R=tebbi@chromium.org Bug: v8:8562 Change-Id: I1b742ee1a106d85d59a67c90341fafec2473e925 Reviewed-on: https://chromium-review.googlesource.com/c/1382465Reviewed-by:
-
Andreas Haas authored
The function InstanceBuilder::ProcessImports got long and hard to understand. This CL is the second change of a series which aims at extracting parts of ProcessImports into specialized functions. This CL extracts the processing of imported tables into a separate function. Aside from copying the code, I made the following changes: * Rename {index} to {import_index}. * Rename {table_num} to {table_index}. R=clemensh@chromium.org Bug: v8:8562 Change-Id: I37398f0c8feccae3647a7817d7d4d6d0d87fd5a9 Reviewed-on: https://chromium-review.googlesource.com/c/1382470 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: -
Camillo Bruni authored
Avoiding malloc and unique_ptr seems to have positive effects on a representative facebook and cnn workload. This makes arrow functions and eager functions potentially more expensive since the DataGatheringScope is now always stack-allocated and only the full initialization happens conditionally. Change-Id: Ibf1c1308a7db464f7c5d2bafd61560e4cabf0ce9 Reviewed-on: https://chromium-review.googlesource.com/c/1382733Reviewed-by:
-
Toon Verwaest authored
Otherwise the error would have been dropped between the previous accumulate and the subsequent ValidateExpression. Bug: v8:8607 Change-Id: I29f5d5b6887b57f4b70369ba370fe0b44b1d6798 Reviewed-on: https://chromium-review.googlesource.com/c/1382744Reviewed-by:
-
Mythri authored
When we call ObjectToString on JSValues we only looked at string tags on the prototype map of the JSValue's value type and do not check the tags on the JSValue's prototype chain which may be non-trivial if subclassing is involved. For ex: if we have a class Test extend Number, we only looked for tags on the Number prototype and not on the Test prototype. This cl fixes the builtin to also check for these cases. Bug: v8:7706 Change-Id: I9f0e3bb6499646bf27b92bf4fb4e9014f6efa56b Reviewed-on: https://chromium-review.googlesource.com/c/1378176Reviewed-by:
-
Jakob Kummerow authored
Bug: v8:3770 Change-Id: If88c285bf1528f03401d3a83349b61435ac79f85 Reviewed-on: https://chromium-review.googlesource.com/c/1382455 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
Bug: v8:5402 Change-Id: Ib2d7b24cdcf55e3dfa8d3b1665ac565904ac2112 Reviewed-on: https://chromium-review.googlesource.com/c/1379940Reviewed-by:
-
Jakob Kummerow authored
gm.py has been careful to only use the "pty" module's functionality on Linux, but as it turns out, the module is *so* strongly specific to Linux that even importing it fails on Windows. Making the import of "pty" conditional makes gm.py work on Windows. Change-Id: I0c1fb8a9a0299fde50e252337551d9395039f14d Reviewed-on: https://chromium-review.googlesource.com/c/1382738Reviewed-by:
-
Jakob Kummerow authored
instead of Object* (which is deprecated) or ObjectPtr (which is unsuitable for cases where we need to control the ABI exactly). Callers in generated code expect a plain tagged value, so return precisely that. Same for C++ Builtins. Bug: v8:3770 Change-Id: Id12f0d9830f7caf2a16aa973b8297f70d65241f5 Reviewed-on: https://chromium-review.googlesource.com/c/1382466Reviewed-by:
-
Georg Neis authored
This is a reland of fac6f63e, after adding initialization of unused element slots. Original change's description: > Use CopyElements (which uses memcpy) to copy FixedDoubleArray. > > This improves the performance of ExtractFixedArray and > CloneFastJSArray for double arrays, which in turn improve the > performance of cloning double arrays with slice() or spreading. > > This, however, does not improve performance of spreading holey > double arrays, because spreading needs extra work to convert > holes to undefined. > > Bug: v8:7980 > Change-Id: Ib8aed74abbb0b06982a3b754e134fa415cb7de2d > Reviewed-on: https://chromium-review.googlesource.com/c/1280308 > Reviewed-by: Michael Stanton <mvstanton@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Commit-Queue: Hai Dang <dhai@google.com> > Cr-Commit-Position: refs/heads/master@{#56680} Bug: v8:7980 Change-Id: I899af60c061b9cd6eb619c247c5fc515b92e9fd7 Reviewed-on: https://chromium-review.googlesource.com/c/1382735 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Toon Verwaest authored
This changes how rewind upon preparser abort works. It now rewinds to the start of the parameter scope. In the case of "function X(" it is before the "(". In the case of arrow functions it's before the start of the arrow function. This allows us to reparse the arrow function from the start so all parameters are declared properly. Bug: v8:2728, v8:7390 Change-Id: I1c40056a49ec198560e63cd73949a59221ee0401 Reviewed-on: https://chromium-review.googlesource.com/c/1382736Reviewed-by: -
Andreas Haas authored
The function InstanceBuilder::ProcessImports got long and hard to understand. This CL is the first of a series which aims at extracting parts of ProcessImports into specialized functions. This CL extracts the processing of imported functions into a separate function. Aside from copying the code, I made the following changes: * Use {enabled_} instead of a newly created WasmFeatures object. - I think this is more correct anyways. * Rename {index} to {import_index}. * Load {native_module} from {instance} for every function, instead of loading it once for all imports. R=clemensh@chromium.org Bug: v8:8562 Change-Id: I9533f302929eedd395962253c340ba35324df631 Reviewed-on: https://chromium-review.googlesource.com/c/1382467 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: -
Sergiy Belozorov authored
TBR=machenbach@chromium.org No-Try: true Bug: chromium:893593 Change-Id: Ia1512e55426dc64f260b074dd964cc7dcc822dcf Reviewed-on: https://chromium-review.googlesource.com/c/1382457 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by:
-
Tamer Tas authored
Adds a flag to specify whether to disable the linter caching. R=machenbach@chromium.org,sergiyb@chromium.org CC=yangguo@chromium.org Bug: v8:8482 Change-Id: I62a9b7cffb3adb50b136659568ad52078675ca4b No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1370029Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#58329}
-
Jakob Gruber authored
This is to fix the pointer compression bot, which tests only x64. Other 64-bit architectures will need similar work in the future. On x64 with pointer compression, smi-untagging can be folded into the Operand calculation since the left-shift for multiplying by kSystemPointerSize is greater than the right-shift for untagging. Bug: v8:7777 Change-Id: I5c46e9d3f51580341cfc3c12a7e32d17cf0b63ee Reviewed-on: https://chromium-review.googlesource.com/c/1381452 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
