Commit 27d1e9f2 authored by Dan Elphick's avatar Dan Elphick Committed by Commit Bot

[cleanup] Remove TODOs now that full codegen is gone

The TODOs are wrong for now since even without full codegen, it's still
possible for it to be compiled, so this just removes them

Bug: v8:8562
Change-Id: Ia9f2539e22364b31c0b45b0408dfe434f212c72a
Reviewed-on: https://chromium-review.googlesource.com/c/1384311Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58367}
parent 86024575
......@@ -522,7 +522,6 @@ MaybeHandle<SharedFunctionInfo> GenerateUnoptimizedCodeForToplevel(
functions_to_compile.pop_back();
Handle<SharedFunctionInfo> shared_info =
Compiler::GetSharedFunctionInfo(literal, script, isolate);
// TODO(rmcilroy): Fix this and DCHECK !is_compiled() once Full-Codegen dies
if (shared_info->is_compiled()) continue;
if (UseAsmWasm(literal, parse_info->is_asm_wasm_broken())) {
std::unique_ptr<UnoptimizedCompilationJob> asm_job(
......@@ -589,7 +588,6 @@ bool FinalizeUnoptimizedCode(
inner_job->compilation_info()->literal(), parse_info->script(),
isolate);
// The inner function might be compiled already if compiling for debug.
// TODO(rmcilroy): Fix this and DCHECK !is_compiled() once Full-Codegen dies
if (inner_shared_info->is_compiled()) continue;
if (FinalizeUnoptimizedCompilationJob(inner_job.get(), inner_shared_info,
isolate) !=
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment