• Andreas Haas's avatar
    [wasm][cleanup] Extract processing of imported memory · 0a84bc50
    Andreas Haas authored
    The function InstanceBuilder::ProcessImports got long and hard to
    understand. This CL is the third change of a series which aims at
    extracting parts of ProcessImports into specialized functions.
    
    This CL extracts the processing of imported memory into a separate
    function. Aside from copying the code, I made the following changes:
    * Rename {index} to {import_index}.
    * Add one `return false;` after reporting a LinkError.
      - I think it should have been this way all along.
    
    R=clemensh@chromium.org
    
    Bug: v8:8562
    Change-Id: I34d68d7bc1013c2743a68778dfc22a2d8e1d46af
    Reviewed-on: https://chromium-review.googlesource.com/c/1382731
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#58346}
    0a84bc50
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...