• Andreas Haas's avatar
    [wasm][cleanup] Extract processing of imported functions · 68c33b29
    Andreas Haas authored
    The function InstanceBuilder::ProcessImports got long and hard to
    understand. This CL is the first of a series which aims at extracting
    parts of ProcessImports into specialized functions.
    
    This CL extracts the processing of imported functions into a separate
    function. Aside from copying the code, I made the following changes:
    * Use {enabled_} instead of a newly created WasmFeatures object.
      - I think this is more correct anyways.
    * Rename {index} to {import_index}.
    * Load {native_module} from {instance} for every function, instead of
      loading it once for all imports.
    
    R=clemensh@chromium.org
    
    Bug: v8:8562
    Change-Id: I9533f302929eedd395962253c340ba35324df631
    Reviewed-on: https://chromium-review.googlesource.com/c/1382467
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#58331}
    68c33b29
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...