Skip to content

V
V8
Switch branch/tag
  1. 01 Jun, 2021 2 commits
  3. 26 May, 2021 1 commit
  5. 25 May, 2021 1 commit
  7. 20 May, 2021 1 commit
  9. 19 May, 2021 1 commit
  11. 12 May, 2021 1 commit
  13. 29 Apr, 2021 2 commits
  15. 28 Apr, 2021 1 commit
  17. 27 Apr, 2021 1 commit
  19. 22 Apr, 2021 1 commit
  21. 15 Apr, 2021 1 commit
    • Milad Fa's avatar
      PPC/s390: [wasm][x64] Fix OSR shadow stack violation · 80aaae9e
      Milad Fa authored 
      Port 06a2c2e0

Original Commit Message:

    We currently allow OSR (On-Stack Replacement) of arbitrarily deep return
    addresses. This is in direct violation of Intel CET's shadow stack,
    which we plan to enable eventually.

    This change works around this by postponing OSR until after we return to
    the old code. The main changes are:
    - Reserve a slot in Liftoff frames to store the OSR target,
    - Skip the return address modification, and instead store the new code
    pointer in the dedicated slot,
    - Upon returning to the old code, check the slot and do an indirect jump
    to the new code if needed.

    CET also prevents indirect jumps to arbitrary locations, so the last
    point is also a CET violation. Valid indirect jump targets must be
    marked with the ENDBRANCH instruction, which I will do in a follow-up
    CL.

R=thibaudm@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com
BUG=
LOG=N

Change-Id: Id972de1ba7556474cb00b377ea3a38eb4332eae3
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2828870Reviewed-by: 's avatarJunliang Yan <junyan@redhat.com>
Commit-Queue: Milad Fa <mfarazma@redhat.com>
Cr-Commit-Position: refs/heads/master@{#73984}
      80aaae9e
  23. 15 Mar, 2021 1 commit
  25. 10 Mar, 2021 1 commit
  27. 08 Mar, 2021 1 commit
  29. 26 Feb, 2021 1 commit
  31. 25 Feb, 2021 1 commit
  33. 24 Feb, 2021 2 commits
  35. 22 Feb, 2021 3 commits
  37. 19 Feb, 2021 1 commit
  39. 16 Feb, 2021 1 commit
    • Junliang Yan's avatar
      PPC/s390: [liftoff] Cache the instance in a register · a9f2bb0b
      Junliang Yan authored 
      Port adf035fb

Original Commit Message:

    This CL avoids redundant loads of the instance from the frame by caching
    it in a register if possible. This register will be the first one to be
    cleared once we run out of registers (hence it's called a "volatile
    register"). On local tests, this seems to reduce most redundant loads
    within a function, and it also reduces the load for the stack check in
    the function prologue.
    After the stack check, we need to discard the cached instance though,
    since the potential runtime call for the stack check might clobber it.
    This will be addressed in a follow-up CL by re-loading the cached
    instance after the stack check. This is expected to remove another good
    chunk of instance loads, because the instance would initially be
    available in a register when starting the function code.

R=clemensb@chromium.org, midawson@redhat.com, mfarazma@redhat.com
BUG=
LOG=N

Change-Id: I3756ce98d4dfefb44c946a4948f1a6dbe0ce44dd
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2698291Reviewed-by: 's avatarMilad Fa <mfarazma@redhat.com>
Commit-Queue: Junliang Yan <junyan@redhat.com>
Cr-Commit-Position: refs/heads/master@{#72791}
      a9f2bb0b
  41. 11 Feb, 2021 2 commits
  43. 10 Feb, 2021 1 commit
  45. 09 Feb, 2021 2 commits
  47. 01 Feb, 2021 1 commit
  49. 27 Jan, 2021 1 commit
  51. 26 Jan, 2021 1 commit
  53. 13 Jan, 2021 2 commits
  55. 12 Jan, 2021 1 commit
  57. 08 Jan, 2021 1 commit
  59. 22 Dec, 2020 1 commit
  61. 16 Dec, 2020 2 commits