- 24 Oct, 2017 3 commits
-
-
Michael Achenbach authored
This reverts commit a24c7c9a. Reason for revert: Breaks some users' workflow where --arch and --mode are used to determine the build path. Original change's description: > Reuse arch/mode discovery in deopt fuzzer > > Bug: v8:6917 > Change-Id: I1b7169c8702c8649812b17579d38d64de676ed60 > Reviewed-on: https://chromium-review.googlesource.com/723420 > Commit-Queue: Michał Majewski <majeski@google.com> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48838} TBR=machenbach@chromium.org,majeski@google.com Change-Id: If1f6e67eee17f11ec7547943ce084d18242f6875 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6917 Reviewed-on: https://chromium-review.googlesource.com/735442Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#48869}
-
Michael Achenbach authored
This reverts commit f681e530. Reason for revert: Need to revert: https://chromium-review.googlesource.com/c/v8/v8/+/723420 Original change's description: > Deprecated option --shell removed > > Bug: v8:6917 > Change-Id: I4262bc98019a3af0fc2bad7ef12b29ba5d4ea5ea > Reviewed-on: https://chromium-review.googlesource.com/734241 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Michał Majewski <majeski@google.com> > Cr-Commit-Position: refs/heads/master@{#48855} TBR=machenbach@chromium.org,majeski@google.com Change-Id: I8a0065883d41f5011934cdf04263e76801f1910e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6917 Reviewed-on: https://chromium-review.googlesource.com/735150Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#48868}
-
Michal Majewski authored
Bug: v8:6917 Change-Id: I4262bc98019a3af0fc2bad7ef12b29ba5d4ea5ea Reviewed-on: https://chromium-review.googlesource.com/734241Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michał Majewski <majeski@google.com> Cr-Commit-Position: refs/heads/master@{#48855}
-
- 23 Oct, 2017 1 commit
-
-
Michal Majewski authored
Bug: v8:6917 Change-Id: I1b7169c8702c8649812b17579d38d64de676ed60 Reviewed-on: https://chromium-review.googlesource.com/723420 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#48838}
-
- 19 Oct, 2017 4 commits
-
-
Michael Achenbach authored
TBR=sergiyb@chromium.org Bug: v8:6917 Change-Id: I96cedba176cd3c35ca39bb2d4604956cded114fc Reviewed-on: https://chromium-review.googlesource.com/728023Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#48740}
-
Michael Achenbach authored
TBR=sergiyb@chromium.org NOTRY=true Bug: v8:6917 Change-Id: Ia417ab5cf59a6c2894de67d5519394629b6ab1b9 Reviewed-on: https://chromium-review.googlesource.com/727936Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#48735}
-
Michael Achenbach authored
Bug: v8:6917 Change-Id: Ia768c9aaf71e70d1376ae21a35fd539a7315b0cd Reviewed-on: https://chromium-review.googlesource.com/725802 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#48717}
-
Michael Achenbach authored
This ports the build_config json from GN to GYP to prepare deprecating tedious flags passing to the test runner. This also removes two unused GN flags that only hold temporary values. Bug: v8:6917 Change-Id: I976185f1541277dc5c9bfbaa7578f35c19dd254c Reviewed-on: https://chromium-review.googlesource.com/725706 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#48715}
-
- 18 Oct, 2017 2 commits
-
-
Michal Majewski authored
Bug: v8:6917 Change-Id: I45a3a683388341d61989473ebd0b761a1ad8a9e3 Reviewed-on: https://chromium-review.googlesource.com/721659 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#48676}
-
Michael Achenbach authored
This reverts commit 4054cf27. Reason for revert: Just exposes existing issues. Original change's description: > Revert "[test] Fix win-asan symbolizer path" > > This reverts commit 135576ff. > > Reason for revert: V8 Win32 ASAN failures: https://build.chromium.org/p/client.v8/builders/V8%20Win32%20ASAN/builds/73 > > It appears these failures were lurking there already, but were hidden because of the bug this CL fixed. Opened https://crbug.com/v8/6953 about these issues. > > Original change's description: > > [test] Fix win-asan symbolizer path > > > > This makes the symbolizer path relative, as the absolute paths contain > > a drive letter + colon on windows. The colon is confused by the > > sanitizer as an option separator. > > > > The test driver changes the cwd to the V8 root dir in each > > invocation. > > > > Bug: chromium:726584 > > Change-Id: Icf4e5a55bba5dec8e59a3dfe3eccdf7224e65c33 > > Reviewed-on: https://chromium-review.googlesource.com/721124 > > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> > > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#48652} > > TBR=glider@chromium.org,rnk@chromium.org,machenbach@chromium.org,sergiyb@chromium.org,etienneb@chromium.org > > Change-Id: Ic78527950f6a239a03658e042d7244c9781d05db > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:726584 > Reviewed-on: https://chromium-review.googlesource.com/723825 > Reviewed-by: Eric Holk <eholk@chromium.org> > Commit-Queue: Eric Holk <eholk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48653} TBR=glider@chromium.org,rnk@chromium.org,machenbach@chromium.org,eholk@chromium.org,sergiyb@chromium.org,etienneb@chromium.org Change-Id: I8ea3b1d74ece09bed4758522f51cbee56a7792e1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:726584 Reviewed-on: https://chromium-review.googlesource.com/725319Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#48662}
-
- 17 Oct, 2017 2 commits
-
-
Eric Holk authored
This reverts commit 135576ff. Reason for revert: V8 Win32 ASAN failures: https://build.chromium.org/p/client.v8/builders/V8%20Win32%20ASAN/builds/73 It appears these failures were lurking there already, but were hidden because of the bug this CL fixed. Opened https://crbug.com/v8/6953 about these issues. Original change's description: > [test] Fix win-asan symbolizer path > > This makes the symbolizer path relative, as the absolute paths contain > a drive letter + colon on windows. The colon is confused by the > sanitizer as an option separator. > > The test driver changes the cwd to the V8 root dir in each > invocation. > > Bug: chromium:726584 > Change-Id: Icf4e5a55bba5dec8e59a3dfe3eccdf7224e65c33 > Reviewed-on: https://chromium-review.googlesource.com/721124 > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48652} TBR=glider@chromium.org,rnk@chromium.org,machenbach@chromium.org,sergiyb@chromium.org,etienneb@chromium.org Change-Id: Ic78527950f6a239a03658e042d7244c9781d05db No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:726584 Reviewed-on: https://chromium-review.googlesource.com/723825Reviewed-by: Eric Holk <eholk@chromium.org> Commit-Queue: Eric Holk <eholk@chromium.org> Cr-Commit-Position: refs/heads/master@{#48653}
-
Michael Achenbach authored
This makes the symbolizer path relative, as the absolute paths contain a drive letter + colon on windows. The colon is confused by the sanitizer as an option separator. The test driver changes the cwd to the V8 root dir in each invocation. Bug: chromium:726584 Change-Id: Icf4e5a55bba5dec8e59a3dfe3eccdf7224e65c33 Reviewed-on: https://chromium-review.googlesource.com/721124Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#48652}
-
- 16 Oct, 2017 3 commits
-
-
Ben Smith authored
Change-Id: I77b6eb5e949f8b37fa76d2a161d1ec2c1117ab04 Reviewed-on: https://chromium-review.googlesource.com/722078Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#48616}
-
Michal Majewski authored
Bug: v8:6917 Change-Id: Ife79f1d3c60f591c00bb1ecd340a9f1b31b02039 Reviewed-on: https://chromium-review.googlesource.com/720808Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michał Majewski <majeski@google.com> Cr-Commit-Position: refs/heads/master@{#48598}
-
Michael Achenbach authored
Also fix asan environment for testing on windows. TBR=sergiyb@chromium.org Bug: chromium:726584 Change-Id: Ic9e6afa714f4757ad1b0f2ebfa742e742e1c04b9 Reviewed-on: https://chromium-review.googlesource.com/720811 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#48583}
-
- 13 Oct, 2017 3 commits
-
-
Michael Achenbach authored
TBR=ulan@chromium.org Bug: v8:6927 Change-Id: I6e76cc3e967b9136ed50612afb9159a404ccbfad Reviewed-on: https://chromium-review.googlesource.com/718599Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#48538}
-
Michal Majewski authored
Preparation for sharing more code between deopt fuzzer and normal test runner. Bug: v8:6917 Change-Id: Id8022c7597544ffddf5d1b0a0d73bb4a9d163fc3 Reviewed-on: https://chromium-review.googlesource.com/715417 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#48521}
-
Michael Achenbach authored
NOTRY=true TBR=ulan@chromium.org Bug: v8:6927 Change-Id: I84e239c94ed6b545544bc3db30689b8ff1b158ae Reviewed-on: https://chromium-review.googlesource.com/718098 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#48519}
-
- 12 Oct, 2017 1 commit
-
-
Michael Achenbach authored
NOTRY=true TBR=ulan@chromium.org Change-Id: I497f5d0359d32e48cb1c54c958bc9897c168f025 Reviewed-on: https://chromium-review.googlesource.com/715900 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#48500}
-
- 11 Oct, 2017 2 commits
-
-
Michael Achenbach authored
Bug: v8:6917 Change-Id: I3889cd0d059c3473a7b83eb298734a7a6a8a1de5 Reviewed-on: https://chromium-review.googlesource.com/712175Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#48467}
-
Michael Achenbach authored
Currently it's hard to reason about the hung tests on worker processes. This adds simple output when we're trying to kill a hung process. Change-Id: Iae5e14dac70a8149c074043dd00cbf10e4d5f3de Reviewed-on: https://chromium-review.googlesource.com/712455Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#48460}
-
- 10 Oct, 2017 1 commit
-
-
Eric Holk authored
This flag was originally added as a staging mechanism to let us land and test guard regions without the full trap handler feature landing. Additionally, we thought we might enable guard regions without trap handlers on some systems. Trap handlers are now supported, and there's not a real compelling reason for why we need guard regions without trap handlers. Keeping the separate flag leads to confusion, since some code treats guard regions and trap handlers the same, while other code treats them as independent. Removing this flag and its associated special cases makes everything more uniform and predictable. R=gdeepti@chromium.org Change-Id: Icebab91d1f1e0c55e7a35c75b880085d37fa14ae Reviewed-on: https://chromium-review.googlesource.com/706570Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by: Mircea Trofin <mtrofin@chromium.org> Commit-Queue: Eric Holk <eholk@chromium.org> Cr-Commit-Position: refs/heads/master@{#48411}
-
- 05 Oct, 2017 1 commit
-
-
Michael Achenbach authored
Bug: Change-Id: Iddb8dde328af42b99c74195a13975346437c7259 Reviewed-on: https://chromium-review.googlesource.com/700635Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#48310}
-
- 10 Aug, 2017 1 commit
-
-
Enrico Bacis authored
The run_test.py tool test selection only expands asterisks at the end of the test name. This CL introduces glob expansion in test selection (asterisks are expanded anywhere in the path). This is useful when tests that belong to the same area have different prefixes. For example wasm cctests have two different prefixes: 'cctest/test-run-wasm*' and 'cctest/test-wasm*'. With this CL it is possible to specify the selector 'cctest/*wasm*' to run them all. R=machenbach@chromium.org Change-Id: I1c7cc5136b21e71f3eaf69fb98d5dfd77d336e2a Reviewed-on: https://chromium-review.googlesource.com/609000Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Enrico Bacis <enricobacis@google.com> Cr-Commit-Position: refs/heads/master@{#47274}
-
- 27 Jul, 2017 1 commit
-
-
Michael Starzinger authored
Note that this also renames the existing "asm_wasm" variant to use the more appropriate "stress_asm_wasm" name. R=rmcilroy@chromium.org BUG=v8:6409 Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: I1f9550cd03874c678f4583047a4e123a6f090250 Reviewed-on: https://chromium-review.googlesource.com/584879 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#46937}
-
- 18 Jul, 2017 1 commit
-
-
Jakob Kummerow authored
Bug: v8:6550 Change-Id: I888f91db1fd842d1fef8a5fb749da229dfb6ab97 Reviewed-on: https://chromium-review.googlesource.com/575756Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Daniel Clifford <danno@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#46746}
-
- 13 Jul, 2017 1 commit
-
-
Ross McIlroy authored
Removes the --ignition flag which is now on by default. Adds a --stress-fullcodegen flag which enables running all functions supported by fullcodegen to be compiled by fullcodegen. This will enable moving parser internalization later when we are not stressing fullcodegen or compiling asm.js functions. BUG=v8:5203, v8:6409, v8:6589 Change-Id: I7fa68016d4e734755434ec0b4e749ef65ffa7f4e Reviewed-on: https://chromium-review.googlesource.com/565569 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#46635}
-
- 23 Jun, 2017 1 commit
-
-
Michael Achenbach authored
Bug: chromium:662388 Change-Id: Ia50889a6f4313270f1aadd19cc3f91eb25989c96 Reviewed-on: https://chromium-review.googlesource.com/544882 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#46181}
-
- 09 Jun, 2017 1 commit
-
-
Michael Starzinger authored
Both Ignition and TurboFan have been enabled by default for a while. This just disentangles the implication between those two flags and sets the --ignition individually. They can now be controlled individually. R=rmcilroy@chromium.org BUG=v8:6408 Change-Id: I08eca85120160efa5868b5ca36d1613964ed82eb Reviewed-on: https://chromium-review.googlesource.com/527637Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#45800}
-
- 08 Jun, 2017 1 commit
-
-
Michael Starzinger authored
The variant in question was intended to test Crankshaft, which is being deprecated. Note that the variants 'nooptimization' and 'fullcode' still test configuration where TurboFan is not active. R=machenbach@chromium.org BUG=v8:6408 Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: I587c3eee7ba511dfc270aab66b546d2532bc635f Reviewed-on: https://chromium-review.googlesource.com/528133Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#45785}
-
- 07 Jun, 2017 2 commits
-
-
Michael Starzinger authored
The two variants "turbofan" and "turbofan_opt" are not part of any of the default sets of variants that run-tests.py uses. The only way to trigger execution would be via the --variants flag directly, which our infrastructure is not doing. R=machenbach@chromium.org Change-Id: Ifa58cb4a83a3760ffba73e8b40b417a845f53506 Reviewed-on: https://chromium-review.googlesource.com/526637Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#45772}
-
Michael Starzinger authored
This removes the test suite variant for stressing Crankshaft from the list of supported variants. Other stress variants remain untouched. R=machenbach@chromium.org Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: Iad236c2b80a1dea21b8be9b931e6a4e88f3ebcc5 Reviewed-on: https://chromium-review.googlesource.com/527094Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#45758}
-
- 29 May, 2017 1 commit
-
-
Michael Achenbach authored
Tests should instead be skipped or fixed. Existing timeout expectations are either optimistically deleted or replaced by the SLOW keyword. Change-Id: Ic43f52bf18d0702674c95f9263a109041a1c9cd8 Reviewed-on: https://chromium-review.googlesource.com/518122Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#45552}
-
- 24 May, 2017 2 commits
-
-
Michael Achenbach authored
This reverts commit 589a4d1d. Reason for revert: Breaks webkit: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20predictable/builds/11714 Original change's description: > [test] Don't hide crashes in predictable mode > > Bug: v8:6426 > Change-Id: I278dda0d628732bb9c539c2648d2b27bcbc89bf0 > Reviewed-on: https://chromium-review.googlesource.com/512643 > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#45504} TBR=jkummerow@chromium.org,machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Bug: v8:6426 Change-Id: I85c573fa332f436bb57f2747ad98c26e1c1f23bd Reviewed-on: https://chromium-review.googlesource.com/513866Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#45506}
-
Michael Achenbach authored
Bug: v8:6426 Change-Id: I278dda0d628732bb9c539c2648d2b27bcbc89bf0 Reviewed-on: https://chromium-review.googlesource.com/512643Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#45504}
-
- 09 May, 2017 5 commits
-
-
Michael Achenbach authored
This reverts commit dd9dbf4d. Reason for revert: Fixed Bug: v8:6375 Change-Id: Ied3fb991ba6f5774f5a2e6f13947b53f61196650 Reviewed-on: https://chromium-review.googlesource.com/500133Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#45193}
-
Michael Achenbach authored
Before this fix, all existing suites would get wastefully initialized in each subprocess. Bug: v8:6375 Change-Id: I68d961cde143754724735aecbac605852f89c7d9 Reviewed-on: https://chromium-review.googlesource.com/500187Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#45188}
-
Michael Achenbach authored
This reverts commit 9a90717d. Reason for revert: Erroneous submit... Original change's description: > Reland "[test] Don't flatten testcfg globals" > > This reverts commit 4fdf7cdf. > > Reason for revert: Fixed > > Original change's description: > > Revert "[test] Don't flatten testcfg globals" > > > > This reverts commit 4fa473cb. > > > > Reason for revert: Problems when v8 isn't located in a folder called "v8". > > > > Original change's description: > > > [test] Don't flatten testcfg globals > > > > > > This loads each test's testcfg.py as a unique module rather than flattening all into testcfg. Other than accessing LoadTestSuite there should be no references into testcfg files. > > > > > > Bug: v8:6375 > > > Change-Id: If863c1b35096b2589111e8091bb7d68f135da674 > > > Reviewed-on: https://chromium-review.googlesource.com/498807 > > > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > > > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#45178} > > > > TBR=jkummerow@chromium.org,machenbach@chromium.org > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > Bug: v8:6375 > > > > Change-Id: I3600b54279c0d98a39475432c5b2163f510153f0 > > Reviewed-on: https://chromium-review.googlesource.com/500130 > > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#45180} > > TBR=jkummerow@chromium.org,machenbach@chromium.org,v8-reviews@googlegroups.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > Bug: v8:6375 > > Change-Id: I8198b74ff8e1c3aa179769bef24f204dc705da67 > Reviewed-on: https://chromium-review.googlesource.com/500131 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#45181} TBR=jkummerow@chromium.org,machenbach@chromium.org,v8-reviews@googlegroups.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Bug: v8:6375 Change-Id: Id8ab1c3482806b613a024d4fff5c84a7ab0d2b0b Reviewed-on: https://chromium-review.googlesource.com/500132Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#45182}
-
Michael Achenbach authored
This reverts commit 4fdf7cdf. Reason for revert: Fixed Original change's description: > Revert "[test] Don't flatten testcfg globals" > > This reverts commit 4fa473cb. > > Reason for revert: Problems when v8 isn't located in a folder called "v8". > > Original change's description: > > [test] Don't flatten testcfg globals > > > > This loads each test's testcfg.py as a unique module rather than flattening all into testcfg. Other than accessing LoadTestSuite there should be no references into testcfg files. > > > > Bug: v8:6375 > > Change-Id: If863c1b35096b2589111e8091bb7d68f135da674 > > Reviewed-on: https://chromium-review.googlesource.com/498807 > > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#45178} > > TBR=jkummerow@chromium.org,machenbach@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > Bug: v8:6375 > > Change-Id: I3600b54279c0d98a39475432c5b2163f510153f0 > Reviewed-on: https://chromium-review.googlesource.com/500130 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#45180} TBR=jkummerow@chromium.org,machenbach@chromium.org,v8-reviews@googlegroups.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Bug: v8:6375 Change-Id: I8198b74ff8e1c3aa179769bef24f204dc705da67 Reviewed-on: https://chromium-review.googlesource.com/500131Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#45181}
-
Michael Achenbach authored
This reverts commit 4fa473cb. Reason for revert: Problems when v8 isn't located in a folder called "v8". Original change's description: > [test] Don't flatten testcfg globals > > This loads each test's testcfg.py as a unique module rather than flattening all into testcfg. Other than accessing LoadTestSuite there should be no references into testcfg files. > > Bug: v8:6375 > Change-Id: If863c1b35096b2589111e8091bb7d68f135da674 > Reviewed-on: https://chromium-review.googlesource.com/498807 > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#45178} TBR=jkummerow@chromium.org,machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Bug: v8:6375 Change-Id: I3600b54279c0d98a39475432c5b2163f510153f0 Reviewed-on: https://chromium-review.googlesource.com/500130Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#45180}
-