Commit 135576ff authored by Michael Achenbach's avatar Michael Achenbach Committed by Commit Bot

[test] Fix win-asan symbolizer path

This makes the symbolizer path relative, as the absolute paths contain
a drive letter + colon on windows. The colon is confused by the
sanitizer as an option separator.

The test driver changes the cwd to the V8 root dir in each
invocation.

Bug: chromium:726584
Change-Id: Icf4e5a55bba5dec8e59a3dfe3eccdf7224e65c33
Reviewed-on: https://chromium-review.googlesource.com/721124Reviewed-by: 's avatarSergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#48652}
parent 82d8b3ac
......@@ -326,8 +326,9 @@ class GoogleTestSuite(TestSuite):
output = commands.Execute(cmd)
if output.exit_code == 0:
break
print "Test executable failed to list the tests (try %d).\n\nStdout:" % i
print "Test executable failed to list the tests (try %d).\n\nCmd:" % i
print ' '.join(cmd)
print "\nStdout:"
print output.stdout
print "\nStderr:"
print output.stderr
......
......@@ -389,16 +389,18 @@ class StandardTestRunner(base_runner.BaseTestRunner):
# Many tests assume an English interface.
os.environ['LANG'] = 'en_US.UTF-8'
symbolizer = 'external_symbolizer_path=%s' % (
os.path.join(
base_runner.BASE_DIR,
'third_party',
'llvm-build',
'Release+Asserts',
'bin',
'llvm-symbolizer',
)
external_symbolizer_path = os.path.join(
base_runner.BASE_DIR,
'third_party',
'llvm-build',
'Release+Asserts',
'bin',
'llvm-symbolizer',
)
if utils.IsWindows():
# Quote, because sanitizers might confuse colon as option separator.
external_symbolizer_path = '"%s.exe"' % external_symbolizer_path
symbolizer = 'external_symbolizer_path=%s' % external_symbolizer_path
if options.asan:
asan_options = [symbolizer, "allow_user_segv_handler=1"]
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment