Commit e5fb221d authored by Michael Starzinger's avatar Michael Starzinger Committed by Commit Bot

[test] Deprecate and remove 'noturbofan' test variant.

The variant in question was intended to test Crankshaft, which is being
deprecated. Note that the variants 'nooptimization' and 'fullcode' still
test configuration where TurboFan is not active.

R=machenbach@chromium.org
BUG=v8:6408

Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng
Change-Id: I587c3eee7ba511dfc270aab66b546d2532bc635f
Reviewed-on: https://chromium-review.googlesource.com/528133Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#45785}
parent 8d75644f
......@@ -402,13 +402,6 @@
}], # 'arch == ppc64 and simulator_run == True'
##############################################################################
['variant == noturbofan and no_snap', {
# Too slow for old pipeline and nosnap.
'test-lockers/SeparateIsolatesLocksNonexclusive': [SKIP],
'test-lockers/ExtensionsRegistration': [SKIP],
}], # variant == noturbofan and no_snap
##############################################################################
['variant == wasm_traps', {
'test-accessors/*': [SKIP],
......
......@@ -73,12 +73,6 @@
'debug/ignition/debug-step-prefix-bytecodes': [SKIP],
}], # 'arch == arm and not simulator_run'
##############################################################################
['variant == noturbofan and system == macos and asan', {
# Too slow for old pipeline and mac asan.
'debug/*': [SKIP],
}], # variant == noturbofan and system == macos and asan
##############################################################################
['arch == s390 or arch == s390x', {
......
......@@ -20,12 +20,6 @@
'debugger/set-blackbox-patterns': [SKIP],
}], # variant != default
##############################################################################
['variant == noturbofan', {
# Crashes due to missing source position in ToBooleanICStub?
'runtime/command-line-api': [SKIP],
}], # variant == noturbofan
##############################################################################
['variant == wasm_traps', {
'*': [SKIP],
......
......@@ -626,13 +626,6 @@
'regress/regress-2185-2': [SKIP],
}], # variant == nooptimization
##############################################################################
['variant == noturbofan and no_snap', {
# Too slow for old pipeline and nosnap.
'regress/regress-2249': [SKIP],
'harmony/futex': [SKIP],
}], # variant == noturbofan and no_snap
##############################################################################
['gcov_coverage', {
# Tests taking too long.
......
......@@ -603,10 +603,10 @@
'built-ins/Promise/prototype/then/deferred-is-resolved-value': [SKIP],
}], # asan == True
['asan and variant in [noturbofan, fullcode]', {
['asan and variant == fullcode', {
# Demands too many resources to test the old pipeline with asan.
'*': [SKIP],
}], # asan and variant in [noturbofan, fullcode]
}], # asan and variant == fullcode
['asan == True or msan == True or tsan == True', {
# https://bugs.chromium.org/p/v8/issues/detail?id=4639
......
......@@ -109,7 +109,7 @@ TEST_MAP = {
TIMEOUT_DEFAULT = 60
# Variants ordered by expected runtime (slowest first).
VARIANTS = ["default", "noturbofan"]
VARIANTS = ["default"]
MORE_VARIANTS = [
"stress",
......
......@@ -6,7 +6,6 @@
ALL_VARIANT_FLAGS = {
"default": [[]],
"stress": [["--stress-opt", "--always-opt"]],
"noturbofan": [["--no-turbo"]],
"fullcode": [["--noopt", "--no-turbo"]],
# No optimization means disable all optimizations. OptimizeFunctionOnNextCall
# would not force optimization too. It turns into a Nop. Please see
......@@ -20,7 +19,6 @@ ALL_VARIANT_FLAGS = {
FAST_VARIANT_FLAGS = {
"default": [[]],
"stress": [["--stress-opt"]],
"noturbofan": [["--no-turbo"]],
"fullcode": [["--noopt", "--no-turbo"]],
# No optimization means disable all optimizations. OptimizeFunctionOnNextCall
# would not force optimization too. It turns into a Nop. Please see
......@@ -30,5 +28,5 @@ FAST_VARIANT_FLAGS = {
"wasm_traps": [["--wasm_guard_pages", "--wasm_trap_handler", "--invoke-weak-callbacks"]],
}
ALL_VARIANTS = set(["default", "stress", "noturbofan", "fullcode",
"nooptimization", "asm_wasm", "wasm_traps"])
ALL_VARIANTS = set(["default", "stress", "fullcode", "nooptimization",
"asm_wasm", "wasm_traps"])
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment