Revert "Revert "[test] Fix win-asan symbolizer path""
This reverts commit 4054cf27. Reason for revert: Just exposes existing issues. Original change's description: > Revert "[test] Fix win-asan symbolizer path" > > This reverts commit 135576ff. > > Reason for revert: V8 Win32 ASAN failures: https://build.chromium.org/p/client.v8/builders/V8%20Win32%20ASAN/builds/73 > > It appears these failures were lurking there already, but were hidden because of the bug this CL fixed. Opened https://crbug.com/v8/6953 about these issues. > > Original change's description: > > [test] Fix win-asan symbolizer path > > > > This makes the symbolizer path relative, as the absolute paths contain > > a drive letter + colon on windows. The colon is confused by the > > sanitizer as an option separator. > > > > The test driver changes the cwd to the V8 root dir in each > > invocation. > > > > Bug: chromium:726584 > > Change-Id: Icf4e5a55bba5dec8e59a3dfe3eccdf7224e65c33 > > Reviewed-on: https://chromium-review.googlesource.com/721124 > > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> > > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#48652} > > TBR=glider@chromium.org,rnk@chromium.org,machenbach@chromium.org,sergiyb@chromium.org,etienneb@chromium.org > > Change-Id: Ic78527950f6a239a03658e042d7244c9781d05db > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:726584 > Reviewed-on: https://chromium-review.googlesource.com/723825 > Reviewed-by: Eric Holk <eholk@chromium.org> > Commit-Queue: Eric Holk <eholk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48653} TBR=glider@chromium.org,rnk@chromium.org,machenbach@chromium.org,eholk@chromium.org,sergiyb@chromium.org,etienneb@chromium.org Change-Id: I8ea3b1d74ece09bed4758522f51cbee56a7792e1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:726584 Reviewed-on: https://chromium-review.googlesource.com/725319Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#48662}
Showing
Please
register
or
sign in
to comment