1. 21 Jun, 2022 3 commits
    • Jakob Kummerow's avatar
      Reland "[wasm] Fix tier-up budget tracking for recursive calls" · 6f398553
      Jakob Kummerow authored
      This is a reland of commit 15f372af
      
      Change since revert: TSan fix for tier-up budget reset.
      
      Original change's description:
      > [wasm] Fix tier-up budget tracking for recursive calls
      >
      > In the previous implementation, functions overwrote any budget
      > decrements caused by recursive invocations of themselves, which
      > could cause tier-up decisions for certain unlucky functions to
      > get delayed unreasonably long.
      > This patch avoids this by working with the on-instance value
      > directly instead of caching it in a stack slot. That generates
      > the same amount of Liftoff code as the status quo, but handles
      > recursive functions properly.
      > The "barista3" benchmark's peak performance improves by almost 20%.
      >
      > Bug: v8:12281
      > Change-Id: I8b487a88da99c2d22e132f2cc72bdf36aa5f6e63
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3693710
      > Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
      > Reviewed-by: Clemens Backes <clemensb@chromium.org>
      > Cr-Commit-Position: refs/heads/main@{#81249}
      
      Bug: v8:12281,v8:12984
      Change-Id: Ia6ce776848dc86617546ec514660c9a840484cb1
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3716479Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
      Commit-Queue: Andreas Haas <ahaas@chromium.org>
      Auto-Submit: Jakob Kummerow <jkummerow@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#81281}
      6f398553
    • Liu Yu's avatar
      [loong64][mips64][liftoff] Fix implicit conversion to LiftoffRegList · 6f611424
      Liu Yu authored
      Port commit b84c7dbd
      
      Bug: chromium:1337221
      Change-Id: I5f64995df3e0660740ef3915625373e1f147bc70
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3715957
      Auto-Submit: Liu Yu <liuyu@loongson.cn>
      Reviewed-by: 's avatarZhao Jiazhong <zhaojiazhong-hf@loongson.cn>
      Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn>
      Cr-Commit-Position: refs/heads/main@{#81269}
      6f611424
    • Michael Achenbach's avatar
      Revert "[wasm] Fix tier-up budget tracking for recursive calls" · 2864fd0f
      Michael Achenbach authored
      This reverts commit 15f372af.
      
      Reason for revert: https://crbug.com/v8/12984
      
      Original change's description:
      > [wasm] Fix tier-up budget tracking for recursive calls
      >
      > In the previous implementation, functions overwrote any budget
      > decrements caused by recursive invocations of themselves, which
      > could cause tier-up decisions for certain unlucky functions to
      > get delayed unreasonably long.
      > This patch avoids this by working with the on-instance value
      > directly instead of caching it in a stack slot. That generates
      > the same amount of Liftoff code as the status quo, but handles
      > recursive functions properly.
      > The "barista3" benchmark's peak performance improves by almost 20%.
      >
      > Bug: v8:12281
      > Change-Id: I8b487a88da99c2d22e132f2cc72bdf36aa5f6e63
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3693710
      > Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
      > Reviewed-by: Clemens Backes <clemensb@chromium.org>
      > Cr-Commit-Position: refs/heads/main@{#81249}
      
      Bug: v8:12281, v8:12984
      Change-Id: Ie254236785628c07ac569de16ea82a67ed5bd221
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3714247
      Auto-Submit: Michael Achenbach <machenbach@chromium.org>
      Owners-Override: Michael Achenbach <machenbach@chromium.org>
      Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
      Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
      Cr-Commit-Position: refs/heads/main@{#81267}
      2864fd0f
  2. 20 Jun, 2022 1 commit
    • Jakob Kummerow's avatar
      [wasm] Fix tier-up budget tracking for recursive calls · 15f372af
      Jakob Kummerow authored
      In the previous implementation, functions overwrote any budget
      decrements caused by recursive invocations of themselves, which
      could cause tier-up decisions for certain unlucky functions to
      get delayed unreasonably long.
      This patch avoids this by working with the on-instance value
      directly instead of caching it in a stack slot. That generates
      the same amount of Liftoff code as the status quo, but handles
      recursive functions properly.
      The "barista3" benchmark's peak performance improves by almost 20%.
      
      Bug: v8:12281
      Change-Id: I8b487a88da99c2d22e132f2cc72bdf36aa5f6e63
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3693710
      Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
      Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#81249}
      15f372af
  3. 07 Jun, 2022 1 commit
  4. 06 Jun, 2022 1 commit
  5. 02 Jun, 2022 2 commits
  6. 20 May, 2022 1 commit
  7. 19 May, 2022 1 commit
  8. 17 May, 2022 1 commit
  9. 13 May, 2022 1 commit
  10. 12 May, 2022 1 commit
  11. 06 May, 2022 1 commit
  12. 20 Apr, 2022 2 commits
  13. 09 Apr, 2022 1 commit
  14. 08 Apr, 2022 1 commit
  15. 06 Apr, 2022 1 commit
    • Clemens Backes's avatar
      [wasm] Make LiftoffRegList::ForRegs a constructor · ea96bd76
      Clemens Backes authored
      The 'ForRegs' method is not needed for clarity of the code, it's pretty
      clear what to construct a register list from. Hence turn the static
      {LiftoffRegList::ForRegs} method into a constructor. This makes the code
      more concise.
      
      Also, turn the for loop into a C++17 folding expression, which might
      generate better code because the loop will automatically be unrolled.
      
      R=thibaudm@chromium.org
      
      Bug: v8:12425
      Change-Id: Ic4446f23022db5f17420303d45b9c15fa5daff60
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3572041Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
      Commit-Queue: Clemens Backes <clemensb@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#79815}
      ea96bd76
  16. 16 Mar, 2022 1 commit
    • Clemens Backes's avatar
      [wasm] Fix some WASM comments and outputs · 44c02e18
      Clemens Backes authored
      In text, we should use the properly capitalized "Wasm" instead of
      "WASM". In particular for frame output, other frames typically use
      CamelCase (like "JsToWasmFrame", "ExitFrame", "InternalFrame"), so Wasm
      should do the same.
      The "0xa" comment in some assemblers is also outdated, the current tag
      we emit for StackFrame::WASM is 0x8 (0x4 shifted by one).
      
      R=jkummerow@chromium.org
      
      Bug: v8:12425
      Change-Id: Ic3e00c401b219c28b5424c82efb0f1a9df51690f
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3525195Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
      Commit-Queue: Clemens Backes <clemensb@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#79498}
      44c02e18
  17. 11 Mar, 2022 1 commit
  18. 24 Feb, 2022 1 commit
  19. 03 Feb, 2022 1 commit
  20. 01 Feb, 2022 1 commit
  21. 31 Jan, 2022 1 commit
  22. 02 Nov, 2021 1 commit
  23. 08 Oct, 2021 1 commit
  24. 02 Sep, 2021 1 commit
  25. 12 Aug, 2021 1 commit
  26. 05 Aug, 2021 1 commit
  27. 28 Jul, 2021 2 commits
  28. 23 Jul, 2021 1 commit
  29. 06 Jul, 2021 1 commit
  30. 24 Jun, 2021 1 commit
  31. 10 Jun, 2021 1 commit
  32. 03 Jun, 2021 1 commit
  33. 01 Jun, 2021 1 commit
  34. 19 May, 2021 1 commit
  35. 13 May, 2021 1 commit