- 06 Aug, 2018 23 commits
-
-
Ross McIlroy authored
We want to limit these cases since they result in unecessary work on background threads doing the streaming parse / compile, and delay the script execution unecessarily while waiting for the streamer to complete. BUG=chromium:865098 Change-Id: Ibb3346c2e644bb333521d876d00aeb9cc063b6aa Reviewed-on: https://chromium-review.googlesource.com/1163669Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#54929}
-
Marja Hölttä authored
Now we can remove FixedArrayOfWeakCells (this was the last user). Previous try: https://chromium-review.googlesource.com/1150170 BUG=v8:7308 Change-Id: Ie924e379ea8bbd797430e3ca591019fe001e78ad Reviewed-on: https://chromium-review.googlesource.com/1154909Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#54928}
-
Clemens Hammacher authored
In Liftoff, bugs often happen only if specific cache states are constructed. For this, longer sequences of instructions are needed. Thus, add a few rules to increase the chance of generating longer sequences. R=ahaas@chromium.org Change-Id: I8f112edf0280282bf275585e8a15772013c25245 Reviewed-on: https://chromium-review.googlesource.com/1158695Reviewed-by:
-
Simon Zünd authored
This CL is the first step towards a SetProperty stub, by adding a stub that redirects to the runtime and replacing every runtime call-site with a call to this stub. A followup CL will then add an implementation to the stub similar to KeyedStoreGenericAssembler::KeyedStoreGeneric(). R=cbruni@chromium.org, jgruber@chromium.org Change-Id: Iff2f913988cada6220d54817d94d011ad6de2b77 Reviewed-on: https://chromium-review.googlesource.com/1163519 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#54926}
-
Sigurd Schneider authored
Change-Id: Icf0507c6e50533c64a42fcf934bb1472ff21f68a Reviewed-on: https://chromium-review.googlesource.com/1163618 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#54925}
-
Hai Dang authored
Bug: v8:7973 Change-Id: I76308296dd45ef797d1eafd6e2736ccefb54302d Reviewed-on: https://chromium-review.googlesource.com/1162222Reviewed-by:
-
Georg Neis authored
- Trigger serialization for more objects, such as some root maps. - Serialize more data for certain object kinds. - Add macros for convenience. - Mark a few functions as const. R=jarin@chromium.org Bug: v8:7790 Change-Id: Id39b97e93728c0b3d87d9546bdf68abd04496c05 Reviewed-on: https://chromium-review.googlesource.com/1158572Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#54923}
-
Michael Starzinger authored
This is in preparation of making sure that jump table slots don't cross cache line boundaries. It is only introducing helper functions for back and forth conversion between "index" and "offset", but should not make any functional changes yet. R=ahaas@chromium.org BUG=v8:8018 Change-Id: I6ab525f9b89a6a15414c043a54c9fffb527a1ab6 Reviewed-on: https://chromium-review.googlesource.com/1163517Reviewed-by:
-
Marja Hölttä authored
This reverts commit a5efd507. Reason for revert: was a GC bug, unrelated to this CL. Original change's description: > Revert (partially) "Reland [in-place weak refs] Use WeakArrayList in Heap::noscript_list." > > Reason: flaky wasm crashes. > > This leaves WeakArrayList::RemoveOne (+ tests for it) in place. > > BUG=v8:7308, v8:8014 > > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng > Change-Id: I1195d061ae7d3c82f921f94f50df3f09a55de5ca > Reviewed-on: https://chromium-review.googlesource.com/1161904 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54891} TBR=marja@chromium.org,mlippautz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:7308, v8:8014 Change-Id: Id8002e2178ac89378b047dd0acd1bf4e3c272918 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1162124Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#54921}
-
Georg Neis authored
Check each dependency's validity again right before installing it, because a GC during preceding installations can theoretically trigger invalidation for some dependency kinds. Also inline the IsSane checkers into the constructors. R=jarin@chromium.org Change-Id: I1331dee27f01e8fd07cb953dddfed72fd1841559 Reviewed-on: https://chromium-review.googlesource.com/1161933Reviewed-by:
-
Rodrigo Bruno authored
Node.js is using AdjustAmountOfExternalAllocatedMemory to get external memory from V8 [1]. In addition, they have a unittest that verifies that AdjustAmountOfExternalAllocatedMemory returns the correct value [2]. This CL proposes a new way to report external memory through HeapStatistics. [1]https://github.com/nodejs/node/blob/07cb69720bec251a1c450b3770db2136ac009778/src/node_process.cc#L187 [2]https://github.com/nodejs/node/blob/master/test/parallel/test-memory-usage.js Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ia58ed0bab1c1d4ee23672e1347b9a00b6705a43c Reviewed-on: https://chromium-review.googlesource.com/1162156 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#54919}
-
jgruber authored
And related call sites. Drive-by: add IntPtrZero() and SmiZero() helpers. Bug: v8:8015 Change-Id: I83195cf2da858f8d35f25c9a1aa5c40c81df78b9 Reviewed-on: https://chromium-review.googlesource.com/1162169 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#54918}
-
Sathya Gunasekaran authored
Previously, Intl.PluralRules was mostly implemented in JavaScript. This patch moves most of the constructor and parts of other methods to C++. The size of the Intl.PluralRules object is reduced by not storing MinimumIntegerDigits, MinimumFractionDigits, MaximumFractionDigits, MinimumSignificantDigits, MaximumSignificantDigits. Instead these are looked up from icu::DecimalFormat as required. Another optimziation is that we don't create the result of resolvedOptions when the Intl.PluralRules object is constructed, but instead defer until this method is called. In the future, we may want to cache the result. This patch also cleans up several error handling paths that shouldn't happen with ICU and instead just crashes should it ever happen. Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I84c5aa6c25c35fe2d336693dee1b36bf3dcd4a79 Reviewed-on: https://chromium-review.googlesource.com/1158701 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Bug: v8:6666 Change-Id: I577c2ac89e8247d6fc90f1e9dbd0ef14a14fbddc Reviewed-on: https://chromium-review.googlesource.com/1163246 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Dan Elphick authored
Removes all V8_DEPRECATED functions that weren't recently marked as well any V8_DEPRECATE_SOON function that relied on using the address of an object to get hold of the Isolate. Normally we would have advanced the V8_DEPRECATE_SOON methods to V8_DEPRECATE in this release and removed them in the follow release, but their continuing presence blocks the work on creating a shared Read-Only space where some objects would not belong to any single Isolate. In preparation chromium and node.js (via the v8/node github) have been modified in advance. Bug: v8:7786 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I8b4b06189896d94aff908ebcd121b3b38f9b482a Reviewed-on: https://chromium-review.googlesource.com/1154915 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This CL puts off-heap targets (i.e. code addresses for embedded builtins) in the constant pool on ARM. We are landing this CL to evaluate impact on benchmarks and code size, and expect to revert it once we have gathered that data. Bug: v8:6666 Change-Id: If4935a6fb162cd1ffb34489c6fa9630f10ca2c9f Reviewed-on: https://chromium-review.googlesource.com/1154924 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Anna Henningsen authored
This is not used in Chrome or Node anymore. (This could also potentially be just removed at this point.) Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I59ecc216faeb3d56d3a52c548a863544570b6173 Reviewed-on: https://chromium-review.googlesource.com/1161936 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Vlad Tsyrklevich authored
By using a built-in this functions works with SafeStack and doesn't require an attribute disabling ASan. BUG=chromium:864705 Change-Id: I898d42c0b39b07300f1679eba11e7f50cad42120 Reviewed-on: https://chromium-review.googlesource.com/1162669Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54912}
-
Sigurd Schneider authored
This reverts commit bf5ea813. Reason for revert: Breaks Sanitizers https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20ASAN/26688 Original change's description: > [tracing] allow dynamic control of tracing > > If the trace_buffer_ was null, we were returning a pointer to a static > flag back that permanently disabled that particular trace point. > > This implied an assumption that tracing will be statically enabled at > process startup, and once it is disabled, it will never be enabled > again. On Node.js side we want to dynamically enable/disable tracing as per > programmer intent. > > Change-Id: Ic7a7839b8450ab5c356d85e8e0826f42824907f4 > Reviewed-on: https://chromium-review.googlesource.com/1161518 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Ali Ijaz Sheikh <ofrobots@google.com> > Cr-Commit-Position: refs/heads/master@{#54903} TBR=yangguo@chromium.org,ofrobots@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I9459992e8c2ee403b9ddc8f6b9582d204139f6e8 Reviewed-on: https://chromium-review.googlesource.com/1162122Reviewed-by:
-
Sigurd Schneider authored
This reverts commit 898f880a. Reason for revert: TSAN report memory leaks This is not related to this CL, but to behavior in tracing-controller.cc. Sorry! https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket.appspot.com/8938962708686133568/+/steps/Check_-_slow_path__flakes_/0/logs/memory_grow/0 Original change's description: > [cpu-profiler] Turn on detailed line info for optimized code > > Cautiously turn on this flag by default to check the impact on > performance bots. Could show minor regressions in old space and/or > code_and_metadata memory buckets. > > Bug: v8:7983 > Change-Id: Ic4369cdb0231f4f88eada699da948e8bb48a25fd > Reviewed-on: https://chromium-review.googlesource.com/1162234 > Commit-Queue: Yang Guo <yangguo@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54908} TBR=yangguo@chromium.org,petermarshall@chromium.org Change-Id: If17abee873cb589fc6450231149ccc82e7ca9f7b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7983 Reviewed-on: https://chromium-review.googlesource.com/1163441Reviewed-by:
-
Jaroslav Sevcik authored
Bug: chromium:869735 Change-Id: I65c4a1b92e1e0874eabff14e9cf6f5b56dc8d43a Reviewed-on: https://chromium-review.googlesource.com/1158065Reviewed-by:
-
Peter Marshall authored
Cautiously turn on this flag by default to check the impact on performance bots. Could show minor regressions in old space and/or code_and_metadata memory buckets. Bug: v8:7983 Change-Id: Ic4369cdb0231f4f88eada699da948e8bb48a25fd Reviewed-on: https://chromium-review.googlesource.com/1162234 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e1167bf..7d6c957 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I135164556a3821e81177cae1cb6e3fadc1cac0ea Reviewed-on: https://chromium-review.googlesource.com/1163290Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#54907}
-
- 05 Aug, 2018 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/d30f108..d2f6e76 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I9b8393ba556f43a25d69eb353801571cbdb478a0 Reviewed-on: https://chromium-review.googlesource.com/1163073Reviewed-by:
-
- 04 Aug, 2018 2 commits
-
-
Caitlin Potter authored
This fixes a CHECK failure in MapVerify, and gets the correct behaviour for uses of the well-known symbols. BUG=v8:7611, chromium:866229 R=jkummerow@chromium.org, mvstanton@chromium.org, bmeurer@chromium.org Change-Id: I5d679357b8807ea9d1054121d8d336fe0dd43c7c Reviewed-on: https://chromium-review.googlesource.com/1162278Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Caitlin Potter <caitp@igalia.com> Cr-Commit-Position: refs/heads/master@{#54905}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/641e460..e1167bf Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/eae13a4..d30f108 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/29b7b99..82bb756 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/2175972..657bfc2 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ia00fd691a828dff7e0cfadbf5cf81a18c4d4bfb6 Reviewed-on: https://chromium-review.googlesource.com/1162992Reviewed-by:
-
- 03 Aug, 2018 14 commits
-
-
Ali Ijaz Sheikh authored
If the trace_buffer_ was null, we were returning a pointer to a static flag back that permanently disabled that particular trace point. This implied an assumption that tracing will be statically enabled at process startup, and once it is disabled, it will never be enabled again. On Node.js side we want to dynamically enable/disable tracing as per programmer intent. Change-Id: Ic7a7839b8450ab5c356d85e8e0826f42824907f4 Reviewed-on: https://chromium-review.googlesource.com/1161518Reviewed-by:
-
Ben Newman authored
I have a project that embeds V8 and uses a single `Isolate` from multiple threads. The program runs just fine, but sometimes the inspector doesn't stop on the correct line after stepping over a statement that switches threads behind the scenes, even though the original thread is restored by the time the next statement is executed. After some digging, I discovered that the `Debug::ArchiveDebug` and `Debug::RestoreDebug` methods, which should be responsible for saving/restoring this `ThreadLocal` information when switching threads, currently don't do anything. This commit implements those methods using MemCopy, in the style of other Archive/Restore methods in the V8 codebase. Related: https://groups.google.com/forum/#!topic/v8-users/_Qf2rwljRk8 Note: I believe my employer, Meteor Development Group, has previously signed the CLA using the group email address google-contrib@meteor.com. R=yangguo@chromium.org,jgruber@chromium.org CC=info@bnoordhuis.nl Bug: v8:7230 Change-Id: Id517c873eb81cd53f7216c7efd441b956cf7f943 Reviewed-on: https://chromium-review.googlesource.com/833260 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Predrag Rudic authored
In order to enable PIC code in builtins we need to have BranchLong position independent. Change-Id: I374134ff540b515f3cf385a8b936487b47c55762 Reviewed-on: https://chromium-review.googlesource.com/1152810Reviewed-by:
Ivica Bogosavljevic <ibogosavljevic@wavecomp.com> Reviewed-by:
Sreten Kovacevic <skovacevic@wavecomp.com> Commit-Queue: Ivica Bogosavljevic <ibogosavljevic@wavecomp.com> Cr-Commit-Position: refs/heads/master@{#54901}
-
Théotime Grohens authored
This CL fixes a bug found by Clusterfuzz, in which the functions LoadDataViewByteOffset and -ByteLength incorrectly had a return type of TNode<Smi> instead of TNode<Number>. This caused a CAST() call to fail when the requested byte offset or byte length did not fit inside a Smi, i.e. when the underlying ArrayBuffer of the DataView had a length longer than 2^30 on 32-bit platforms. The CL also includes a new test in mjsunit to test against this. Bug: chromium:869313 Change-Id: Ibb7d29bda5782a12c4b506c070bb03fef8c3ec70 Reviewed-on: https://chromium-review.googlesource.com/1158582 Commit-Queue: Théotime Grohens <theotime@google.com> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#54900}
-
Clemens Hammacher authored
Move them to builtins-utils-inl.h instead. R=titzer@chromium.org Bug: v8:8015, v8:7965 Change-Id: I692e5871e320896923bed5cc6a2efc609c793446 Reviewed-on: https://chromium-review.googlesource.com/1160845 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#54899}
-
Sigurd Schneider authored
We have two constants for the PC load delta; this CL consolidates them into one. The CL does not change MIPS as the two constants are defined to different values there. Bug: v8:6666 Change-Id: If207a59dea3ef33756a5d7330217ab8a176bdf63 Reviewed-on: https://chromium-review.googlesource.com/1161926Reviewed-by:
-
Georg Neis authored
After the recent bugfix, the special case for 'undefined' is no longer needed. Bug: v8:7813 Change-Id: Iee3fccd72c525ac86a6fa6b3c55bcd2ce8159852 Reviewed-on: https://chromium-review.googlesource.com/1161906Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#54897}
-
Georg Neis authored
This became obsolete when I rewrote CompilationDependencies. R=jarin@chromium.org Change-Id: Ifc567fafccd33e98be9d1bdf6264c680be3149e4 Reviewed-on: https://chromium-review.googlesource.com/1161919Reviewed-by:
-
Georg Neis authored
R=jarin@chromium.org Bug: v8:7790 Change-Id: Iad9380ac6c6035a731db2e0b2b9abbc9f8570cc2 Reviewed-on: https://chromium-review.googlesource.com/1161915 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
R=titzer@chromium.org Bug: v8:7754, v8:7965 Change-Id: I62027d97c40276b5dfa9579fc4e903ee21a55b54 Reviewed-on: https://chromium-review.googlesource.com/1160539 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
Bug: v8:8012 v8:7793 Change-Id: Idc5d685d021fd107974b4415f7b855397004cb53 Reviewed-on: https://chromium-review.googlesource.com/1160841Reviewed-by:
-
Peter Marshall authored
FixedArray max size is currently 1024 MB on 64 bit and 512 MB on 32 bit. Update the max size of FixedDoubleArray to match. This doubles the max size for arrays of doubles. Bug: chromium:814599 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I3ac1b4caaf5b6428fe8a8c848fffdf84af8a9ae9 Reviewed-on: https://chromium-review.googlesource.com/1160235Reviewed-by:
-
Marja Hölttä authored
Reason: flaky wasm crashes. This leaves WeakArrayList::RemoveOne (+ tests for it) in place. BUG=v8:7308, v8:8014 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I1195d061ae7d3c82f921f94f50df3f09a55de5ca Reviewed-on: https://chromium-review.googlesource.com/1161904Reviewed-by:
-
Clemens Hammacher authored
On all architectures except for arm64 (which has a limit of 128 MB), we increase the maximum wasm code space from 256 MB to 512 MB. This generally allows for bigger WebAssembly modules and tolerates the code size increase because of Liftoff. R=titzer@chromium.org Bug: chromium:840292, v8:6600 Change-Id: I999cc0c96740ad3da15cc70114d7835354d67fbf Reviewed-on: https://chromium-review.googlesource.com/1160702Reviewed-by:
-
