• Théotime Grohens's avatar
    [dataview] Fix too tight TNode type in DataView getters · 3656b465
    Théotime Grohens authored
    This CL fixes a bug found by Clusterfuzz, in which the functions
    LoadDataViewByteOffset and -ByteLength incorrectly had a return
    type of TNode<Smi> instead of TNode<Number>.
    
    This caused a CAST() call to fail when the requested byte offset
    or byte length did not fit inside a Smi, i.e. when the underlying
    ArrayBuffer of the DataView had a length longer than 2^30 on
    32-bit platforms.
    
    The CL also includes a new test in mjsunit to test against this.
    
    Bug: chromium:869313
    Change-Id: Ibb7d29bda5782a12c4b506c070bb03fef8c3ec70
    Reviewed-on: https://chromium-review.googlesource.com/1158582
    Commit-Queue: Théotime Grohens <theotime@google.com>
    Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#54900}
    3656b465
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...