• Sathya Gunasekaran's avatar
    [Intl] Optimize Intl.PluralRules · cdb4d913
    Sathya Gunasekaran authored
    Previously, Intl.PluralRules was mostly implemented in JavaScript. This
    patch moves most of the constructor and parts of other methods to C++.
    
    The size of the Intl.PluralRules object is reduced by not storing
    MinimumIntegerDigits, MinimumFractionDigits, MaximumFractionDigits,
    MinimumSignificantDigits, MaximumSignificantDigits. Instead these are
    looked up from icu::DecimalFormat as required.
    
    Another optimziation is that we don't create the result of
    resolvedOptions when the Intl.PluralRules object is constructed, but
    instead defer until this method is called. In the future, we may want
    to cache the result.
    
    This patch also cleans up several error handling paths that shouldn't
    happen with ICU and instead just crashes should it ever happen.
    
    Bug: v8:5751
    Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
    Change-Id: I84c5aa6c25c35fe2d336693dee1b36bf3dcd4a79
    Reviewed-on: https://chromium-review.googlesource.com/1158701
    Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org>
    Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
    Reviewed-by: 's avatarJungshik Shin <jshin@chromium.org>
    Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#54917}
    cdb4d913
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...