- 15 Mar, 2019 1 commit
-
-
Yoshisato Yanagisawa authored
The function we use with gclient_utils has moved to gclient_paths. However, I am not sure gclient_utils is used by others or not. Additional change: - sorted testMembersChanged members for ease of understanding what is different. Bug: 939959 Change-Id: I8b822e26afc73b39d2a33c5e07779c9c14cbd394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1521850 Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Fumitoshi Ukai <ukai@chromium.org>
-
- 22 Feb, 2019 2 commits
-
-
Edward Lemur authored
Bug: 914655 Change-Id: I06a3ff39d884327fd407a5c50cc9730a375bef0b Reviewed-on: https://chromium-review.googlesource.com/c/1382974 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org>
-
Caleb Rouleau authored
The current BugsFromDescription code returns ['1234, 5678'] but I think it should return ['1234', '5678']. For 'BUG=1234, 5678' this already works. This was preventing me from uploading https://chromium-review.googlesource.com/c/catapult/+/1481239 because of https://cs.chromium.org/chromium/src/third_party/catapult/PRESUBMIT.py?q=catapult/PRESUBMIT.py&sq=package:chromium&g=0&l=52 See https://logs.chromium.org/logs/catapult/buildbucket/cr-buildbucket.appspot.com/8920885706080647120/+/steps/presubmit/0/stdout Change-Id: Ibb3fca8c7a6ec664cdf9a38a8a7ac2bf66cb73ed Reviewed-on: https://chromium-review.googlesource.com/c/1481240 Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
- 20 Feb, 2019 1 commit
-
-
Quinten Yearsley authored
In particular, only show robot comments from the latest patchset. Bug: 924780 Change-Id: I12038ddd2d90a5cb561b248de3fd37908d5b927e Reviewed-on: https://chromium-review.googlesource.com/c/1457282Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
-
- 04 Feb, 2019 1 commit
-
-
Edward Lemur authored
So that bot_update can apply patched on top of experimental branches, which include the user's email (and so an extra @). Change-Id: I33acb49e8b48c6ed6db7e752fca7eb0f1ede0690 Reviewed-on: https://chromium-review.googlesource.com/c/1450895 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org>
-
- 31 Jan, 2019 1 commit
-
-
Vadim Shtayura authored
R=tandrii@chromium.org BUG=925532 Change-Id: I72ab6108cf43353e36ddeccd705acdd04716f785 Reviewed-on: https://chromium-review.googlesource.com/c/1448634 Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org>
-
- 11 Jan, 2019 2 commits
-
-
Robert Iannucci authored
This has been ignored for a long time, and I'd like to get rid of it. R=jchinlee@chromium.org, nodir@chromium.org Change-Id: I240d59cc10a2882041ac2c8abfeb1894237516a6 Reviewed-on: https://chromium-review.googlesource.com/c/1407425Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
David 'Digit' Turner authored
The previous implementation of CheckLongLines did not handle global pylint disable/enable directives properly, i.e. the difference between: # pylint: disable=line-too-long .... checks disabled for all lines here. # pylint: enable=line-too-long versus: # Check only disabled for the line below some python statements # pylint: disable=line-too-long This CL changes the implementation to support Python files properly. Note that in order to not disturb the mock-based unit-tests, a new function is introduced to be able to filter the list of affected files based on their file extension. BUG=890734 R=mattcary@chromium.org,ehmaldonado@chromium.org,dpranke@chromium.org Change-Id: Id52deff53913b8d47a4157f42b1fffbd3b103201 Reviewed-on: https://chromium-review.googlesource.com/c/1396094Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: David Turner <digit@chromium.org>
-
- 09 Jan, 2019 1 commit
-
-
Takuto Ikuta authored
We cannot send PII data. This CL tried to remove following data, * build config that can contain build directory path * build directory path * hostname * cwd I use per build uuid instead of per user uuid. Bug: 900161 Change-Id: Id533762749806ad8616b7dc07f21b27dfe632c9a Reviewed-on: https://chromium-review.googlesource.com/c/1369473Reviewed-by:
Shinya Kawanaka <shinyak@chromium.org> Reviewed-by:
Fumitoshi Ukai <ukai@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
-
- 18 Dec, 2018 1 commit
-
-
Takuto Ikuta authored
This function extracts build target from command line. Bug: 900161 Change-Id: I38d37689a42437de76933ea3c9afb9def5a1253c Reviewed-on: https://chromium-review.googlesource.com/c/1381911 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Shinya Kawanaka <shinyak@chromium.org>
-
- 17 Dec, 2018 2 commits
-
-
Takuto Ikuta authored
Use unittest module instead of doctest. Bug: 900161 Change-Id: I2e8265afb66345814c4c4b8e94618171b7aaaaf3 Reviewed-on: https://chromium-review.googlesource.com/c/1379441 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Shinya Kawanaka <shinyak@chromium.org>
-
Edward Lemur authored
Bug: 914712 Change-Id: I13db57af519bb254389bc6bd1f1f81ad1d497e42 Reviewed-on: https://chromium-review.googlesource.com/c/1377295 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org>
-
- 13 Dec, 2018 1 commit
-
-
Bryce Thomas authored
Commit a185e2e3 removed the Rietveld code review implementation, albeit hasn't expunged all references to Rietveld. This leads to an assertion error when running |git cl format| on a non-Gerrit change. There appears to have been a recent attempt to articulate this error better in a185e2e3, albeit not fix the underlying issue. This change addresses the immediate issue by defaulting the code review implementation to Gerrit rather than Reitveld. R=joenotcharles@google.com, tandrii@chromium.org Bug: 914150 Change-Id: I64d33e5a172cc43339ec417f7f0a7820e0337772 Reviewed-on: https://chromium-review.googlesource.com/c/1372928Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Bryce Thomas <bryct@amazon.com>
-
- 05 Dec, 2018 2 commits
-
-
Clemens Hammacher authored
This reverts commit ba83229a. Reason for revert: After mail discussion we came to the conclusion that the old behavior makes more sense. Original change's description: > Fix semantics of git new-branch --upstream > > Currently, the "--upstream A" option for new-branch behaves totally > different than "--upstream_current". While "--upstream A" checks out > branch A and then creates a new branch which tracks A, > "--upstream_current" creates a new branch for the current HEAD and sets > the upstream to the previously checked out branch. > > As the documentation does not mention that any of the options changes > the currently-checked-out commit (HEAD), this CL changes the semantics > of "git new-branch --upstream A B" to be identical to "git checkout -b B > && git branch --set-upstream-to A". > > It also slightly extends the documentation to mention that in any case > the new branch is based on HEAD. > > R=iannucci@chromium.org > > Change-Id: Ic335d2caf27cb6afca1b8bc5a008424c0e880fca > Reviewed-on: https://chromium-review.googlesource.com/c/1350748 > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Auto-Submit: Clemens Hammacher <clemensh@chromium.org> TBR=iannucci@chromium.org,tandrii@chromium.org,clemensh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I7463935af172f0801c7da94d2de106a02fc4c42e Reviewed-on: https://chromium-review.googlesource.com/c/1362972Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
-
Edward Lemur authored
Bug: 877717 Change-Id: I6541a971068aae662b086eba84448bd0769f1a09 Reviewed-on: https://chromium-review.googlesource.com/c/1362405Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 04 Dec, 2018 1 commit
-
-
Clemens Hammacher authored
Currently, the "--upstream A" option for new-branch behaves totally different than "--upstream_current". While "--upstream A" checks out branch A and then creates a new branch which tracks A, "--upstream_current" creates a new branch for the current HEAD and sets the upstream to the previously checked out branch. As the documentation does not mention that any of the options changes the currently-checked-out commit (HEAD), this CL changes the semantics of "git new-branch --upstream A B" to be identical to "git checkout -b B && git branch --set-upstream-to A". It also slightly extends the documentation to mention that in any case the new branch is based on HEAD. R=iannucci@chromium.org Change-Id: Ic335d2caf27cb6afca1b8bc5a008424c0e880fca Reviewed-on: https://chromium-review.googlesource.com/c/1350748Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Auto-Submit: Clemens Hammacher <clemensh@chromium.org>
-
- 01 Dec, 2018 1 commit
-
-
Edward Lemur authored
Bug: 770408 Change-Id: Ic5029d6b12cdb6ea30704d90229ab7e365dc7273 Reviewed-on: https://chromium-review.googlesource.com/c/1354384 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org>
-
- 30 Nov, 2018 1 commit
-
-
Edward Lemur authored
Bug: 845642 Change-Id: I552b2da4abbac7ca7f6f3961d2b1c5002fb26f47 Reviewed-on: https://chromium-review.googlesource.com/c/1351509Reviewed-by:
Andy Perelson <ajp@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 26 Nov, 2018 1 commit
-
-
Edward Lemur authored
Use gclient setdep/getdep instead of evaluating the contents of the DEPS file, so we don't have to deal with builtin_variables. Bug: 906114 Change-Id: I2082d4a3feb84d15c251b7d99056fd4c6f925453 Reviewed-on: https://chromium-review.googlesource.com/c/1347450Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 21 Nov, 2018 2 commits
-
-
Andrii Shyshkalov authored
R=ajp, ehmaldonado Change-Id: I59859048d64902669479e666c6c3d37c1fb1394c Reviewed-on: https://chromium-review.googlesource.com/c/1344642 Auto-Submit: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
R=ajp, ehmaldonado Change-Id: I9c9f5e0f8ef41c0f6a00faa67acf0cf516290f09 Reviewed-on: https://chromium-review.googlesource.com/c/1345272Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
- 19 Nov, 2018 2 commits
-
-
Eric Foo authored
Bug:868202 Change-Id: Ic480356aa4b385e97eb3e47a6f1a439aeb82720a Reviewed-on: https://chromium-review.googlesource.com/c/1341227 Commit-Queue: Eric Foo <efoo@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org>
-
Edward Lemur authored
This is a reland of 5705acab If a gclient config is not found, then built-in variables wont be supported. Original change's description: > [gclient] Make getdep and setdep to provide builtin vars > > Bug: 906114 > Change-Id: I069cc21343911f7fdb3c91ecbd8fcba53fc8099f > Reviewed-on: https://chromium-review.googlesource.com/c/1340461 > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> > Commit-Queue: Eric Boren <borenet@chromium.org> Bug: 906114 Change-Id: I72f30d10b5f0180fd5c616a42393f5b12055ce8e Reviewed-on: https://chromium-review.googlesource.com/c/1341039Reviewed-by:
Eric Boren <borenet@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 16 Nov, 2018 2 commits
-
-
Sergiy Byelozyorov authored
This reverts commit 5705acab. Reason for revert: breaks internal bots, e.g. see http://shortn/_KDb4blyDVz Original change's description: > [gclient] Make getdep and setdep to provide builtin vars > > Bug: 906114 > Change-Id: I069cc21343911f7fdb3c91ecbd8fcba53fc8099f > Reviewed-on: https://chromium-review.googlesource.com/c/1340461 > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> > Commit-Queue: Eric Boren <borenet@chromium.org> TBR=borenet@chromium.org,ehmaldonado@chromium.org Change-Id: I233ae7feae296fb4cd04b9b36d7f53d1114df5ff No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 906114 Reviewed-on: https://chromium-review.googlesource.com/c/1340506Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
-
Eric Boren authored
Bug: 906114 Change-Id: I069cc21343911f7fdb3c91ecbd8fcba53fc8099f Reviewed-on: https://chromium-review.googlesource.com/c/1340461Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Eric Boren <borenet@chromium.org>
-
- 03 Nov, 2018 1 commit
-
-
Edward Lemur authored
Bug: 897394 Change-Id: I07959e870fef4e6a6b8e6e7c974397d3306460c1 Reviewed-on: https://chromium-review.googlesource.com/c/1315839 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org>
-
- 01 Nov, 2018 2 commits
-
-
Edward Lemur authored
Bug: 897394 Change-Id: I52a31bb4840b5de89b96545a3e7544c6708f148f Reviewed-on: https://chromium-review.googlesource.com/c/1312240Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
Make it possible to refer to built-in variables without having to declare then in DEPS files. Bug: None Change-Id: I5403963052463befc074f29750de56cce13927ce Reviewed-on: https://chromium-review.googlesource.com/c/1312234Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 31 Oct, 2018 1 commit
-
-
Edward Lemur authored
Bug: None Change-Id: I73545ad59134c6e5dbeb47fb2e8168a5afc0e497 Reviewed-on: https://chromium-review.googlesource.com/c/1296861 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org>
-
- 30 Oct, 2018 3 commits
-
-
Edward Lemur authored
Bug: 897394 Change-Id: I055e844299e262be81d5ac52ef24571b8fdfd47c Reviewed-on: https://chromium-review.googlesource.com/c/1292245 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Andy Perelson <ajp@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
Except when TBR is active, because it's not clear how to compute max score for Code-Review label before uploading a change. Tested with this very own CL: To https://chromium.googlesource.com/chromium/tools/depot_tools.git * [new branch] c78de165c7be156bdf8032c0ce3d8bad42778f1c -> refs/for/refs/heads/master%ready,notify=ALL,m=Initial_upload,r=ehmaldonado, cc=ajp,cc=chromium-reviews@chromium.org,cc=iannucci+depot_tools@chromium.org, l=Commit-Queue+1,hashtag=git-cl-upload R=ehmaldonado Bug: 877717 Change-Id: I464d9df2814bd830dd608bb881040e2dd3c41dbb Reviewed-on: https://chromium-review.googlesource.com/c/1307052Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
For other hosts, behavior is not changed. Tested on this very CL: To https://chromium.googlesource.com/chromium/tools/depot_tools.git * [new branch] 9057c2235b096f1feae61d65569641fc7c08a0e2 -> refs/for/refs/heads/master%ready,notify=ALL,m=Initial_upload,r=ehmaldonado,cc=chromium-reviews@chromium.org,cc=iannucci+depot_tools@chromium.org,hashtag=git-cl-upload R=ehmaldonado Bug: 877717 Change-Id: I951fc576105211590c6c303ce0ed2fe142628224 Reviewed-on: https://chromium-review.googlesource.com/c/1307051Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
- 23 Oct, 2018 1 commit
-
-
Edward Lemur authored
Bug: 897394 Change-Id: I92d2514e4347f02dbcf2884bef3a073095ee03a3 Reviewed-on: https://chromium-review.googlesource.com/c/1292242 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org>
-
- 22 Oct, 2018 1 commit
-
-
Edward Lemur authored
Bug: 897394 Change-Id: Iece4507c7bf92d7a8aad045d31b4f06e54b3af15 Reviewed-on: https://chromium-review.googlesource.com/c/1292243Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 18 Oct, 2018 1 commit
-
-
Edward Lemur authored
When we change the version number in metrics_utils: If the user is not a Googler, or has opted out explicitly, nothing happens and we still don't collect metrics. If we're collecting metrics from the user, we stop collecting metrics and display a notice telling them what has changed. That notice will be displayed ten times, after which we will resume collecting metrics. A notice telling them we're collecting metrics will still be displayed. Bug: None Change-Id: If1cc12b2fc06f0d6237714c4f182367b1afdf9fb Reviewed-on: https://chromium-review.googlesource.com/c/1285395 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org>
-
- 16 Oct, 2018 4 commits
-
-
Andrii Shyshkalov authored
R=ehmaldonado Bug: 770408 Change-Id: I94ff37f198937dc7d341a859a71becd91cf3a706 Reviewed-on: https://chromium-review.googlesource.com/c/1279140 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-
Andrii Shyshkalov authored
R=ehmaldonado Bug: 770408 Change-Id: I211ad8e67e9486b974eed7694436afb15ecf21a2 Reviewed-on: https://chromium-review.googlesource.com/c/1279136 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-
Andrii Shyshkalov authored
R=ehmaldonado Bug: 770408 Change-Id: Ib3120b5fd09c35be691c025d0d69ceda60f2ec7f Reviewed-on: https://chromium-review.googlesource.com/c/1279135 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-
Andrii Shyshkalov authored
R=ehmaldonado Bug: 770408 Change-Id: I980487aacd115535d0ca855cd1edfcfc18fc5cbe Reviewed-on: https://chromium-review.googlesource.com/c/1279138 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-
- 15 Oct, 2018 1 commit
-
-
Andrii Shyshkalov authored
Also fix a typo in ValidateEmail function which didn't support email addresses with '-' in them, e.g., infra-dev@chromium.org. R=ehmaldonado Bug: 875089 Change-Id: I2d73c1473527c9bf62e25e9f88250196b783fcb0 Reviewed-on: https://chromium-review.googlesource.com/c/1242849 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-