• David 'Digit' Turner's avatar
    Improve no-long-lines check for Python files. · 31a48641
    David 'Digit' Turner authored
    The previous implementation of CheckLongLines did not
    handle global pylint disable/enable directives properly,
    i.e. the difference between:
    
       # pylint: disable=line-too-long
       .... checks disabled for all lines here.
       # pylint: enable=line-too-long
    
    versus:
    
       # Check only disabled for the line below
       some python statements   # pylint: disable=line-too-long
    
    This CL changes the implementation to support Python files
    properly. Note that in order to not disturb the mock-based
    unit-tests, a new function is introduced to be able to
    filter the list of affected files based on their file
    extension.
    
    BUG=890734
    R=mattcary@chromium.org,ehmaldonado@chromium.org,dpranke@chromium.org
    
    Change-Id: Id52deff53913b8d47a4157f42b1fffbd3b103201
    Reviewed-on: https://chromium-review.googlesource.com/c/1396094Reviewed-by: 's avatarEdward Lesmes <ehmaldonado@chromium.org>
    Commit-Queue: David Turner <digit@chromium.org>
    31a48641
Name
Last commit
Last update
..
gstools Loading commit data...
OWNERS Loading commit data...
auth_test.py Loading commit data...
bot_update_coverage_test.py Loading commit data...
checkout_test.py Loading commit data...
cipd_bootstrap_test.py Loading commit data...
download_from_google_storage_unittest.py Loading commit data...
fix_encoding_test.py Loading commit data...
gclient_eval_unittest.py Loading commit data...
gclient_scm_test.py Loading commit data...
gclient_smoketest.py Loading commit data...
gclient_test.py Loading commit data...
gclient_utils_test.py Loading commit data...
git_cache_test.py Loading commit data...
git_cl_creds_check_report.txt Loading commit data...
git_cl_test.py Loading commit data...
git_common_test.py Loading commit data...
git_dates_test.py Loading commit data...
git_drover_test.py Loading commit data...
git_footers_test.py Loading commit data...
git_hyper_blame_test.py Loading commit data...
git_number_test.py Loading commit data...
git_rebase_update_test.py Loading commit data...
gsutil_test.py Loading commit data...
metrics_test.py Loading commit data...
ninjalog_uploader_test.py Loading commit data...
owners_finder_test.py Loading commit data...
owners_unittest.py Loading commit data...
patch_test.py Loading commit data...
presubmit_unittest.py Loading commit data...
recipes_test.py Loading commit data...
roll_dep_test.py Loading commit data...
scm_unittest.py Loading commit data...
subprocess2_test.py Loading commit data...
upload_to_google_storage_unittest.py Loading commit data...
watchlists_unittest.py Loading commit data...