Commit dd672fb3 authored by Andrii Shyshkalov's avatar Andrii Shyshkalov Committed by Commit Bot

git cl description: rename gerrit test.

R=ehmaldonado

Bug: 770408
Change-Id: I211ad8e67e9486b974eed7694436afb15ecf21a2
Reviewed-on: https://chromium-review.googlesource.com/c/1279136
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: 's avatarEdward Lesmes <ehmaldonado@chromium.org>
parent 642641d0
......@@ -4641,11 +4641,9 @@ def CMDdescription(parser, args):
if not target_issue_arg.valid:
parser.error('invalid codereview url or CL id')
auth_config = auth.extract_auth_config_from_options(options)
kwargs = {
'auth_config': auth_config,
'codereview': options.forced_codereview,
'auth_config': auth.extract_auth_config_from_options(options),
'codereview': options.forced_codereview,
}
detected_codereview_from_url = False
if target_issue_arg:
......
......@@ -1922,7 +1922,7 @@ class TestGitCl(TestCase):
self.assertEqual(
git_cl.main(['set-close', '--issue', '1', '--gerrit']), 0)
def test_description_gerrit(self):
def test_description(self):
out = StringIO.StringIO()
self.mock(git_cl.sys, 'stdout', out)
self.calls = [
......@@ -1931,7 +1931,7 @@ class TestGitCl(TestCase):
((['git', 'config', 'branch.feature.remote'],), 'origin'),
((['git', 'config', 'remote.origin.url'],),
'https://chromium.googlesource.com/my/repo'),
(('GetChangeDetail', 'code.review.org',
(('GetChangeDetail', 'chromium-review.googlesource.com',
'my%2Frepo~123123', ['CURRENT_REVISION', 'CURRENT_COMMIT']),
{
'current_revision': 'sha1',
......@@ -1941,7 +1941,9 @@ class TestGitCl(TestCase):
}),
]
self.assertEqual(0, git_cl.main([
'description', 'https://code.review.org/123123', '-d', '--gerrit']))
'description',
'https://chromium-review.googlesource.com/c/my/repo/+/123123',
'-d']))
self.assertEqual('foobar\n', out.getvalue())
def test_description_set_raw(self):
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment